SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
56,927 Commits 2 Branches 1 Tag
7be4b23649c02df33e4292f37ffc8aecf512955a
Commit Graph
56927 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lennart Poettering 7be4b23649 efi-loader: split efi-api.[ch] from efi-loader.[ch] 
Some refactoring: split efi-loader.[ch] in two: isolate the calls that
implement out boot loader interface spec, and those which implement
access to upstream UEFI firmware features.

They are quite different in nature and behaviour, and even semantically
it makes to keep these two separate. At the very least because the
previous name "efi-loader.[ch]" suggests all was about loader-specific
APIs, but much of it is generic uefi stuff...

While we are at it, I renamed a bunch of return parameters to follow our
usual ret_xyz naming. But besides renaming no real code changes.
 2022-03-24 15:21:09 +01:00
Lennart Poettering 8fc5c44426 efivars: define efi variable flags less weirdly 
The flags are actually 32bit values, but aligned with zeroes befitting a
64bit value. Let's fix that.
 2022-03-24 15:21:03 +01:00
Lennart Poettering 187513fd3a efivarfs: rename a couple of return params to ret_xyz/ret 2022-03-24 15:20:57 +01:00
Lennart Poettering afd1a45a16 efivars: downgrade log level in systemd_efi_options_efivarfs_if_newer() 
The only caller logs anyway, let's avoid duplicate logging above
LOG_DEBUG.
 2022-03-24 15:20:53 +01:00
Lennart Poettering 83fe0be170 efivars: no need to convert ENOENT → ENODATA twice 
read_efi_options_variable() already does this, don#t do it again.
 2022-03-24 15:20:49 +01:00
Lennart Poettering bc5eb90015 efivars: tweak debug log message in efi_get_secure_boot_mode() 
mention what we'll do as effect of the error we are seeing and eat up.
 2022-03-24 15:20:45 +01:00
Lennart Poettering 3e09ad57c6 efivars: cache ENOENT as no efi secure boot 
On systems lacking EFI or the SecureBoot efi var the caching of this
info didn#t work, since we'd see ENOENT when reading the var, and cache
that, which we then use as reason to retry next time.

Let's fix that and convert ENOENT to "secure boot", because that's what
it really means. All other errors are left as is (and reason to retry).
But let's add some debug logging for that case.
 2022-03-24 15:18:52 +01:00
Lennart Poettering d01133125c bpf-firewall: invert test 
Following our coding style of exiting early (instead of deep nesting),
let's invert the if check here.

Inspired by: https://github.com/systemd/systemd/pull/21602#pullrequestreview-919960060
 2022-03-24 13:54:50 +01:00
David Tardon bbd2620022 logind-user: log about the right unit 2022-03-24 13:53:31 +01:00
Yu Watanabe f7adeaeb89 journal-remote: refuse to specify --trust option when gnutls is disabled 
and check_permission() should not be called in that case.

Replaces #22847.
 2022-03-24 13:53:04 +01:00
Antonio Alvarez Feijoo 7500c6cbef cryptsetup: fix typo 2022-03-24 12:08:54 +00:00
Lennart Poettering dca92ca300 update TODO 2022-03-24 09:44:52 +01:00
Yu Watanabe bc7a6ee4af Merge pull request #22800 from poettering/safe-ptr-sub1 
Add helper macro PTR_SUB1() to deal with backwards iteration through arrays without UB
 2022-03-24 06:34:09 +09:00
Yu Watanabe 2859932bd6 network: do not enable IPv4 ACD for IPv4 link-local address if ACD is disabled explicitly 
The commit 1cf4ed142d makes the IPv4 ACD
enabled unconditionally for IPv4 link-local addresses even if users
explicitly disable ACD.

This makes the IPv4 ACD is enabled by default, but honor user setting.

Fixes #22763.
 2022-03-23 17:59:38 +01:00
Frantisek Sumsal 000096f4c6 lgtm: disable cpp/missing-return (again) 
It looks like the fix for https://github.com/github/codeql/issues/8409
is not yet in production (and the respective query needs to be enabled
in both the main and the PR branch to get results for it, hence why it
passed in #22837).
 2022-03-23 16:40:33 +00:00
Heiko Becker 43a5fd98a5 meson: Detect python instead of hard-coding python3 
It allows to specify the desired python executable (and version) via
meson's native file if there are multiple versions available.
 2022-03-23 22:15:23 +09:00
Frantisek Sumsal 4da5e99a8f Revert "lgtm: disable cpp/missing-return" 
This reverts commit 6f4bffb586.

Should be, hopefully, fixed by https://github.com/github/codeql/issues/8409.
 2022-03-23 22:11:24 +09:00
Yu Watanabe 007950dcd1 dns-domain: use PTR_SUB1() macro 2022-03-23 21:57:59 +09:00
Yu Watanabe 93e04eb43b test: add tests for device id 2022-03-23 21:57:39 +09:00
Yu Watanabe 13659527ef sd-device: use path_find_last_component() to set driver subsystem 2022-03-23 21:57:39 +09:00
Yu Watanabe 3066293dd3 path-util: use PTR_SUB1() macro in path_find_last_component() 2022-03-23 21:57:39 +09:00
Yu Watanabe e7bf2fcab0 core/namespace: inline one more iterator variable 2022-03-23 21:57:39 +09:00
Lennart Poettering 3e3ee42072 tree-wide: use PTR_SUB1() at two places where appropriate 2022-03-23 21:57:25 +09:00
Lennart Poettering 13a5ffa477 doc: two markdown markup fixes 2022-03-23 13:47:15 +01:00
Lennart Poettering 50996f04ad macro: add macro that simplifies going backwards through an array via pointers 
Inspired by #22797, let's avoid some UB when iterating through arrays.
 2022-03-23 21:46:08 +09:00
Zbigniew Jędrzejewski-Szmek 4053d11006 various: inline some iterator variables 2022-03-23 21:46:05 +09:00
Lennart Poettering 3f4ead8d5f doc: add a bunch of missing <br> 2022-03-23 13:44:25 +01:00
Yu Watanabe 904447ce5a Merge pull request #22835 from keszybz/foreach_string-inline-iterator 
Inline the iterator declaration in FOREACH_STRING
 2022-03-23 21:43:02 +09:00
Zbigniew Jędrzejewski-Szmek 5c09daf8ff Merge pull request #22836 from poettering/more-build-image-docs 
docs: more tweaks for the image building docs
 2022-03-23 12:42:47 +01:00
Lennart Poettering f1a147f2be update TODO 2022-03-23 12:29:20 +01:00
Lennart Poettering 3976da0265 docs: extend BUILDING_IMAGES with a section about IMAGE_ID=/IMAGE_VERSION= 
Also, beef up links everywhere.
 2022-03-23 12:25:01 +01:00
Lennart Poettering 8f39ecf6aa docs: link up new image building docs a bit 2022-03-23 12:25:01 +01:00
Lennart Poettering a43d2229bb docs: make man page links in markdown Links section use teletype font, as we usually do 2022-03-23 12:25:01 +01:00
Zbigniew Jędrzejewski-Szmek b9fbff7403 systemctl: use the right name in error message 2022-03-23 11:50:18 +01:00
Zbigniew Jędrzejewski-Szmek 5980d46304 strv: declare iterator of FOREACH_STRING() in the loop 
Same idea as 03677889f0.

No functional change intended. The type of the iterator is generally changed to
be 'const char*' instead of 'char*'. Despite the type commonly used, modifying
the string was not allowed.

I adjusted the naming of some short variables for clarity and reduced the scope
of some variable declarations in code that was being touched anyway.
 2022-03-23 11:50:18 +01:00
Lennart Poettering 24f0c62df5 Merge pull request #22791 from keszybz/bootctl-invert-order 
Invert order of entries w/o sort-key in sd-boot menu
 2022-03-23 11:39:31 +01:00
Lennart Poettering 5b39139582 Merge pull request #22629 from nishalkulkarni/oomd_service_result 
core/oomd: Use oom-kill ServiceResult for oomd
 2022-03-23 10:11:45 +01:00
Yu Watanabe 7a692931ab sysupdate: fix error handling 2022-03-23 16:52:55 +09:00
Yu Watanabe 60f53dd5cc NEWS: fix typo 2022-03-23 12:22:53 +09:00
Yu Watanabe ff8619791a boot: fix typo 2022-03-23 12:21:54 +09:00
Lennart Poettering 4d5dacbef3 fs-util: make sure openat_report_new() initializes return param also on shortcut 
Our coding style dictates that return parameters should be initialized
always on success, hence do so here also in the shortcut codepath.

Issue discovered by @fbuihuu:

https://github.com/systemd/systemd/pull/22808/files/ca8503f168d0632c606110da909aba3057777395#r831911069
 2022-03-23 11:38:08 +09:00
Lennart Poettering b312236919 fs-util: fix typos in comments 2022-03-23 11:38:08 +09:00
Zbigniew Jędrzejewski-Szmek 77d45f1f83 meson: replace sh+find with an internal glob in the python helper 
As suggested in https://github.com/systemd/systemd/pull/22810#discussion_r831708052

This makes the whole thing simpler. A glob is passed to helper which then resolves
it on its own. This way it's trivial to call the helper with a different
set of files for testing.
 2022-03-23 11:37:35 +09:00
Yu Watanabe 14acae357b Merge pull request #22825 from keszybz/assorted-cleanups 
Assorted cleanups
 2022-03-23 11:34:46 +09:00
Luca Boccassi a8c122c4cb NEWS: adjust MONITOR_ env vars paragraph 
This actually never shipped in a release, so it's not a backward-incompatible
change. Move it down and reword it.
 2022-03-22 23:03:23 +00:00
Zbigniew Jędrzejewski-Szmek 00b29ca143 NEWS: initial writeup for v251 2022-03-22 21:21:01 +01:00
Luca Boccassi 961758c750 Merge pull request #22821 from poettering/udev-tweaklets 
Udev tweaklets
 2022-03-22 20:17:38 +00:00
Lennart Poettering 6538c0efca docs: add some docs about building OS images 
It's not trivial to know what to reset how. Let's document this a bit.
 2022-03-22 18:10:39 +01:00
Zbigniew Jędrzejewski-Szmek 5cad4c70e3 homework: s/EWOULDBLOCK/EAGAIN/ 
C.f. 012d7b4217, ff55c3c732,
ca2031fcc8.
 2022-03-22 14:07:53 +01:00
Zbigniew Jędrzejewski-Szmek 16568fd336 errno-to-awk: simplify expression 
No functional change.
 2022-03-22 14:07:53 +01:00