Commit Graph
36168 Commits
Author SHA1 Message Date
Tobias Jungel 7ecf0c3e17 networkd: don't remove route
In case networkd is restarted this prevents a removal of an already existing
route that would be configured using networkd. With the proposed changes the
route will be kept on the interface without removing. This happens only on
physical hosts or VMs since networkd handles interface configuration slightly
different in containers.
2018-11-06 13:28:12 +01:00
Tobias Jungel 30226d2718 networkd: don't remove ip address
In case networkd is restarted this prevents a removal of an already existing IP
address that would be configured using networkd. With the proposed changes the
IP address will be kept on the interface without removing. This happens only on
physical hosts or VMs since networkd handles interface configuration slightly
different in containers.
2018-11-06 13:26:37 +01:00
Lennart Poettering 8912a99cea Merge pull request #10606 from yuwata/udev-tests
test: mask hwdb-update.services in most tests
2018-11-05 23:14:42 +03:00
Lennart Poettering a54e373163 Merge pull request #10618 from yuwata/fix-10615
network: fix several issues in config parser
2018-11-05 17:37:25 +03:00
Lennart Poettering 780ccb7d9d Merge pull request #10641 from yuwata/fix-10639
network: check the value of prefix length
2018-11-05 16:11:50 +03:00
Yu Watanabe 3d8d1f13d5 test: add tests for config_parse_address() 2018-11-05 16:46:26 +09:00
Yu Watanabe b7cb445235 network: use in_addr_default_prefix_from_string_auto() in config_parse_address() 2018-11-05 16:46:26 +09:00
Yu Watanabe c1d58204b2 test: add tests for in_addr_default_prefix_from_string() or friend 2018-11-05 16:46:26 +09:00
Yu Watanabe a4798d4e6d util: introduce in_addr_default_prefix_from_string() and friends
It is similar to in_addr_prefix_from_string() but it determines
the prefix length from address if it is not specified.
2018-11-05 16:46:26 +09:00
Yu Watanabe 67944f5c26 util: use strndup() instead of strndupa()
As the input string may be comes from command line or config files.
2018-11-05 16:46:00 +09:00
Evgeny Vereshchagin 201bf07f7c tests: also use lsmod to check whether modules are available (#10634)
It's not entirely impossible to screw something up playing with
kernel modules on a Saturday evening :-) This PR fixes a scenario
where a module has been loaded into the kernel but the module itself
has been removed from the disk.

```
$ lsmod | grep wireg
wireguard             225280  0
ip6_udp_tunnel         16384  1 wireguard
udp_tunnel             16384  1 wireguard

$ modprobe wireguard
modprobe: FATAL: Module wireguard not found in directory /lib/modules/4.18.16-200.fc28.x86_64

$ sudo ./systemd-networkd-tests.py NetworkdNetDevTests.test_wireguard
...
modprobe: FATAL: Module wireguard not found in directory /lib/modules/4.18.16-200.fc28.x86_64
test_wireguard (__main__.NetworkdNetDevTests) ... unexpected success

----------------------------------------------------------------------
Ran 1 test in 5.152s

FAILED (unexpected successes=1)
```

This is a follow-up to https://github.com/systemd/systemd/pull/10625.
2018-11-05 12:47:38 +09:00
Lucas Werkmeister aaa501859f man: locale.conf: fix file name (#10637)
A simple copy+paste mistake, since the reference to
systemd-localed.service was added to both locale.conf(5) and
vconsole.conf(5) in the same commit (8968e36f21).
2018-11-05 12:47:09 +09:00
Evgeny Vereshchagin 7a3bc5a8e5 tests: add a basic test for wireguard (#10631) 2018-11-04 02:03:43 +09:00
Yu Watanabe 383bb2bc1a vlan-util: add assertions to parse_vlanid() 2018-11-04 00:31:46 +09:00
Yu Watanabe 2e5da68b7d network: add missing .sections element for vcan and vrf
Fixes #10629.
2018-11-04 00:31:46 +09:00
Yu Watanabe de4224aa22 network: fix memleak abot Address.label
Also fix possible memleak about Address.section.
Fixes #10628.
2018-11-04 00:31:46 +09:00
Yu Watanabe 22f64c32fa test: UseRoutes= and UseTimezone= need to be in [DHCP] section 2018-11-04 00:31:46 +09:00
Yu Watanabe 9a4720a9ef test-network: wait after removing links
After ec6a47044a, networkd starts
soon after removing links used by previous test. That causes
some racy situation of removing links and detecting links by networkd.
2018-11-04 00:31:46 +09:00
Yu Watanabe 7946d57f18 network: drop error cause in log message
Fixes for 21486d9e99.
2018-11-04 00:31:46 +09:00
Yu Watanabe ecee0abe77 network: fix memleak in static prefix
The fix by 744faf5e4e is not perfect,
as the section leaks if `hashmap_put()` in `prefix_new_static()` fails.
2018-11-04 00:31:46 +09:00
Yu Watanabe 6f1a96ded4 netdev: also support GENEVE.UDP6ZeroChecksum{Tx,Rx}=
After 53c06862c1, we prefer Checksum
instead of CheckSum. Let's do so for GENEVE netdev.
2018-11-04 00:31:46 +09:00
Yu Watanabe a6306c3176 man: drop duplicated line in systemd.netdev(5) 2018-11-04 00:31:46 +09:00
Yu Watanabe fd3005f9b8 network: fix worng offset for .network parser 2018-11-04 00:31:46 +09:00
Yu Watanabe 899f0d259d network: fix memleak in config_parse_hwaddr()
Fixes #10615.
2018-11-04 00:31:46 +09:00
Yu Watanabe 44386b449b network: improve readability of config_parse_ifalias() 2018-11-04 00:31:46 +09:00
Yu Watanabe 25ed70f76f network: fix possible memleak caused by multiple setting of Bridge=, Bond= or VRF= 2018-11-04 00:31:46 +09:00
Yu Watanabe 5f74e49e85 test: add test for radv_prefix_delegation_{from,to}_string() 2018-11-04 00:31:46 +09:00
Yu Watanabe 6b1dec6696 network: introduce radv_prefix_delegation_{from,to}_string() 2018-11-04 00:31:46 +09:00
Yu Watanabe 8a4871c7d1 network: fix indentation 2018-11-04 00:31:46 +09:00
Yu Watanabe 8627d1120a network: invert the order in comparison 2018-11-04 00:31:46 +09:00
Yu Watanabe 1176b054e1 network: shorten code a bit 2018-11-04 00:31:06 +09:00
Yu Watanabe ed94652a33 test: drop 'After=multi-user.target' from most of testsuite.service 2018-11-03 18:00:47 +09:00
Yu Watanabe 056ae88152 test: mask several unnecessary services
This may make CIs run faster.
2018-11-03 18:00:47 +09:00
Yu Watanabe f775f613ad test: increase timeout for TEST-17-UDEV-WANTS
As the test randomly fails with timeout.
This may fix #10274.
2018-11-03 18:00:47 +09:00
Yu Watanabe 76281c6408 test: also run compile tests for libudev.h 2018-11-03 18:00:47 +09:00
Felix Yan 3cc306e667 docs: Fix a typo in CODING_STYLE.md (#10630) 2018-11-03 17:38:41 +09:00
Yu Watanabe f48ef53fb6 Merge pull request #10625 from evverx/test_routing_policy_rule
tests: make NetworkdNetWorkTests.test_routing_policy_rule pass on CentOS
2018-11-03 17:02:21 +09:00
Evgeny Vereshchagin 7a0a37b283 tests: mark a few tests as expected failures when the required modules aren't available
Closes https://github.com/systemd/systemd/issues/10617.
2018-11-03 00:12:01 +01:00
Evgeny Vereshchagin f7bdd562a9 tests: make NetworkdNetWorkTests.test_routing_policy_rule pass on CentOS
Depending on the content of /etc/iproute2/rt_dsfield, ip can print either
`0x08` or `throughput` as was shown in https://github.com/systemd/systemd/issues/10617#issuecomment-435200859.
2018-11-02 17:10:59 +01:00
Zbigniew Jędrzejewski-Szmek 3da1da823c Merge pull request #10624 from splantefeve/fr-translation
po: update French translation and drop copyright
2018-11-02 15:05:00 +01:00
Sylvain Plantefève 1be100a05f po: drop my copyright (fr.po) 2018-11-02 14:39:19 +01:00
Sylvain Plantefève c38fbfe414 po: update French translation 2018-11-02 14:38:21 +01:00
Franck Bui 1d88bce2a0 coredump: only install coredump.conf when ENABLED_COREDUMP=true 2018-11-02 14:31:12 +01:00
Tobias Jungel 99f68ef02d networkd: add missing bonding options (#10542)
Add support for bonding options system prio, port key and actor system mac.

These options exist in the linux kernel since 4.2
(torvalds/linux@171a42c38c)

Details:
https://www.kernel.org/doc/Documentation/networking/bonding.txt
2018-11-02 10:31:20 +09:00
Evgeny Vereshchagin 9cbdf5db48 Merge pull request #10607 from yuwata/fix-10605
network: fix segfault in manager_free()
2018-11-02 02:52:53 +03:00
Yu Watanabe cb700a11d9 network: drop white space in log message 2018-11-01 23:41:29 +09:00
Yu Watanabe 0d7febd002 network: fix hash function for routing policy rule 2018-11-01 23:40:56 +09:00
Yu Watanabe e6b65ab760 network: fix return value of routing_policy_rule_get()
To distinguish source of rule.
2018-11-01 23:38:11 +09:00
Yu Watanabe a6276f0f3f network: fix memleak in routing policy
As set_put() may fail if input is duplicated.
2018-11-01 23:24:20 +09:00
Yu Watanabe 744faf5e4e network: fix memleak in static prefix
Fixes #10608.
2018-11-01 21:46:38 +09:00