SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
41,349 Commits 2 Branches 1 Tag
94595525aff748dce0de30fda10dd6685a474bbf
Commit Graph
41349 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Frantisek Sumsal 94595525af Merge pull request #12884 from mrc0mmand/numapolicy-test 
test: introduce TEST-36-NUMAPOLICY
 2019-08-05 18:02:40 +00:00
Zbigniew Jędrzejewski-Szmek aa39b24a86 shared/exit-status: fix off-by-one in comment 2019-08-05 16:38:20 +02:00
Zbigniew Jędrzejewski-Szmek 00d27e5dd7 shared/exit-status: fix lookup 
FLAGS_SET() is the wrong operator here, because we want to see if
*any* bits are set. Add test.

https://github.com/systemd/systemd/pull/12884#issuecomment-518238410
 2019-08-05 16:38:17 +02:00
Zbigniew Jędrzejewski-Szmek 77a5ae188b Merge pull request #13258 from yuwata/login-revert-handle-ignore-assertion 
Revert "logind: remove unused check"
 2019-08-05 15:43:23 +02:00
Frantisek Sumsal 92f8e97892 test: add a simple sanity check for systems without NUMA support 2019-08-05 15:05:32 +02:00
Frantisek Sumsal c7367d7cfd test: give strace some time to initialize 
The `coproc` implementation seems to be a little bit different in older
bash versions, so the `strace` is sometimes started AFTER `systemctl
daemon-reload`, which causes unexpected fails. Let's help it a little by
sleeping for a bit.
 2019-08-05 15:05:32 +02:00
Frantisek Sumsal b030847163 test: skip the test on systems without NUMA support 2019-08-05 15:05:32 +02:00
Frantisek Sumsal 56425e54a2 test: make sure the strace process is indeed dead 
It may take a few moments for the strace process to properly terminate
and write all logs to the backing storage
 2019-08-05 15:05:32 +02:00
Frantisek Sumsal ac14396d02 test: support MPOL_LOCAL matching in unpatched strace versions 
The MPOL_LOCAL constant is not recognized in current strace versions.
Let's match at least the numerical value of this constant until the
strace patch is approved & merged.
 2019-08-05 15:05:32 +02:00
Frantisek Sumsal d0b2178f3e test: replace tail -f with journal cursor which should be... 
more reliable
 2019-08-05 15:05:26 +02:00
Frantisek Sumsal 8f65e26508 test: introduce TEST-36-NUMAPOLICY 2019-08-05 13:48:29 +02:00
Frantisek Sumsal 761ce2a4ba test: allow overriding QEMU_OPTIONS from the outside 2019-08-05 13:48:29 +02:00
Yu Watanabe 41c81c4a62 udev: do not try to import properties on commented out lines 
Fixes #13257.
 2019-08-04 14:41:47 +02:00
Yu Watanabe 0c2d7a5134 Merge pull request #13256 from keszybz/minor-sd-network-cleanup 
Minor sd-network cleanup and other coverity-inspired changes
 2019-08-04 17:07:03 +09:00
Yu Watanabe 18f689b1fa Revert "logind: remove unused check" 
This reverts commit f2330acda4.

Fixes #13255.
 2019-08-04 05:44:36 +09:00
Yu Watanabe b518e02661 login: drop space in empty line 2019-08-04 05:44:36 +09:00
Zbigniew Jędrzejewski-Szmek a4fc96c823 pid1: replace asprintf() with strjoin() 
It's nicer. And coverity doesn't need to complain about unchecked return
value (CID#1401780).
 2019-08-03 17:46:56 +02:00
Zbigniew Jędrzejewski-Szmek 5d276aa201 sd-hwdb: use return value from ordered_hashmap_iterate() 
Why not? Coverity CID#1402329.
 2019-08-03 17:43:51 +02:00
Zbigniew Jędrzejewski-Szmek bc67342e94 libsystemd-network: make option_append() atomic and make the code a bit clearer 
Comparisons are done in the normal order (if (need > available), not if (available < need)),
variables have reduced scope and are renamed for clarity.

The only functional change is that if we return -ENAMETOOLONG, we do that
without modifying the options[] array.

I also added an explanatory comment. The use of one offset to point into three
buffers is not obvious.

Coverity (in CID#1402354) says that sname might be accessed at bad offset, but
I cannot see this happening. We check for available space before writing anything.
 2019-08-03 17:36:38 +02:00
Yu Watanabe 10b1d42e57 unit: make logind can access ESP 
Fixes the following error:
```
logind[601]: Failed to open file system "/dev/block/259:1": Operation not permitted
```
 2019-08-03 14:16:29 +02:00
Zbigniew Jędrzejewski-Szmek a94d2fa81a Merge pull request #13253 from yuwata/udev-update-logs 
udev: update log messages
 2019-08-03 14:15:52 +02:00
Yu Watanabe 20f45f4bb6 udev-node: fix misleading log messages 
This fixes the following logs:
```
drm_dp_aux2: Handling device node '/dev/drm_dp_aux2', devnum=c238:2, mode=037777777777, uid=4294967295, gid=4294967295
drm_dp_aux2: Preserve permissions of /dev/drm_dp_aux2, 037777777777, uid=4294967295, gid=4294967295
```
 2019-08-03 06:04:40 +09:00
Yu Watanabe 88d566aa23 udev-event: log device name on spawning commands 2019-08-03 05:38:27 +09:00
Miroslav Lichvar bca5a0eacc time-util: improve detection of synchronized clock 
Instead of checking for the STA_UNSYNC flag in the timex status, check
the maximum error. It is updated by the kernel, increasing at a rate of
500 ppm. The maximum value is 16 seconds, which triggers the STA_UNSYNC
flag.

This follows timedatex and allows timedated to correctly detect a clock
synchronized by chronyd when configured to not synchronize the RTC.
 2019-08-01 17:32:36 +02:00
Zbigniew Jędrzejewski-Szmek 1888e5bec6 Merge pull request #13243 from keszybz/two-cryptsetup-quickfixes 
Two cryptsetup quickfixes
 2019-08-01 17:31:12 +02:00
Zbigniew Jędrzejewski-Szmek fef716b28b cryptsetup: don't assert on variable which is optional 
https://github.com/systemd/systemd/commit/50d2eba27b9bfc77ef6b40e5721713846815418b#commitcomment-34519739

In add_crypttab_devices() split_keyspec is called on the keyfile argument,
which may be NULL.
 2019-08-01 09:49:24 +02:00
Zbigniew Jędrzejewski-Szmek 5d2100dc4c cryptsetup: use unabbrieviated variable names 
Now that "ret_" has been added to the output variables, we can name
the internal variables without artificial abbrevs.
 2019-08-01 08:13:13 +02:00
Frantisek Sumsal cd826afaf3 Merge pull request #13225 from mrc0mmand/networkd-test-replace-adduser-with-useradd 
test: use `useradd` instead of `adduser`
 2019-07-31 18:59:03 +00:00
Frantisek Sumsal 345997f393 test: print an error when networkctl returns an unexpected EC 
If networkctl crashes, like recently with SIGABRT, it returns absolutely
no output, which may be confusing during debugging. Help it a little
with a short informative message.
 2019-07-31 16:33:12 +02:00
Jan Synacek 28a06f5abe analyze-security: move assert above first use of the variable (#13238) 2019-07-31 16:13:35 +02:00
Zbigniew Jędrzejewski-Szmek 1be8044b5b Merge pull request #13239 from poettering/coverity-fixes 
four coverity fixes
 2019-07-31 16:08:52 +02:00
Lennart Poettering 3ff668cb9a man: reword DeviceAllow= documentation 
Don't claim we'd use cgroup.deny much. It's just a way to remove stuff
from device lists, which is nothing we allow users to explicitly
configure.

Also, extend documentation when wildcards may be used, and when not.
 2019-07-31 16:06:15 +02:00
Lennart Poettering 735a8b6d38 job: fix coverity issue 
Fixes coverity issue 1403550
 2019-07-31 09:45:03 +02:00
Lennart Poettering 38c569bbb8 test-chase-symlinks: fix coverity issue 
Fixes coverity issue 1403708
 2019-07-31 09:45:03 +02:00
Lennart Poettering 771f8aef57 unit-file: fix coverity issue 
Fixes coverity issue 1403820
 2019-07-31 09:39:12 +02:00
Lennart Poettering f4ea8432e6 cryptsetup-generator: fix coverity issue 
Fixes coverity issue 1403772
 2019-07-31 09:38:59 +02:00
Chris Down 5c76ca6093 NEWS: Remove DisableControllers from v243 
We already released this in v240 and had a NEWS entry then.
 2019-07-31 12:12:46 +09:00
Frantisek Sumsal 4967da2dbc test-execute: skip test_exec_systemcallfilter_system under ASan 
This particular test case keeps intermittently failing due to crashing
LSan  when running under clang+ASan. Generally, sanitizers don't
like seccomp filters, so the best option here is to just switch this
test off for this scenario.
 2019-07-31 09:45:26 +09:00
Mike Gilbert 417b82e1c3 analyze: declare dump_exit_status outside of HAVE_SECCOMP block 
Fixes: 76ed04d936
Closes: https://github.com/systemd/systemd/issues/13230
 2019-07-31 09:43:03 +09:00
Piotr Drąg 8c62066cd6 po: update Polish translation 2019-07-30 21:39:43 +02:00
Frantisek Sumsal 2de705cd1c test: use useradd instead of adduser 
`adduser` is in certain cases a standalone package which provides a
better user experience. In other cases it's just a symlink to `useradd`.
And some distributions don't have `adduser` at all, like Arch Linux.
Let's use the `useradd` binary instead, which should provide the same
functionality everywhere.
 2019-07-30 20:26:25 +02:00
Yu Watanabe 4c858c6fd5 boot: fix build with gnu-efi older than 3.0.5 2019-07-30 18:58:15 +02:00
Lennart Poettering 5756bff6f1 Merge pull request #13119 from keszybz/unit-loading-2 
Rework unit loading to take into account all aliases
 2019-07-30 17:55:37 +02:00
Zbigniew Jędrzejewski-Szmek 4860f5c2ae NEWS: more entries and some rewordings 2019-07-30 16:50:40 +02:00
Yu Watanabe 7c6de13f1b bash-completion: support "systemd-analyze exit-status" 2019-07-30 16:45:21 +02:00
Zbigniew Jędrzejewski-Szmek 9f4afc0154 Merge pull request #13189 from yuwata/network-initrd-generator-unit 
unit: update initrd-network-generator.service
 2019-07-30 16:38:59 +02:00
Yu Watanabe 45160216b7 networkctl: TABLE_BPS requires uint64_t 2019-07-30 15:09:16 +02:00
Zbigniew Jędrzejewski-Szmek 802765438f test-unit-file: allow printing of information about specific units 
Useful for manual debugging.
 2019-07-30 14:01:46 +02:00
Zbigniew Jędrzejewski-Szmek 91e0ee5f16 pid1: drop unit caches only based on mtime 
v2:
- do not watch mtime of transient and generated dirs

  We'd reload the map after every transient unit we created, which we don't
  need to do, since we create those units ourselves and know their fragment
  path.
 2019-07-30 14:01:46 +02:00
Zbigniew Jędrzejewski-Szmek e67cd21d7d analyze: add "unit-files" to dump the unit fragment map 
I'm not convinced that this is useful enough to be included... But it is
certainly nice when debugging.
 2019-07-30 14:01:46 +02:00