Yu Watanabe
9e7b922c8f
Merge pull request #27769 from YHNdnzj/loginctl-followup
...
loginctl: some follow-ups
2023-05-25 05:52:06 +09:00
Yu Watanabe
1f74369c2e
Merge pull request #27723 from YHNdnzj/service-restart-cleanup
...
core: get rid of unused Service.will_auto_restart logic
2023-05-25 05:14:52 +09:00
David Tardon
6de77384e0
system-update-generator: drop pointless goto
2023-05-25 04:01:31 +09:00
Yu Watanabe
290c4a4b34
Merge pull request #27173 from yuwata/update-utmp
...
update-utmp: do not fail when PID1 is reexecuting
2023-05-25 04:00:58 +09:00
Yu Watanabe
65d9bd5626
Merge pull request #27773 from dtardon/timestamp-cleanup
...
Use *timestamp_is_set() at more places
2023-05-25 03:27:15 +09:00
Yu Watanabe
3aa53842fd
Merge pull request #27774 from dtardon/free-cleanup
...
Use free_and_*() more
2023-05-25 03:06:51 +09:00
Mike Yuan
82449055af
loginctl: also show idle hint in session-status
2023-05-25 01:42:56 +08:00
Mike Yuan
8b0da9971a
loginctl: list-users: use bus_map_all_properties
2023-05-25 01:42:56 +08:00
Mike Yuan
be88af3d96
loginctl: list-sessions: fix timestamp for idle hint
...
Follow-up for 556723e738
TABLE_TIMESTAMP_RELATIVE takes a realtime timestamp.
2023-05-25 01:42:56 +08:00
Mike Yuan
c9443393b5
loginctl: some modernizations
2023-05-25 01:42:55 +08:00
Malte Poll and Otto Bittner
8d89d66ce8
ukify: fix handling signed kernel as file
...
The .linux section would contain the path to the signed kernel (instead of the signed kernel itself), since the python type of the variable is used to determine how it is handled when adding the pe sections.
Co-authored-by: Otto Bittner <cobittner@posteo.net >
2023-05-24 18:07:51 +01:00
David Tardon
eba1cf5638
timer: use dual_timestamp_is_set() at one more place
2023-05-24 16:41:41 +02:00
David Tardon
7bbfcf64b3
tree-wide: use timestamp_is_set() at more places
2023-05-24 16:41:37 +02:00
Mike Yuan
96b09de500
core: drop UnitNotifyFlags
...
This essentially reverts 2ad2e41a72 .
No longer needed after dropping UNIT_NOTIFY_WILL_AUTO_RESTART.
2023-05-24 21:37:02 +08:00
Mike Yuan
49b34f75e7
core: get rid of unused Service.will_auto_restart logic
...
The announced new behavior for OnFailure= never worked properly,
and we've fixed the document instead in #27675 .
Therefore, let's get rid of the unused logic completely. More at #27594 .
The to-be-added RestartMode= option should cover the use case hopefully.
Closes #27594
2023-05-24 21:37:02 +08:00
David Tardon
5bcd12cae0
journal-upload: use mfree()
2023-05-24 15:04:22 +02:00
David Tardon
a73e5eb94c
tree-wide: use free_and_str*dup() more
2023-05-24 15:03:55 +02:00
David Tardon
d6f2cd671c
tree-wide: use free_and_replace() more
2023-05-24 14:59:07 +02:00
Daan De Meyer
0de4bf409c
Merge pull request #27752 from DaanDeMeyer/timer-oncalendar-fix
...
core/timer: Always use inactive_exit_timestamp if it is set
2023-05-24 14:39:32 +02:00
Yu Watanabe
d689f70a2c
test: add test case for systemd-update-utmp vs daemon-reexec
2023-05-24 20:06:10 +09:00
Yu Watanabe
08bc702b12
test: drop a workaround
...
Follow-up for 61961e693d .
2023-05-24 20:06:10 +09:00
Yu Watanabe
fcb2343175
update-utmp: reconnect after sleep when PID1 is reexecuting
...
Fixes #27167 .
2023-05-24 20:06:10 +09:00
Yu Watanabe
87ae54533c
update-utmp: update log message
2023-05-24 20:06:10 +09:00
Yu Watanabe
86da32ee0c
update-utmp: downgrade log level of ignored failure
2023-05-24 20:06:10 +09:00
Yu Watanabe
4c40ab203c
update-utmp: swap q <-> r
...
We usually use 'r' for general purpose.
No functional change, just refactoring.
2023-05-24 20:06:10 +09:00
Yu Watanabe
3950d8f693
update-utmp: modernize get_startup_monotonic_time()
...
This also downgrade error level, as the failure will be ignored.
No functional change, just refactoring.
2023-05-24 20:06:07 +09:00
Yu Watanabe
309491e4cf
update-utmp: rebreak comments
2023-05-24 20:04:33 +09:00
Yu Watanabe
230f663e3e
update-utmp: use verbs
...
No functional change, just refactoring.
2023-05-24 20:04:33 +09:00
Yu Watanabe
5f1f05b961
Merge pull request #27740 from dtardon/list-sessions-idle
...
Show idle status in `loginctl list-sessions`
2023-05-24 20:03:39 +09:00
Yu Watanabe
8ddc5f7699
Merge pull request #27757 from dtardon/bus-locator
...
Convert more DBus calls to BusLocator
2023-05-24 20:02:57 +09:00
Daan De Meyer
e21f75afcd
timer: Use dual_timestamp_is_set() in one more place
2023-05-24 11:41:37 +02:00
Luca Boccassi
fe830b84d4
Merge pull request #27761 from yuwata/network-vlan-qos-mapping
...
network: fix vlan qos mapping
2023-05-24 09:59:41 +01:00
Daan De Meyer
6546045fa0
core/timer: Always use inactive_exit_timestamp if it is set
...
If we're doing a daemon-reload, we'll be going from TIMER_DEAD => TIMER_WAITING,
so we won't use inactive_exit_timestamp because TIMER_DEAD != UNIT_ACTIVE, even
though inactive_exit_timestamp is serialized/deserialized and will be valid after
the daemon-reload.
This issue can lead to timers never firing as we'll always calculate the next
elapse based on the current realtime on daemon-reload, so if daemon-reload happens
often enough, the elapse interval will be moved into the future every time, which
means the timer will never trigger.
To fix the issue, let's always use inactive_exit_timestamp if it is set, and only
fall back to the current realtime if it is not set.
2023-05-24 10:05:08 +02:00
David Tardon
556723e738
loginctl: show session idle status in list-sessions
2023-05-24 10:04:45 +02:00
Yu Watanabe
5c4e96c28c
test: rotate journal before storing coredumps
...
Hopefully fixes the failure like
https://jenkins-systemd.apps.ocp.cloud.ci.centos.org/job/upstream-vagrant-archlinux-sanitizers/2558/
---
[ 66.708894] testsuite-74.sh[728]: + coredumpctl --json=off
[ 66.709344] testsuite-74.sh[826]: TIME PID UID GID SIG COREFILE EXE SIZE
[ 66.709773] testsuite-74.sh[826]: Tue 2023-05-23 22:10:17 UTC 739 0 0 SIGTRAP journal /tmp/test-dump -
[ 66.711134] testsuite-74.sh[826]: Tue 2023-05-23 22:10:18 UTC 747 0 0 SIGABRT journal /tmp/test-dump -
[ 66.711789] testsuite-74.sh[826]: Tue 2023-05-23 22:10:19 UTC 763 0 0 SIGTRAP present /tmp/test-dump 53.5K
[ 66.712460] testsuite-74.sh[826]: Tue 2023-05-23 22:10:20 UTC 776 0 0 SIGABRT present /tmp/test-dump 53.3K
[ 66.713505] testsuite-74.sh[728]: + coredumpctl --root=/
[ 66.714144] testsuite-74.sh[828]: TIME PID UID GID SIG COREFILE EXE SIZE
[ 66.714535] testsuite-74.sh[828]: Tue 2023-05-23 22:10:17 UTC 739 0 0 SIGTRAP journal /tmp/test-dump -
[ 66.715208] testsuite-74.sh[828]: Tue 2023-05-23 22:10:18 UTC 747 0 0 SIGABRT journal /tmp/test-dump -
[ 66.715907] testsuite-74.sh[828]: Tue 2023-05-23 22:10:19 UTC 763 0 0 SIGTRAP present /tmp/test-dump 53.5K
[ 66.716565] testsuite-74.sh[828]: Tue 2023-05-23 22:10:20 UTC 776 0 0 SIGABRT present /tmp/test-dump 53.3K
[ 66.717494] testsuite-74.sh[728]: + coredumpctl --directory=/var/log/journal
[ 66.718188] testsuite-74.sh[830]: TIME PID UID GID SIG COREFILE EXE SIZE
[ 66.882072] testsuite-74.sh[830]: Tue 2023-05-23 22:10:17 UTC 739 0 0 SIGTRAP journal /tmp/test-dump -
[ 66.882642] testsuite-74.sh[830]: Tue 2023-05-23 22:10:18 UTC 747 0 0 SIGABRT journal /tmp/test-dump -
[ 66.883450] testsuite-74.sh[830]: Tue 2023-05-23 22:10:19 UTC 763 0 0 SIGTRAP present /tmp/test-dump 53.5K
[ 66.883944] testsuite-74.sh[830]: Tue 2023-05-23 22:10:20 UTC 776 0 0 SIGABRT present /tmp/test-dump 53.3K
[ 66.885448] testsuite-74.sh[728]: + coredumpctl --file=/var/log/journal/2e1ed84be19a4e22adfc99ad849be1f6/system.journal
[ 66.885989] testsuite-74.sh[728]: + at_exit
[ 66.894162] coredumpctl[833]: No coredumps found.
---
2023-05-24 09:22:13 +02:00
David Tardon
3ac26d0718
oomctl: convert a oom1.Manager call to BusLocator
2023-05-24 08:50:02 +02:00
David Tardon
86257d9fd8
bus-locator: sort the list
2023-05-24 08:50:02 +02:00
David Tardon
1925011748
bus-locator: declare bus locator for oom1 and timesync1
2023-05-24 08:50:02 +02:00
David Tardon
d14bd34f25
hostnamectl: convert more hostname1 calls to BusLocator
2023-05-24 08:33:22 +02:00
David Tardon
7f8a85e6d8
tree-wide: convert more resolve1.Manager calls to BusLocator
2023-05-24 08:33:22 +02:00
David Tardon
daecc5b95b
journalctl: convert a machine1.Manager call to BusLocator
2023-05-24 08:33:22 +02:00
David Tardon
a29f13f296
sleep: convert a home1.Manager call to BusLocator
2023-05-24 08:33:22 +02:00
David Tardon
6ce68c7c51
login: use NULL to denote arg-less method call
...
"" and NULL are equivalent, but the latter is normally used.
2023-05-24 08:32:13 +02:00
David Tardon
d962e73796
tree-wide: convert more login1.Manager calls to BusLocator
2023-05-24 08:24:00 +02:00
David Tardon
b71471684a
tree-wide: convert more system1.Manager calls to BusLocator
2023-05-24 08:23:59 +02:00
Yu Watanabe
73d24e45f8
test-network: add tests for vlan QoS mapping
2023-05-24 11:15:44 +09:00
Yu Watanabe
4194478af8
network/vlan: paranoia about type safety
...
No functional change, as the struct is defined as the following:
```
struct ifla_vlan_qos_mapping {
__u32 from;
__u32 to;
};
```
2023-05-24 11:06:43 +09:00
Yu Watanabe
4d13d175f8
network/vlan: drop unnecessary restriction for QoS mapping
...
Fixes #27460 .
2023-05-24 11:02:39 +09:00
Yu Watanabe
5dc0c21b31
core/slice: shorten code a bit
2023-05-24 10:26:21 +09:00
Jan Janssen
ab7d54b9dd
elf2efi: Do not emit an empty relocation section
...
At least shim will choke on an empty relocation section when loading the
binary. Note that the binary is still considered relocatable (just with
no base relocations to apply) as we do not set the
IMAGE_FILE_RELOCS_STRIPPED DLL characteristic.
2023-05-23 22:47:28 +01:00