Commit Graph
35945 Commits
Author SHA1 Message Date
Lukas Nykryn a7dd6d04b0 debug-generator: introduce rd.* version of all options 2018-10-25 17:05:50 +02:00
Lukas Nykryn ed58820d76 proc-cmdline: introduce PROC_CMDLINE_RD_STRICT
Our current set of flags allows an option to be either
use just in initrd or both in initrd and normal system.
This new flag is intended to be used in the case where
you want apply some settings just in initrd or just
in normal system.
2018-10-25 16:21:26 +02:00
Martin Wilck e1e74614aa core: don't create Requires for workdir if "missing ok"
Don't add an implicit RequiresMountsFor depenency for the
WorkingDirectory of a unit if the "-" character was used to
indicate that "a missing working directory is not considered fatal"
(see systemd.exec(5)). Otherwise systemd might fail the unit
because of missing dependencies.
2018-10-25 11:35:59 +02:00
Yu Watanabe 4e412d2684 string-util: fix prototype of explicit_bzero_safe() (#10513)
Follow-up for 87f5446311.
2018-10-25 11:41:55 +09:00
Lennart Poettering def34f63fe time-util: change parse_sec_fix_0() to accept "0s" for infinity too (#10501)
This function is about compatibility, nothing else, hence we should make
it properly compatible.

Fixes: #9556
2018-10-25 05:21:28 +09:00
Lennart Poettering d776fd08a3 Merge pull request #10510 from poettering/uacess-brackets
coverity fixes
2018-10-24 22:18:33 +02:00
Lennart Poettering 5ee91c0dbc man: fix wording a bit on the cgroup accountings options (#10509)
The &MEMORY_ACCOUNTING_DEFAULT; resolves to "yes" or "no" while the rest
of the paragraph talked about "on" and "off". Let's adjust this and
stick to "yes" and "no"...

Quite frankly I think it's not a particularly good idea to change the
docs based configuration changes... THis can only be incomplete, and the
wording is still very awkward since we repeat the same sentence twice.
2018-10-25 05:08:07 +09:00
Lennart Poettering c069e28961 Merge pull request #10505 from poettering/have-namespace
skip various test-execute tests when we have no namespacing
2018-10-24 22:00:42 +02:00
Lennart Poettering 73f19ce1ae units: drop systemd-user-sessions.service ordering dep on systemd-journal-flush.service (#10502)
THis dep existed since the unit was introduced, but I cannot see what
good it would do. Hence in the interest of simplifying things, let's
drop it. If breakages appear later we can certainly revert this again.

Fixes: #10469
2018-10-25 04:41:02 +09:00
Lennart Poettering 87f5446311 string-util: introduce explicit_zero_safe()
The only real difference is that this wrapper can deal with NULL
pointer arguments, but only if the length is also zero.

CID 1396277
2018-10-24 21:00:15 +02:00
Lennart Poettering 7388cea30d udev: use right error variable to make level decision 2018-10-24 20:47:52 +02:00
Lennart Poettering dc4fedd8cb udev: fix bad if {}
CID 1396318
CID 1396319
2018-10-24 20:46:41 +02:00
Lennart Poettering 5f00dc4df6 test: skip various tests if namespacing is not available
Apparently on Debian LXC/AppArmor doesn't allow namespacing to container
payloads. Deal with it.

Fixes: #9700
2018-10-24 19:40:24 +02:00
Lennart Poettering a4bc3c1d25 tests: add helper call have_namespaces() to test whether Linux namespaces are available
A slighly sloppy test call for conditionalizing several tests.
2018-10-24 19:40:24 +02:00
Lennart Poettering 795919efdf tests: as per CODING_STYLE undefine basename() right after including libgen.h 2018-10-24 17:08:12 +02:00
Lennart Poettering eca27ebbc8 tests: alloc-util.h and fs-util.h are our own headers
Hence include them with "" rather than <>. Also including them twices is
a pretty bad idea too.
2018-10-24 17:08:12 +02:00
Lennart Poettering 2194547e3b execute: if we fail to do namespacing, explain why we refuse to continue in a debug message 2018-10-24 17:08:12 +02:00
Lennart Poettering d1db1c438f Merge pull request #10484 from yuwata/udev-spawn-simplify
udev-event: cleanups about udev_event_spawn()
2018-10-24 10:57:45 +02:00
Lennart Poettering e7b48c45ae Merge pull request #10498 from yuwata/udev-builtin-log
udev-builtin: use log_device_*() macros
2018-10-24 10:53:35 +02:00
Lennart Poettering 77d28bd10f Merge pull request #10483 from yuwata/udev-cleanup-10
tree-wide: use log_device_*()
2018-10-24 10:51:53 +02:00
Lennart Poettering 086712f99f Merge pull request #10461 from yuwata/small-cleanups
Fixes recent defects reported by coverity
2018-10-24 10:36:20 +02:00
Jiuyang liu a2f577fca0 add ephemeral to nspawn-settings. 2018-10-24 10:22:20 +02:00
Yu Watanabe 1cb7d29d68 udevadm-info: fix memleak
Fixes CID#1396276.
2018-10-24 05:04:01 +09:00
Yu Watanabe a0570c1a82 udevadm-monitor: initialize variable
Fixes CID#1396278.
2018-10-24 05:04:01 +09:00
Yu Watanabe db8794c3a0 modules-load: return first error in the loop
Follow-up for a889e206a7.
Fixes CID#1396280.
2018-10-24 05:04:01 +09:00
Yu Watanabe fd5ad16cfb reply-password: initialize 'length' variable
Follow-up for 1fd2786161.

This fixes the following warning when built by clang:
```
../src/reply-password/reply-password.c:76:21 warning: variable 'length' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
```

Fixes CID#1396281 and CID#1396277.
2018-10-24 05:03:00 +09:00
Yu Watanabe ec9d636b37 core: use ascii_toupper() instead of everytime judging whether it is the first message 2018-10-24 04:58:08 +09:00
Yu Watanabe e81c3a4c5f udev-event: use sd_event_add_io() for reading stdout or stderr of spawned process 2018-10-24 04:46:48 +09:00
Yu Watanabe 4e57ad3578 udev-event: unify two log_*() by log_full() 2018-10-24 04:46:48 +09:00
Yu Watanabe 5ca3dbc91a udev-event: Capitalize log messages 2018-10-24 04:46:48 +09:00
Yu Watanabe 2e48548fed udev-event: fix condition to create pipe fds
The bug was introduced by feaa6db7ac.
2018-10-24 04:46:48 +09:00
Yu Watanabe f71e8ec10e udev-event: set O_CLOEXEC to pipe fds 2018-10-24 04:46:48 +09:00
Yu Watanabe 947ce772d9 udev-event: make failure in getting device properties fatal 2018-10-24 04:46:48 +09:00
Yu Watanabe a41ff38b09 test: create /dev/null in test-udev.pl 2018-10-24 04:46:48 +09:00
Yu Watanabe 84b1ccb98b udev-event: use rearrange_stdio() and close_all_fds() 2018-10-24 04:46:48 +09:00
Yu Watanabe 6ce075a23a udev-event: set FORK_DEATHSIG flag 2018-10-24 04:46:48 +09:00
Yu Watanabe 63ec4dfaa1 udev-event: drop redundant code
We have set FORK_RESET_SIGNALS in safe_fork(). So, calling
reset_signal_mask() after safe_fork() is redundant.
2018-10-24 04:46:48 +09:00
Yu Watanabe 3ad4d482c7 udev-event: move debug logging before safe_fork()
This fixes the following journal layout issue:
```
Oct 22 15:26:02 systemd-udevd[348]: RUN '/usr/sbin/setregdomain' /usr/lib/udev/rules.d/85-regulatory.rules:5
Oct 22 15:26:02 [439]: Starting '/usr/sbin/setregdomain'
Oct 22 15:26:02 systemd-udevd[348]: Process '/usr/sbin/setregdomain' succeeded.
```
2018-10-24 04:46:48 +09:00
Yu Watanabe d9de38caa4 udev-builtin-input_id: update log messages 2018-10-24 04:33:21 +09:00
Yu Watanabe 9a6e5c24ba udev-builtin-usb_id: update log messages 2018-10-24 04:31:48 +09:00
Yu Watanabe 883658b8f1 udev-builtin-uaccess: update log messages 2018-10-24 04:31:48 +09:00
Yu Watanabe 70fbab6e48 udev-builtin-net_setup_link: update log messages 2018-10-24 04:31:48 +09:00
Yu Watanabe 2dccfe4c2d udev-builtin-keyboard: update log messages 2018-10-24 04:31:48 +09:00
Yu Watanabe f3f80f43aa sd_hwdb: update log messages 2018-10-24 04:31:48 +09:00
Yu Watanabe 5ad71e4490 udev-builtin-btrfs: add debug log messages 2018-10-24 04:31:23 +09:00
Yu Watanabe 5c614b79f4 udev-builtin-blkid: add more debug log messages 2018-10-24 04:31:23 +09:00
Yu Watanabe b0db44fe15 udev-builtin: fix return value of udev_builtin_hwdb()
This fixes a bug introduced by d354690e7d.
Also, this adds more debug logs.
2018-10-24 04:30:05 +09:00
Yu Watanabe ec2e8c3a62 sd-device: fix argument name in log_device_*() macros
Follow-up for b0cba0ca52.
2018-10-24 04:29:00 +09:00
Evgeny Vereshchagin c8758e726c journald: use the "driver" transport for logging a refused connection
Otherwise, these messages can end up in `/dev/null` when journald is run
in containers as was shown in https://github.com/systemd/systemd/pull/10444#issuecomment-430927793.
2018-10-23 19:36:52 +02:00
Evgeny Vereshchagin 9e8b1ec08e sd-journal: escape binary data in match_make_string()
Fixes: #10383
2018-10-23 19:33:01 +02:00