Commit Graph
67462 Commits
Author SHA1 Message Date
Frantisek Sumsal 7e107bc31f test-network: probe a couple of uncovered networkctl codepaths 2023-07-18 21:42:39 +02:00
Frantisek Sumsal aca99a3a38 test-network: validate JSON where applicable 2023-07-18 21:42:39 +02:00
Daan De Meyer e30c6e913c repart: Always take --offline into account 2023-07-18 18:26:23 +02:00
Luca Boccassi 25c66abbed NEWS: note that /run/host/os-release is available more broadly 2023-07-18 17:26:02 +01:00
Luca Boccassi 947d836a6e man: explicitly note that units surviving soft-reboot should not pin resources 2023-07-18 17:26:02 +01:00
Luca Boccassi 3f37a82545 core: copy the host's os-release for /run/host/os-release
Currently for portable services we automatically add a bind mount
os-release -> /run/host/os-release. This becomes problematic for the
soft-reboot case, as it's likely that portable services will be configured
to survive it, and thus would forever keep a reference to the old host's
os-release, which would be a problem because it becomes outdated, and also
it stops the old rootfs from being garbage collected.

Create a copy when the manager starts under /run/systemd/propagate instead,
and bind mount that for all services using RootDirectory=/RootImage=, so
that on soft-reboot the content gets updated (without creating a new file,
so the existing bind mounts will see the new content too).

This expands the /run/host/os-release protocol to more services, but I
think that's a nice thing to have too.

Closes https://github.com/systemd/systemd/issues/28023
2023-07-18 17:26:02 +01:00
Zbigniew Jędrzejewski-Szmek 7e90814f0a Deprecate efivar SystemdOptions
As mentioned in the NEWS entry, it seems to see very little use, but adds
complexity in our code. It was added mainly with the goal of making it easier
for people using grub2 to modify their boot configuration, but grub2 is gaining
support for BLS snippets. On the systemd side, we now have credentials. So
let's deprecate this, and if there's no outcry, remove it in a few releases.
2023-07-18 17:30:06 +02:00
Petr Menšík 96d384ca4f Include in manual what DNSSEC=no means in detail
https://www.rfc-editor.org/rfc/rfc4035.html#section-3.2.1 says
security-aware recursive name server MUST set DO bit when sending
requests. systemd-resolved does not do that by design. State it more
clearly in manual page. Unlike other implementations it disables not
only validation as it stated, but complete DNSSEC awareness.

Signed-off-by: Petr Menšík <pemensik@redhat.com>
2023-07-18 17:28:32 +02:00
Joerg Behrmann c46f5680ca analyze: don't warn about version spec compliant versions
This commits adds version_is_valid_versionspec and uses it in
analyze-compare-version.c.

version_is_valid_versionspec differs from version_is_valid in that it acepts
empty strings and since valid characters in a version spec version are all
ASCII letters and digits as well as "-.~^", but ",_+" allowed by
version_is_valid are not.

Also give a more specific warning message on invalid characters.
2023-07-18 15:57:15 +01:00
Frantisek Sumsal 1dfa58edd3 Revert "packit: temporarily use older Rawhide spec"
This reverts commit f1adb4a2ea.
2023-07-18 15:28:07 +02:00
Yu Watanabe 74c4ad58dd Merge pull request #28424 from mrc0mmand/networkd-ra-captive-portals
test-network: check for captive portals received via NDISC
2023-07-18 22:02:44 +09:00
Daan De Meyer 106fcf0d06 test-resolved-stream: Use a random port number
Hopefully fixes #28393
2023-07-18 14:48:07 +02:00
Frantisek Sumsal c1dd58b3b6 test-network: check for captive portals received via NDISC
This requires fairly recent radvd that supports sending RAs with captive
portals [0].

Also, this should hopefully provide coverage for issues like:
  - https://github.com/systemd/systemd/issues/28229
  - https://github.com/systemd/systemd/issues/28231
  - https://github.com/systemd/systemd/issues/28277

[0] https://github.com/radvd-project/radvd/pull/141
2023-07-18 11:38:58 +02:00
Ronan Pigott 8a8caeccb2 zsh: stop forcing unit file cache rebuilds
Rebuilding whenever the cached parameter is not set forces each new
shell to rebuild the cache, which often defeates the purpose of caching
in the first place.
2023-07-17 16:38:25 -07:00
Ronan Pigott 087f777a1c zsh: default to system manager when not specified
This used to work correctly, before the change was reverted in
e09d0d46c2. In fact it is important to specify the manager explicity
in the completion because the argument is reused in the caching
policies. An empty argument here caused the completion to create
separate caches with and without the --system parameter. We can simplify
the given pattern a little here too.
2023-07-17 16:35:29 -07:00
Ronan Pigott d0fc94a192 zsh: suppress aliases and shell functions when calling systemctl
This prevents any errors in case the user had aliased some arguments
following systemctl.
2023-07-17 16:20:03 -07:00
Ronan Pigott 3b4c6009c0 zsh: typo in systemctl completions 2023-07-17 16:08:58 -07:00
Luca Boccassi cc037f2b48 test: exit early from TEST-70-TPM2 on ppc64el
There is an underlying issue that appears only on ppc64 and fails 95%
of Ubuntu runs, so exit early until it is solved.

Closes https://github.com/systemd/systemd/issues/27716
2023-07-17 22:47:06 +01:00
Frantisek Sumsal c4b167f857 ci: drop super-linter's shellcheck
It's been a while since we introduced Differential ShellCheck and it
proved to be quite useful (and in some ways even better than the shellcheck
run by super-linter). So, to have only one linter scream at us for not
knowing how to write bash properly, let's drop the super-linter's one in
favor of Differential ShellCheck.

Follow-up for https://github.com/systemd/systemd/pull/24328#pullrequestreview-1074127504
2023-07-17 20:12:57 +01:00
Zbigniew Jędrzejewski-Szmek 497cee3082 network: warning message fixlet
"Address 1.2.3.4" works as a proper noun, so the article is not
appropriate.
2023-07-17 20:57:42 +02:00
Zbigniew Jędrzejewski-Szmek 9194c1e697 sd-device, basic: align backslashes and drop unnecessary parens
Follow-up for a1af83728f
and 2507731374.
2023-07-17 20:57:42 +02:00
Zbigniew Jędrzejewski-Szmek 0134afe30d TODO: put journal-related stuff together 2023-07-17 20:57:42 +02:00
Zbigniew Jędrzejewski-Szmek 28e014fed0 sysusers: reduce duplication in param list definition 2023-07-17 20:57:42 +02:00
Zbigniew Jędrzejewski-Szmek ed5ce9ad1d Merge pull request #28384 from ldv-alt/ERRNO_IS
treewide: fix use of ERRNO_IS_*(r)
2023-07-17 18:07:07 +02:00
Daan De Meyer f2aaa14d37 units: Add --graceful flag to pcrphase units
Some of the new units using systemd-pcrphase are missing the --graceful
flag which causes them to error if the tpm libraries are not installed.
Add --graceful just like in the other pcrphase units to make systemd-pcrphase
exit gracefully if the tpm libraries are missing.
2023-07-17 14:24:46 +02:00
Luca Boccassi 70875a48ac Merge pull request #28425 from weblate/weblate-systemd-master
Translations update from Fedora Weblate
2023-07-17 13:07:03 +01:00
Luna Jernberg cd69984445 po: Translated using Weblate (Swedish)
Currently translated at 100.0% (227 of 227 strings)

Co-authored-by: Luna Jernberg <bittin@reimu.nl>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/sv/
Translation: systemd/main
2023-07-17 13:20:59 +02:00
김인수 e5e45bbb33 po: Translated using Weblate (Korean)
Currently translated at 100.0% (227 of 227 strings)

Co-authored-by: 김인수 <simmon@nplob.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/ko/
Translation: systemd/main
2023-07-17 13:20:59 +02:00
Pavel Borecki dd1674f00a po: Translated using Weblate (Czech)
Currently translated at 93.3% (212 of 227 strings)

Co-authored-by: Pavel Borecki <pavel.borecki@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/cs/
Translation: systemd/main
2023-07-17 13:20:59 +02:00
Frantisek Sumsal 5a000cd46f test-network: correctly support running systemd-udevd from the build dir
We create the udevadm -> systemd-udevd symlink during the install phase,
so it doesn't exist in the just compiled tree. This worked in CI since
the symlink is manually created there post-build.
2023-07-17 12:56:58 +02:00
Dan Streetman d980371669 test: avoid TEST-70 passphrase and password file mode complaints
Minor change, to adjust mode of /tmp/passphrase and /tmp/password test files to
avoid repeated warning logs that each file "...has 0644 mode that is too
permissive, please adjust the ownership and access mode."
2023-07-16 11:53:30 +01:00
Dmitry V. Levin fce846e0ac test: fix use of ERRNO_IS_PRIVILEGE()
Given that ERRNO_IS_PRIVILEGE() also matches positive values,
make sure this macro is not called with arguments that do not have
errno semantics.

In this case the arguments passed to ERRNO_IS_PRIVILEGE() are the values
returned by read_one_line_file() which can legitimately return positive
values without errno semantics, so fix this by moving ERRNO_IS_PRIVILEGE()
invocations to the branches where the return values are known to be negative.
2023-07-16 10:53:30 +00:00
Dmitry V. Levin 0bdea17c0a resolved: fix use of ERRNO_IS_DISCONNECT()
Given that ERRNO_IS_DISCONNECT() also matches positive values,
make sure this macro is not called with arguments that do not have
errno semantics.

In this case the argument passed to ERRNO_IS_DISCONNECT() is the value
returned by manager_recv() which can legitimately return 1 without errno
semantics, so fix this by moving ERRNO_IS_DISCONNECT() invocation to the
branch where the return value is known to be negative.
2023-07-16 10:53:30 +00:00
Dmitry V. Levin bb228f0ebc sd-bus: fix use of ERRNO_IS_DISCONNECT()
Given that ERRNO_IS_DISCONNECT() also matches positive values,
make sure this macro is not called with arguments that do not have
errno semantics.

In this case the argument passed to ERRNO_IS_DISCONNECT() is the value
returned by bus_socket_process_watch_bind(), bus_socket_process_opening(),
and bus_socket_process_authenticating() which can legitimately return
positive values without errno semantics, so fix this by moving the
ERRNO_IS_DISCONNECT() invocation to the branch where the return value
is known to be negative.
2023-07-16 10:53:30 +00:00
Dmitry V. Levin d5f8890bbf socket: fix use of ERRNO_IS_DISCONNECT()
Given that ERRNO_IS_DISCONNECT() also matches positive values,
make sure this macro is not called with arguments that do not have
errno semantics.

In this case the argument passed to ERRNO_IS_DISCONNECT() is the value
returned by socket_acquire_peer() which can legitimately return 1
without errno semantics, so fix this by moving ERRNO_IS_DISCONNECT()
invocation to the branch where the return value is known to be negative.
2023-07-16 10:53:30 +00:00
Dmitry V. Levin ed3745b51c kbd-util: fix use of ERRNO_IS_RESOURCE()
Given that ERRNO_IS_RESOURCE() also matches positive values,
make sure this macro is not called with arguments that do not have
errno semantics.

In this case the argument passed to ERRNO_IS_RESOURCE() is the value
returned by recurse_dir_at() which can legitimately return positive
values without errno semantics, so fix this by moving the ERRNO_IS_RESOURCE()
invocation to the branch where the return value is known to be negative.
2023-07-16 10:53:30 +00:00
Luca Boccassi d80cc39558 bus: add some minimal bounds check on signatures
CID#1491292
CID#1491291
CID#1491290
CID#1491289
CID#1491284
CID#1491281
CID#1491280
CID#1491278
2023-07-16 11:32:54 +01:00
Dan Streetman f230572f56 tpm2: add tpm2_get_pin_auth()
Add function to calculate the hash digest for a provided pin, and also verify
that the final byte in the digest is not 0. This is required because the TPM
will always remove all trailing 0's from an auth value before using it.

Fixes: #27716
2023-07-16 01:18:03 +01:00
Luca Boccassi 5f03212abb glob-util: add assert to silence coverity
CID#1491968
2023-07-16 00:44:46 +01:00
Luca Boccassi 8ecd67e18e efi: add assert to silence coverity
CID#1502668
2023-07-16 00:39:13 +01:00
Daan De Meyer fa5d277512 Merge pull request #28416 from bluca/gpt_mips
Two more fixes for MIPS and sd-gpt
2023-07-15 21:07:56 +02:00
Emanuele Giuseppe EspositoandZbigniew Jędrzejewski-Szmek 7d481546ac man/ukify: describe 'inspect'
Co-authored-by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
2023-07-15 19:43:57 +02:00
Emanuele Giuseppe EspositoandZbigniew Jędrzejewski-Szmek 805d41e279 ukify/test_ukify: test display verb
Co-authored-by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
2023-07-15 19:41:51 +02:00
Emanuele Giuseppe EspositoandZbigniew Jędrzejewski-Szmek df4a46733a ukify: add a verb to inspect the PE sections
Since PE can't be read with a normal editor, provide functionality to read PE
sections and output their name and when possible the content too.

ukify inspect <file> describes the sections and print the content of the
well-known sections to stdout.

Co-authored-by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
2023-07-15 19:41:51 +02:00
Susant Sahani cb35a0d43e network: DHCP4 allow to set InitialCongestionWindow and InitialAdvertisedReceiveWindow 2023-07-15 19:24:27 +05:30
Luca Boccassi c26a01ac8b sd-gpt: __mips__ is also defined when building __mips64
Follow-up for d75ec33ed2
2023-07-15 14:28:35 +01:00
Luca Boccassi 10ad311e7c gpt: it's __mips64, not __mips64__
But it's __mips__ not __mips, obviously

Follow-up for d75ec33ed2
2023-07-15 14:28:35 +01:00
Piotr Drąg f69620c7f0 po: Translated using Weblate (Polish)
Currently translated at 100.0% (227 of 227 strings)

Co-authored-by: Piotr Drąg <piotrdrag@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/pl/
Translation: systemd/main
2023-07-15 14:18:55 +02:00
Haochen Tong b23c7e1436 NEWS: fix typo 2023-07-15 17:59:49 +09:00
Temuri Doghonadze 73d8e9ccc4 po: Translated using Weblate (Georgian)
Currently translated at 100.0% (227 of 227 strings)

po: Translated using Weblate (Georgian)

Currently translated at 97.3% (221 of 227 strings)

po: Translated using Weblate (Georgian)

Currently translated at 94.2% (214 of 227 strings)

po: Translated using Weblate (Georgian)

Currently translated at 90.3% (205 of 227 strings)

po: Translated using Weblate (Georgian)

Currently translated at 88.9% (202 of 227 strings)

Co-authored-by: Temuri Doghonadze <temuri.doghonadze@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/ka/
Translation: systemd/main
2023-07-15 10:00:59 +08:00