SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
41,085 Commits 2 Branches 1 Tag
afaae43bb191dc187a366fc3595b6b4e34039acf
Commit Graph
26466 Commits
Author SHA1 Message Date
Yu Watanabe f7f196adfa Merge pull request #13037 from poettering/shutdown-log-fixes 
Shutdown log fixes
 2019-07-13 23:00:12 +09:00
Yu Watanabe 3f127e3981 Merge pull request #13041 from poettering/firstboot-fixes 
two systemd-firstboot fixes
 2019-07-13 22:59:43 +09:00
Yu Watanabe 56637e5c20 udev: make Match.OriginalName=* matches all interfaces 
Fixes #13035.
 2019-07-13 18:29:37 +09:00
Yu Watanabe 94e016650d Merge pull request #13043 from poettering/strip-tab-ansi-no-static-size 
util-lib: [static] array argument sizes are apparently not OK for NUL…
 2019-07-13 18:12:39 +09:00
Lennart Poettering 4aeadec7e6 firstboot: use color in welcome text 2019-07-13 11:07:51 +02:00
Lennart Poettering bdd7cd264a firstboot: suppress locale menu if there's nothing to choose from 2019-07-13 11:07:51 +02:00
Lennart Poettering 56e8419aa8 main: use sysctl_writef() where appropriate 2019-07-13 11:05:07 +02:00
Lennart Poettering e7ac08e4e0 shutdown: merge variable declaration lines a bit 2019-07-13 11:05:07 +02:00
Lennart Poettering 9a75c65248 shutdown: bump kmsg log level to LOG_WARNING only 
Fixes: #12337
 2019-07-13 11:05:07 +02:00
Lennart Poettering 477851f5d6 shutdown: rework bump_sysctl_printk_log_level() to use sysctl_writef() 2019-07-13 11:05:07 +02:00
Lennart Poettering 6a47f2a714 sysctl: add sysctl_writef() helper 2019-07-13 11:05:07 +02:00
Lennart Poettering 701f6af6b9 shutdown: use "int" for log level type 
Let's remove some unnecessary confusion around signed/unsigned types for
log levels. Let's just stick to signed, because that is what glibc
generally appears to use.

While we are at it, add explicit logging for all error causes.
 2019-07-13 11:05:07 +02:00
Lennart Poettering 60cd367649 killall: bump log message about unkilled processes to LOG_WARNING 
By raising this, we can raise the kernel kmsg log level safely, and
still see these messages.
 2019-07-13 11:05:07 +02:00
Lennart Poettering b65011dad0 alloc-util: drop _alloc_ decorator from memdup_suffix0() 
Fixes: https://github.com/systemd/systemd/pull/13034#issuecomment-510801671
 2019-07-13 11:04:20 +02:00
Lennart Poettering 2caa38e99f tree-wide: some more [static] related fixes 
let's add [static] where it was missing so far

Drop [static] on parameters that can be NULL.

Add an assert() around parameters that have [static] and can't be NULL
hence.

Add some "const" where it was forgotten.
 2019-07-12 16:40:10 +02:00
Lennart Poettering 6fb0569065 util-lib: [static] array argument sizes are apparently not OK for NULL parameters 
Let's drop the 'static' logic when a parameter can be NULL.

I think asan/ubsan are right here, judging by the C99 spec language:

"A declaration of a parameter as ‘‘array of type’’ shall be adjusted to
‘‘qualified pointer to type’’, where the type qualifiers (if any) are
those specified within the [ and ] of the array type derivation. If the
keyword static also appears within the [ and ] of the array type
derivation, then for each call to the function, the value of the
corresponding actual argument shall provide access to the first element
of an array with at least as many elements as specified by the size
expression."

If we specify NULL, then we certainly don't pvode access to any valid
array.

Fixes: #13039
 2019-07-12 16:40:10 +02:00
Lennart Poettering 5978345750 Merge pull request #13034 from poettering/memdup-suffix0-multiply-fixo 
memdup_suffix0_multiply fix
 2019-07-12 14:11:31 +02:00
Lennart Poettering bf21be1050 util-lib: fix comment 
As suggested by @ralt.

Fixes: #12896
 2019-07-12 09:37:49 +02:00
Lennart Poettering 2dc66a6417 test: modernize test-alloc-util.c test a bit 2019-07-12 09:11:44 +02:00
Lennart Poettering 7d025debfa alloc-util: drop _alloc_(2, 3) decorator from memdup_suffix0_multiply() 
This decorator tells compilers that the memory we return is shorter than
it actually is, thus triggering misleading bad memory access complaints.

Fixes: #13026
 2019-07-12 09:11:40 +02:00
Lennart Poettering 27dd6e1b12 Merge pull request #13022 from keszybz/coverity-cleanups 
Coverity cleanups
 2019-07-12 07:37:44 +02:00
Yu Watanabe a04285c6b1 Merge pull request #13031 from yuwata/network-route-type-local-12975-2 
network: make Route.Type= support local or friends
 2019-07-12 14:31:50 +09:00
Lennart Poettering b910cc72c0 tree-wide: get rid of strappend() 
It's a special case of strjoin(), so no need to keep both. In particular
as typing strjoin() is even shoert than strappend().
 2019-07-12 14:31:12 +09:00
Yu Watanabe d3e291fd62 network: also show route protocol in debugging logs 2019-07-12 09:39:43 +09:00
Yu Watanabe 1b64651bd1 network: use string table for route protocol 2019-07-12 09:39:43 +09:00
Yu Watanabe 41b90a1eb5 network: use string table to parse route table or scope 2019-07-12 09:39:43 +09:00
Yu Watanabe b297e0a7b0 network: show route scope, table, and type in debugging logs 2019-07-12 09:39:43 +09:00
Yu Watanabe 39f26098c9 network: update log message 
Follow-up for 7f474ed78d and
44e891bbf6.
 2019-07-12 09:39:43 +09:00
Yu Watanabe 94d6e29963 network: make Route.Type= support local, broadcast, anycast, multicast, nat, and xresolve 
Closes #12975.
 2019-07-12 09:39:43 +09:00
Yu Watanabe 7a22312d68 network: use string table to parse route type 2019-07-12 09:39:43 +09:00
Yu Watanabe 6fa0524133 Merge pull request #12971 from yuwata/network-reassign-static-routes 
network: reassign static routes and process reply address messages
 2019-07-12 09:36:16 +09:00
Zbigniew Jędrzejewski-Szmek 8e9d1eece6 shared/ask-password-api: backspace all chars at once 
We'd call loop_write() separately for each char. Let's be nice to
serial console users, and write the full string in one go.

Coverity was complaining that we're not checking the return value
from loop_write(). Rework the code a bit and add voidify.
CID#1402323.
 2019-07-12 00:35:05 +02:00
Zbigniew Jędrzejewski-Szmek b86a91e7ba test-process-util: invert reporting to make sure that we're not dividing by 0 
CID#1402334.
 2019-07-12 00:34:48 +02:00
Zbigniew Jędrzejewski-Szmek 0584b17a8c udevd: add helper with error handling to synthesize "change" events 
Coverity was unhappy that we ignore the return value from write_string_file().
We should at least warn. CID#1302373.
 2019-07-12 00:17:47 +02:00
Zbigniew Jędrzejewski-Szmek 2aa07538ba test: minor modernization 
Coverity was complaining that read() does not terminate the data. But
we did that termination earlier, so covirity is wrong (CID#1402306, CID#1402340).
Let's modernize the style a bit nevertheless.

(size_t) cast is needed to avoid the warning about comparison, iff
the value is not a constant.
 2019-07-12 00:17:45 +02:00
Lennart Poettering 66855de739 tree-wide: make use of errno_or_else() everywhere 2019-07-11 23:20:31 +02:00
Lennart Poettering fed813778f errno-util: add new errno_or_else() helper 2019-07-11 23:20:31 +02:00
Frantisek Sumsal 4747b645c6 Merge pull request #13025 from poettering/tmpfiles-fixo 
unbreak the build
 2019-07-11 19:55:55 +00:00
Lennart Poettering be9d8212a5 Merge pull request #13017 from yuwata/network-neighbor-lladdr-13015 
network: rename Neighbor.MACAddress= and also support IPv4 address
 2019-07-11 19:23:29 +02:00
Lennart Poettering a345cf448d tmpfiles: use path_join() where it makes sense 2019-07-11 18:42:26 +02:00
Lennart Poettering d34cd5711d tmpfiles: fix build 
After I merged #12750 we don't build anymore, since the merged PR (which
passed CI) uses prefix_root() which doesn't exist anymore. Let's fix
that.
 2019-07-11 18:41:14 +02:00
Lennart Poettering 6c75f78e94 Merge pull request #12750 from keszybz/tmpfiles-c-copy 
Make tmpfiles C use --root
 2019-07-11 18:13:19 +02:00
Yu Watanabe 7a555216df udevadm: ensure 'udevadm info -w' show updated result 
This seems not necessary, but just for safety.
 2019-07-11 17:39:36 +02:00
Lennart Poettering 2e8e1a1ab6 Merge pull request #12461 from Werkov/fix-job-ordering 
Refactor job ordering implementation (and fix cycle detection)
 2019-07-11 16:43:58 +02:00
Yu Watanabe 6545067aa9 network: re-assign static routes when dynamic address is updated 
Follow-up for b5799eeb07.

Closes #7354.
 2019-07-11 22:37:00 +09:00
Yu Watanabe 73854ba1a0 network: process address reply message 2019-07-11 22:37:00 +09:00
Yu Watanabe 7ed5420ab2 network: rework route_scope_from_address() 2019-07-11 22:37:00 +09:00
Yu Watanabe 9a897e22d4 util: introduce in4_addr_equal() 2019-07-11 22:37:00 +09:00
Yu Watanabe 661113a2a2 network: route_configure() do nothing when it returns 0 2019-07-11 22:37:00 +09:00
Yu Watanabe f5bab0d9c0 network: fdb: use ether_addr_from_string() 2019-07-11 22:22:29 +09:00