Daan De Meyer
b9b156ea3c
Merge pull request #23124 from yuwata/fixes-for-post-merge-review
...
Fixes for post merge review
2022-04-20 17:15:40 +02:00
Lennart Poettering
47a9f91760
update TODO
2022-04-20 15:45:10 +02:00
Lennart Poettering
8b82513375
update TODO
2022-04-20 14:49:53 +02:00
Luca Boccassi
7d40544643
Merge pull request #23126 from keszybz/clone3-prohibit
...
Prohibit clone3() when RestrictNamespaces is used
2022-04-20 11:27:58 +02:00
Luca Boccassi
da13d2ca07
compression: add separate pre-processor definitions
...
Follow-up for https://github.com/systemd/systemd/commit/cd3c6322dbc6370448bafc216ee4e19e32a79d9e
journal-def.h should be self-contained too, as it represents the journal object ABI.
Duplicate the enums, as they also need to be in config.h for it to be self-contained,
and enums are not available to the preprocessor. Use an assert to ensure they don't
diverge.
2022-04-19 23:18:19 +02:00
Zbigniew Jędrzejewski-Szmek
30193fe817
manager: prohibit clone3() in seccomp filters
...
RestrictNamespaces should block clone3() like flatpak:
https://github.com/flatpak/flatpak/commit/a10f52a7565c549612c92b8e736a6698a53db330
clone3() passes arguments in a structure referenced by a pointer, so we can't
filter on the flags as with clone(). Let's disallow the whole function call.
2022-04-19 22:04:31 +02:00
Luca Boccassi
3603f15171
nspawn: fix --ephemeral with --machine
...
Follow-up for https://github.com/systemd/systemd/commit/2362fdde1bd4bf54772383ef29431f683729ba76
When --machine is specified with --ephemeral, no random suffix is added, so
the recently added assert would fail.
Add a top-level variable with the expected file name for nspawn files, and
compute it when the rest of the names are computed.
2022-04-20 02:33:01 +09:00
w30023233
01d9fbccdd
virt: detect OpenStack Nova instance
2022-04-20 02:32:33 +09:00
Yu Watanabe
5a560d4cc3
firewall-util: emphasize that nfnl_netlink_sendv() takes at least one message
...
Addresses https://github.com/systemd/systemd/pull/23090#discussion_r853002631 .
2022-04-20 02:28:54 +09:00
Yu Watanabe
2a86ed67ed
efi-api: use string_replace_char()
2022-04-20 02:23:11 +09:00
Yu Watanabe
9dbfcaf229
sd-device: use string_replace_char() and strspn_from_end()
2022-04-20 02:19:44 +09:00
Yu Watanabe
146f4482b2
string-util: introduce strspn_from_end()
2022-04-20 02:15:01 +09:00
Yu Watanabe
072f5f9b18
string-util: introduce string_replace_char()
2022-04-20 02:14:35 +09:00
Yu Watanabe
e4e1353c25
sd-device: refuse O_DIRECTORY returned from path_extract_filename()
...
In both cases, it is expected that the symlink targets do not end with '/'.
Addresses https://github.com/systemd/systemd/pull/23089#discussion_r853007218 .
2022-04-20 01:43:27 +09:00
Yu Watanabe
bb60956b39
path-util: make readlink_value() refuse O_DIRECTORY returned from path_extract_filename()
...
The function is now only used by sd-device.c and pam_systemd.c, and they
expects the result are not directory. Hence, it is safe to change the
behavior.
Addresses https://github.com/systemd/systemd/pull/23089#discussion_r853006017 .
2022-04-20 01:40:39 +09:00
Sonali Srivastava
c52950c292
hostnamed: display firmware version
2022-04-19 13:54:16 +02:00
Lennart Poettering
e4b5226d63
update TODO
2022-04-19 12:44:45 +02:00
Zbigniew Jędrzejewski-Szmek
c5503601e2
shared/seccomp: add note about clone2() being unimportant
...
In case anyone else starts wondering whether it should be listed
as I did…
2022-04-19 11:56:23 +02:00
Hans de Goede
5e3b8aeef3
hwdb: 60-keyboard: Add Acer Aspire One AO532h keymappings
...
Add keymappings for the Acer Aspire One AO532h netbook.
Unmap the brightnesskeys because they send duplicate key events with
the ACPI video bus key events and add a mapping for the bluetooth
on/off hotkey.
2022-04-19 06:17:35 +09:00
Luca Boccassi
2362fdde1b
nspawn: fix locating config files with --ephemeral
...
When --ephemeral is used, a random 16 characters suffix is added to the image
name, so matching on .nspawn files based on the image name no longer works.
Fixes https://github.com/systemd/systemd/issues/13297
2022-04-19 06:17:16 +09:00
davijosw
39cd62c30c
hwdb: Update 60-keyboard.hwdb ( #23074 )
...
Fix Fn+F1 (toggle touchpad) that wasn't working.
Closes #23058
2022-04-18 20:51:45 +09:00
Yu Watanabe
b0c3d2b76b
Merge pull request #23107 from yuwata/man-network-numeric-prefix
...
man: recommend that .network or friends should have a numeric prefix
2022-04-18 07:02:10 +09:00
Yu Watanabe
915774ecb8
Merge pull request #23101 from yuwata/sd-device-cleanups
...
sd-device: several cleanups
2022-04-18 07:01:42 +09:00
Yu Watanabe
98e5a6c93c
resolve: fix typo in dns_class_is_pseudo()
2022-04-18 07:01:17 +09:00
Luca Boccassi
cd3c6322db
compression: add build-time option to select default
...
Compression and decompression are controlled by the same build flag,
so if one wants to use, say, LZ4 to compress, ZSTD has to be disabled,
which means one loses the ability to read zstd-compressed journals.
Add a default-compression meson option, that allows to select any of
the available compression algorithms as the default.
2022-04-18 05:43:59 +09:00
Yu Watanabe
23d20adc05
sd-device: rename arguments and variables
2022-04-18 04:34:14 +09:00
Yu Watanabe
9c5d7151c1
sd-device: fix possible use-of-uninitialized-value
2022-04-18 04:34:14 +09:00
Yu Watanabe
17761fb3bf
sd-device: use ERRNO_IS_DEVICE_ABSENT() at one more place
2022-04-18 04:34:14 +09:00
Yu Watanabe
d82827a107
sd-device: rename function arguments for storing results
2022-04-18 04:34:14 +09:00
Yu Watanabe
c77c1cc201
sd-device: use correct type and parser for device node uid and gid
2022-04-18 04:34:14 +09:00
Yu Watanabe
d37c69c1bf
sd-device: shorten code a bit
2022-04-18 04:34:14 +09:00
Yu Watanabe
ce1d08ba94
sd-device: use path_extract_filename() at one more place
...
This also does several cleanups.
2022-04-18 04:34:14 +09:00
Yu Watanabe
60e50fb20d
sd-device: reset sysname and sysnum on renaming
2022-04-18 04:34:14 +09:00
Yu Watanabe
f5a75f2027
sd-device: reduce indentation
2022-04-18 04:34:14 +09:00
Yu Watanabe
ff58f2ae2a
sd-device: verify new syspath on renaming
2022-04-18 04:34:14 +09:00
Yu Watanabe
625d71b9ae
man: DHCPPrefixDelegation= needs to be enabled on downstream side for assigning delegated prefixes
...
Closes #23041 .
2022-04-18 04:30:56 +09:00
Yu Watanabe
cc9b6bdc96
man: recommend that .network or friends should have a numeric prefix
...
Closes #23105 .
2022-04-18 04:30:49 +09:00
Yu Watanabe
bd4297e761
udevadm: info: also show parent devices by --tree
2022-04-17 21:27:33 +02:00
Luca Boccassi
ee5b175b8c
Merge pull request #23100 from yuwata/network-fix-tunnel-address-parser
...
network: fix tunnel address parser
2022-04-17 21:24:38 +02:00
Mike Gilbert
bf93f24ad8
Add test support for systemd-tmpfiles.standalone
2022-04-18 01:27:09 +09:00
Yu Watanabe
fe619e998a
Merge pull request #23093 from mrc0mmand/test-md-partitions
...
test: more MD coverage improvements
2022-04-18 01:26:30 +09:00
Frantisek Sumsal
18161cf0ca
test: partition the MD device
...
Also, loop the assemble/disassemble part couple of times to test udev
even harder.
Resolves : #23092
2022-04-17 21:53:12 +09:00
Frantisek Sumsal
6d49e0945f
test: cleanup after the MD + LVM test case as well
2022-04-17 16:14:30 +09:00
amarjargal
354ca98085
systemctl: colorize "enabled" in 'systemctl status ...'
...
"enabled" state is highlighted in green and "disabled" state is
highlighted in yellow because I felt that white and grey colors were not
so distinguishable. Other states are not highlighted. Any other coloring
suggestions are welcome!
Closes #16932 .
2022-04-17 14:30:46 +09:00
Yu Watanabe
5984b92726
network: l2tp: refuse null address
2022-04-17 09:31:35 +09:00
Yu Watanabe
96d96ec4e7
network: tunnel: handle null address as "any"
...
Fixes oss-fuzz#44881 (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44881 ).
Fixes #23098 .
2022-04-17 09:31:30 +09:00
Frantisek Sumsal
50d312039e
Revert "lgtm: disable cpp/missing-return (again)"
...
This reverts commit 000096f4c6 .
After a couple of manual tests LGTM finally appears to have the fix for
https://github.com/github/codeql/issues/8409 , so let's reenable the
check for the last time.
2022-04-16 10:59:29 +00:00
Yu Watanabe
747bee2662
Merge pull request #23089 from yuwata/sd-device-use-path_extract_filename
...
sd-device: use path_extract_filename()
2022-04-16 14:33:58 +09:00
Yu Watanabe
7be87278a3
Merge pull request #23021 from fbuihuu/tmpfiles-fix-precedence-with-plus-sign
...
Tmpfiles fix precedence with plus sign
2022-04-16 01:36:51 +09:00
Zbigniew Jędrzejewski-Szmek
6e961aeb26
shared/install: fix crash when reenable is called without --root
2022-04-15 18:26:07 +02:00