Commit Graph
100 Commits
Author SHA1 Message Date
Yu Watanabe bd4297e761 udevadm: info: also show parent devices by --tree 2022-04-17 21:27:33 +02:00
Yu Watanabe fe619e998a Merge pull request #23093 from mrc0mmand/test-md-partitions
test: more MD coverage improvements
2022-04-18 01:26:30 +09:00
Yu Watanabe 5984b92726 network: l2tp: refuse null address 2022-04-17 09:31:35 +09:00
Yu Watanabe 96d96ec4e7 network: tunnel: handle null address as "any"
Fixes oss-fuzz#44881 (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44881).

Fixes #23098.
2022-04-17 09:31:30 +09:00
Yu Watanabe 747bee2662 Merge pull request #23089 from yuwata/sd-device-use-path_extract_filename
sd-device: use path_extract_filename()
2022-04-16 14:33:58 +09:00
Yu Watanabe 7be87278a3 Merge pull request #23021 from fbuihuu/tmpfiles-fix-precedence-with-plus-sign
Tmpfiles fix precedence with plus sign
2022-04-16 01:36:51 +09:00
Yu Watanabe b9d8209065 test: add tests for sd_device_get_sysnum() 2022-04-16 00:52:24 +09:00
Yu Watanabe 5fa9d220c2 sd-device: shorten code a bit 2022-04-16 00:52:24 +09:00
Yu Watanabe c58e0ce677 sd-device: use path_extract_filename() at one more place 2022-04-16 00:52:16 +09:00
Yu Watanabe ce8394f9c7 fs-util: use path_extract_filename() at one more place 2022-04-16 00:50:01 +09:00
Yu Watanabe 3e02a6a33e Merge pull request #23090 from yuwata/firewall-util-cleanups
firewall-util: cleanups
2022-04-15 20:11:58 +09:00
Yu Watanabe 012f32d808 firewall-util: inline iterator and add several missing assertions 2022-04-15 17:44:51 +09:00
Yu Watanabe cc41c084cd sd-netlink: use correct type of iterator 2022-04-15 17:37:52 +09:00
Yu Watanabe c905eb45de Merge pull request #23081 from mrc0mmand/more-md-tests
test: extend the MD coverage with more RAID levels and LVM
2022-04-15 14:30:55 +09:00
Yu Watanabe bac8fe924e Merge pull request #23073 from medhefgo/boot-fixes
boot: Some fixes
2022-04-14 16:58:21 +09:00
Yu Watanabe bd1f75d5fb Merge pull request #23070 from poettering/devnum-split
basic: some devnum handling tweaks and refactorings
2022-04-14 03:45:39 +09:00
Yu Watanabe f4e357d77f Merge pull request #22969 from poettering/udevadm-tree
udevadm: add new "udevadm info --tree" command
2022-04-14 03:45:14 +09:00
Yu Watanabe 9a78ee002f udev: set ID_IGNORE_DISKSEQ for md devices 2022-04-14 00:12:02 +09:00
Yu Watanabe 0224c31ea3 udev: do not create disk/by-diskseq symlink when ID_IGNORE_DISKSEQ property is set 2022-04-14 00:11:57 +09:00
Yu Watanabe 03b894fc09 sd-device: skip diskseq verification when ID_IGNORE_DISKSEQ property is set
Some drivers do not announce the diskseq change.
E.g. for md devices, the kernel increments the diskseq *after*
emitting a 'change' uevent when backing block devices are added to
a md device, and udevd does not receive no uevent which contains
the new diskseq.
2022-04-14 00:10:28 +09:00
Yu Watanabe 17d97d4c90 udev: create disk/by-diskseq symlink only when the device has diskseq
Follow-up for 0d08db7f89.
2022-04-13 23:09:47 +09:00
Yu Watanabe 5180394b38 core: use assert_se() which takes side-effect
Fixes #23059.
2022-04-12 18:45:20 +02:00
Yu Watanabe 82e0b63183 udev: use child event source to manage workers 2022-04-13 01:08:42 +09:00
Yu Watanabe a79cba3326 udev: use EventResult type
This also adds EVENT_RESULT_SUCCESS for readability.
2022-04-13 01:00:08 +09:00
Yu Watanabe fbae50904f sd-event: make inotify event work after the process is forked 2022-04-13 01:00:08 +09:00
Yu Watanabe 86587c93b0 sd-event: do not kill a child process from another child 2022-04-13 01:00:08 +09:00
Yu Watanabe 01e6af7374 sd-event: do not update signal fd after PID is changed
Otherwise, child event source will not work after the process is forked
and the event source is unref()ed on the child process.
2022-04-13 01:00:08 +09:00
Yu Watanabe 54988a27b9 sd-event: set pid to event source after all setup processes finished
Otherwise, the assertion in source_disconnect() may be triggered,
2022-04-13 01:00:08 +09:00
Yu Watanabe 91c700713f sd-event: rebreak comments 2022-04-13 01:00:08 +09:00
Yu Watanabe d89e18cc38 Merge pull request #23057 from keszybz/various-doc-tweaks
Various doc tweaks
2022-04-12 23:09:51 +09:00
Yu Watanabe e2185ffef8 Merge pull request #23051 from poettering/udev-tweaklets-2
udev: three minor tweaks
2022-04-12 14:06:53 +09:00
Yu Watanabe 68fe012fdf Merge pull request #23048 from keszybz/Add-more-tests-for-specifiers
Add more tests for specifiers
2022-04-12 14:04:48 +09:00
Yu Watanabe 29d902f03a Merge pull request #22992 from poettering/loop-dissect-tweaks
loop-util/image dissect fixes
2022-04-11 23:08:46 +09:00
Yu Watanabe cdecc9a56f Merge pull request #23037 from yuwata/sd-device-validate
sd-device: validate input parameter after creating sd-device object
2022-04-11 23:04:28 +09:00
Yu Watanabe 23ebdf4f86 udev: inline loop variable 2022-04-11 19:59:04 +09:00
Yu Watanabe 262953ac77 udev: suppress multiple log message about interface naming scheme from workers 2022-04-11 19:59:04 +09:00
Yu Watanabe d806fff1dd udev/net: cache parsed result of net.ifnames=
To make the log message shown only once.
2022-04-11 19:58:54 +09:00
Yu Watanabe 08405125c3 sd-device: shorten code a bit 2022-04-11 19:56:38 +09:00
Yu Watanabe 9a81972b3b sd-device: minor may be NULL 2022-04-11 19:56:38 +09:00
Yu Watanabe a46f9cd049 sd-device: validate input parameter after creating sd-device object 2022-04-11 19:56:03 +09:00
Yu Watanabe 513631a757 fix typo 2022-04-11 02:30:29 +09:00
Yu Watanabe 3a258d3a47 fix typo 2022-04-11 00:13:16 +09:00
Yu Watanabe 1a037ba238 repart: use sd_device_open()
Then, we can safely open devices even if symlinks are not yet created by udevd.
2022-04-10 23:05:10 +09:00
Yu Watanabe 928c6c00c3 test: always invoke systemd-repart with --no-pager
Follow-up for 31cf58864d.
2022-04-09 13:44:10 +01:00
Yu Watanabe 249e01b215 udev: add parens for function names in the logs 2022-04-09 13:41:06 +01:00
Yu Watanabe 7108fd6ad5 Merge pull request #22614 from zonque/timesync/runtime
timesyncd: add runtime servers
2022-04-09 13:27:05 +09:00
Yu Watanabe 15ac2a62f2 network: ignore errors when CONFIG_NET_SCHED is disabled
Follow-ups for 828a81a937.

Fixes #23014.
2022-04-08 11:13:42 +01:00
Yu Watanabe 239adf0384 sd-ipv4acd: actually drop the arp packet from one of the host interface
Fixes a bug in 7f77917c0e.

Fixes #23001.
2022-04-07 15:02:21 +09:00
Yu Watanabe 70a3ce51f3 test: drop unnecessary use of loop device
To avoid inferences with udevd.
2022-04-07 01:44:39 +09:00
Yu Watanabe bc6bd62c0e test: use udevadm lock when partitioning block devices
We can use `sfdisk --lock` for these cases, but some CI environments
have old sfdisk which does not support `--lock` option.
2022-04-07 01:42:44 +09:00
Yu Watanabe 3452ae90ea test: --initialized=yes is the default for udevadm wait 2022-04-07 00:40:33 +09:00
Yu Watanabe 76b53bf54b Merge pull request #22993 from keszybz/refactor-manager_taint_string()
Refactor manager_taint_string()
2022-04-07 00:36:45 +09:00
Yu Watanabe 2f88f2936c README: rawhide -> Rawhide 2022-04-06 23:14:21 +09:00
Yu WatanabeandFrantisek Sumsal 588453b8b4 README: add rawhide SELinux build status (#22997)
Co-authored-by: Frantisek Sumsal <frantisek@sumsal.cz>
2022-04-06 14:13:10 +00:00
Yu Watanabe 2eeabd4489 Merge pull request #22983 from yuwata/login-use-symlinks-under-static_node-tags
login: shorten code a bit
2022-04-06 23:11:56 +09:00
Yu Watanabe a9e832092a udev: add a brief comment about the origin of the filters
I am not sure whether the original discussions are correct or not.
This is just for adding references for future verification for the
filters.
2022-04-06 15:28:44 +02:00
Yu Watanabe e992fd18a8 login: shorten code a bit
The symlinks under /run/udev/static_node-tags are pointing to the
corresponding device nodes. Let's read the symlinks.
2022-04-06 19:38:27 +09:00
Yu Watanabe 8dc3c2f197 Merge pull request #22981 from yuwata/udev-node-cleanups
udev: cleanups for device node handling
2022-04-06 19:34:59 +09:00
Yu Watanabe f7ad162879 test-network: rename one .netdev to make the file removed after the test
Follow-up for 7809cab717.
2022-04-06 18:14:45 +09:00
Yu Watanabe 190ed66edc udevadm: lock: fix TOCTOU
Fixes CID#1487744.
2022-04-06 08:58:23 +01:00
Yu Watanabe 26dd37f6d5 udev: move apply_static_dev_perms() to udev-node.c
and make it internally use udev_node_apply_permissions_impl().
2022-04-06 14:52:36 +09:00
Yu Watanabe e5ddfe3ec5 udev: upgrade mode in udev_node_apply_permissions_impl() 2022-04-06 14:46:13 +09:00
Yu Watanabe a782f2a3fc udev: split udev_node_apply_permissions() into two 2022-04-06 14:46:13 +09:00
Yu Watanabe f14aa5ad42 udev: drop unnecessary code
Follow-up for 78e278ad48.
2022-04-06 14:46:13 +09:00
Yu Watanabe bab34bc12e Merge pull request #22980 from keszybz/test-help-and-version-output
Test --help and --version output in more cases
2022-04-06 13:42:12 +09:00
Yu Watanabe 5674b74c4f hwdb: fix parsing options
Fixes #22976.
2022-04-06 04:03:32 +09:00
Yu Watanabe 58dd4999dc core: command argument can be longer than PATH_MAX
Fixes a bug introduced by 0653649202.

Fixes #22957.
2022-04-06 00:39:06 +09:00
Yu Watanabe c7749367e3 test-sd-device: ignore several errors when running on non-host network namespace
Fixes https://github.com/systemd/systemd/commit/93e04eb43bed6cd1cea344f8fb1002b62155fae2#commitcomment-70387367.
2022-04-05 14:33:19 +09:00
Yu Watanabe b1d723228e test-sd-device: allow several devices removed during running test
To make the test stabler.
2022-04-05 14:29:52 +09:00
Yu Watanabe 901fa9a4c9 test-sd-device: device ID requires subsystem 2022-04-05 14:29:49 +09:00
Yu Watanabe 04d1fbd564 test-sd-device: log earlier which device is handled
To make debugging the test easier.
2022-04-05 14:29:41 +09:00
Yu Watanabe 20742f92c1 Merge pull request #22951 from keszybz/fix-entry-selection-bootctl-status
Fix entry selection in bootctl status
2022-04-05 13:42:43 +09:00
Yu Watanabe 2df5a7d3f1 Merge pull request #22964 from yuwata/udevadm-lock-follow-ups
udevadm lock follow ups
2022-04-05 13:13:06 +09:00
Yu Watanabe 14f9c81fb4 test: use udevadm wait and lock
Hopefully fixes #22911.
2022-04-05 05:00:39 +09:00
Yu Watanabe d90dbba7ec shell-completion: update for udevadm 2022-04-05 04:36:20 +09:00
Yu Watanabe e7e25c21c6 fix typo 2022-04-05 04:36:20 +09:00
Yu Watanabe f379362157 Merge pull request #22963 from poettering/udevadm-diskseq-fix
sd-device diskseq fix + udevadm info improvements
2022-04-05 03:57:24 +09:00
Yu Watanabe cf708d803e Merge pull request #22867 from poettering/lockdev-util
add small "udevadm lock" tool for locking a block device
2022-04-05 03:04:23 +09:00
Yu Watanabe 5672bdd341 udev/net: always log error in link_load_one() 2022-04-05 02:03:22 +09:00
Yu Watanabe 61ec7beaf5 network: always log error in network_load_one() and netdev_load_one() 2022-04-05 02:02:42 +09:00
Yu Watanabe 036a8d503f network: ignore all errors in loading .network files
This partially reverts 9202b567bc.

Fixes #22954.
2022-04-05 01:57:07 +09:00
Yu Watanabe f3e5c781f3 Merge pull request #22943 from yuwata/dhcp6-client-requet-options
sd-dhcp6-client: requet options
2022-04-04 22:55:02 +09:00
Yu Watanabe d315b47e2d Merge pull request #22952 from poettering/rework-kvm-hyperv
virt: tweak kvm with hyperv enlightenments
2022-04-04 22:53:56 +09:00
Yu Watanabe 822883b3e7 sd-dhcp6-client: request several options
Even though these options are not currently used by sd-dhcp6-client,
RFC 8415 states these options MUST be requested.
2022-04-04 01:22:02 +09:00
Yu Watanabe 612caa2626 network: dhcp6: request DNS servers or friends only when they will be used 2022-04-03 19:55:25 +09:00
Yu Watanabe f697ab358a dhcp: make option names singular 2022-04-03 19:50:02 +09:00
Yu Watanabe 0e0c4daea6 sd-dhcp6-client: sort requesting options 2022-04-03 19:23:03 +09:00
Yu Watanabe 2f53b311c3 sd-dhcp6-client: rename req_opts_len -> n_req_opts
As 'len' is confusing and we may misunderstand it as the size of
the buffer instead of the number of options.
2022-04-03 19:23:03 +09:00
Yu Watanabe 95cd21928f Merge pull request #22939 from yuwata/tree-wide-space
tree-wide: add space after if, switch, for, and while
2022-04-02 01:32:26 +09:00
Yu Watanabe b17a681be5 tree-wide: fix typo 2022-04-02 00:34:39 +09:00
Yu Watanabe 37ebfe49de Merge pull request #22926 from bluca/analyze_offline_filter
analyze: fix offline checks for syscall filter and 'native' architecture
2022-04-01 23:43:18 +09:00
Yu Watanabe 798931160e tree-wide: add a space after if, switch, for, and while 2022-04-01 22:48:42 +09:00
Yu Watanabe 72dce85a60 test: add space between arguments 2022-04-01 22:28:13 +09:00
Yu Watanabe b8529cf376 Merge pull request #22872 from yuwata/udevadm-wait
udevadm: introduce 'wait' command
2022-04-01 18:41:03 +09:00
Yu Watanabe 78e278ad48 udev: use sd_device_open() where appropriate 2022-04-01 15:21:05 +09:00
Yu Watanabe 9534d6c9ea test: add test for sd_device_open() 2022-04-01 15:20:48 +09:00
Yu Watanabe f9a726abef sd-device: introduce sd_device_open()
We usually open() device node obtained by sd_device_get_devname().
However, the device node corresponds to the sd-device object may be
already removed, and another device node with the same path may be
created, hence an unexpected device may be opened.

The sd_device_open() opens device node, and checks the devnum and
diskseq of opened devnum, to avoid the above possibility.

Prompted by https://github.com/systemd/systemd/issues/22906#issuecomment-1082736443.
2022-04-01 15:13:18 +09:00
Yu Watanabe 7e93a65868 fd-util: rename loop_get_diskseq() -> fd_get_diskseq()
And move it from loop-util.[ch] -> fd-util.[ch]
2022-04-01 15:13:18 +09:00
Yu Watanabe 2076612f84 basic/missing: move BLKGETDISKSEQ to missing_fs.h
As it is defined at linux/fs.h.
2022-04-01 15:13:18 +09:00
Yu Watanabe e529abe24d test: replace helper_wait_for_dev() with 'udevadm wait' 2022-04-01 15:13:18 +09:00