Commit Graph
100 Commits
Author SHA1 Message Date
Yu Watanabe 983cbd91a8 udev: add missing short option name
Follow-up for 4fcc033b54.

Fixes CID#1442307.
2021-01-13 21:53:13 +01:00
Yu Watanabe 414cbc3c73 Merge pull request #9864 from ximion/master
localed: Run locale-gen if available to generate missing locale
2021-01-14 00:20:04 +09:00
Yu Watanabe cb2ae9f8b9 Merge pull request #18170 from OnkelUlla/udev_introduce_TxQueueLen=_setting
udev: introduce TxQueueLength= setting
2021-01-14 00:19:29 +09:00
Yu Watanabe fec1b650ad network: introduce ManageTemporaryAddress= setting in [DHCPv6PrefixDelegation] section
The setting is enabled by default, as NDisc also enabled the flag by
default.

Closes #18208.
2021-01-14 00:17:05 +09:00
Yu Watanabe 8b76ee89d7 network: drop a function argument which is always constant 2021-01-14 00:16:10 +09:00
Yu Watanabe 65ab27211c Merge pull request #18225 from poettering/tmpfiles-argument
tmpfiles: fix documentation about quoting the "argument" field in tmpfiles.d snippets
2021-01-13 15:57:42 +09:00
Yu Watanabe 537ae584c8 network: reconfigure interface when wifi iftype is updated
Follow-up for a66a402da4.

Fixes #18059.
2021-01-13 06:42:02 +09:00
Yu Watanabe 09db85080a Merge pull request #18216 from yuwata/dhcp-user-class-length
dhcp: length of each user class field must be positive
2021-01-13 05:43:10 +09:00
Yu Watanabe 048be097d2 Merge pull request #18157 from ssahani/vlan-qos
network: Allow to configure VLan egress qos maps
2021-01-13 05:42:53 +09:00
Yu Watanabe 7c5869530c Merge pull request #17628 from ssahani/network-gso
udev: Add support to configure Generic Segment Offload
2021-01-13 05:42:23 +09:00
Yu Watanabe df49792e01 timedate: actually reset system time with new timezone
Fix a bug introduced by 56b0ef2fc2.

Closes CID#1436943.
2021-01-13 00:59:33 +09:00
Yu Watanabe 885598f36c Merge pull request #18212 from yuwata/two-coverity-fixes
Two coverity fixes
2021-01-13 00:57:34 +09:00
Yu Watanabe 6fda02e150 network: merge config_parse_dhcp_user_class() and _vendor_class() 2021-01-13 00:07:48 +09:00
Yu Watanabe 019951ec97 dhcp6: refuse zero length vendor class
Also, fixes the maximum length of the vendor class to UINT16_MAX.
Moreover, a memory leak in sd_dhcp6_client_set_request_vendor_class().
2021-01-13 00:07:33 +09:00
Yu Watanabe 361eb4125d dhcp6: add an assert() 2021-01-13 00:00:56 +09:00
Yu Watanabe 8b6ea477a7 dhcp: do not assign value twice 2021-01-13 00:00:56 +09:00
Yu Watanabe 5a99444e4f dhcp6: refuse zero length dhcp user class
This also fixes a memory leak when
sd_dhcp6_client_set_request_user_class() is called multiple times.
2021-01-13 00:00:56 +09:00
Yu Watanabe b79951fa32 network: refuse zero length dhcp user class 2021-01-13 00:00:56 +09:00
Yu Watanabe e4336c0a5d dhcp: length of each user class field must be positive
This also fixes an memory leak when sd_dhcp_client_set_user_class()
is called multiple times.
2021-01-13 00:00:56 +09:00
Yu Watanabe 7c08f24a50 Merge pull request #18217 from ssahani/todo-network
TODO: Already implemented with SendDecline=
2021-01-12 22:53:44 +09:00
Yu Watanabe 8f13ef254b sd-bus: fix memleak
Closes CID#1437780.
2021-01-12 20:46:47 +09:00
Yu Watanabe ecb3e9fba3 boot: at least one of os_name_pretty or os_name exists in this block
Closes CID#1438933.
2021-01-12 20:43:06 +09:00
Yu Watanabe 0375cb546f Merge pull request #18209 from poettering/virt-fix
three minor fixes to virt.c
2021-01-12 14:24:37 +09:00
Yu Watanabe 1536b7b2d0 network: introduce new UseAddress= setting in [DHCPv6] section
If it is disabled, then the addresses provided by the DHCPv6 server will
be ignored.

Closes #18203.
2021-01-12 14:19:03 +09:00
Yu Watanabe e2645ca619 Merge pull request #18204 from yuwata/wifi-util-fix-18059
wifi-util: do not ignore wifi iftype when the interface does not have SSID
2021-01-12 14:18:24 +09:00
Yu Watanabe a66a402da4 wifi-util: do not ignore wifi iftype when SSID is not set
Previously, if an interface does not have SSID, e.g. run in mesh-point
type, then the wifi iftype obtained by the netlink call was ignored.

Fixes #18059.
2021-01-12 01:12:37 +09:00
Yu Watanabe a533007815 wifi-util: cleanup header inclusion 2021-01-12 01:11:50 +09:00
Yu Watanabe 2e385c48b4 linux: move nl80211.h to basic/linux
As sd-netlink uses the header.
2021-01-11 13:31:38 +09:00
Yu Watanabe 59538b6418 udev: drop doubled blank line 2021-01-11 13:29:39 +09:00
Yu Watanabe 2224669546 Merge pull request #18178 from weblate/weblate-systemd-master
Translations update from Weblate
2021-01-10 20:41:46 +09:00
Yu Watanabe 83f0ff1eda Merge pull request #18137 from keszybz/deprecate-blanket-import-environment
Deprecate blanket import-environment
2021-01-09 09:24:16 +09:00
Yu Watanabe 66bf4617b1 Merge pull request #18169 from OnkelUlla/can_bus_error_reporting
network: can: add support for bus error reporting
2021-01-09 09:21:54 +09:00
Yu Watanabe 608ac76367 Merge pull request #18168 from yuwata/network-cleanups
network: several follow-ups for recently merged PRs
2021-01-09 09:21:19 +09:00
Yu Watanabe 0c2c0fd256 resolve: fix use after free in DnsAnswer
This fixes a bug introduced by ae45e1a383.

The set DnsAnswer::set_items contains the reference to the array in
DnsAnswer. So, the set must be reconstructed when we realloc() the
object.

Fixes #18132.
2021-01-08 19:06:00 +01:00
Yu Watanabe f7d0ea5b6f network: refuse to set 0 for rx or tx queue
Man page says that the valid value is 1-4096.
2021-01-09 00:05:45 +09:00
Yu Watanabe 0b5dc24953 test-network: add tests for route advmss 2021-01-09 00:01:53 +09:00
Yu Watanabe 386e89083f network: read RTAX_ADVMSS in received route message 2021-01-08 23:56:13 +09:00
Yu Watanabe 78ebbf0286 network: add missing TAKE_PTR() 2021-01-08 23:25:20 +09:00
Yu Watanabe a084b38789 udev/cdrom: split main() into main() and run()
However, we do not use DEFINE_MAIN_FUNCTION() here, as ubuntu s390x CI
does not like it...
2021-01-08 14:08:38 +00:00
Yu Watanabe 2131110553 udev/cdrom: drop unnecessary headers 2021-01-08 14:08:38 +00:00
Yu Watanabe 2af5ad50d1 udev/cdrom: drop never hit condition 2021-01-08 14:08:38 +00:00
Yu Watanabe 0dd6189f8c udev/cdrom: void()ify several function calls 2021-01-08 14:08:38 +00:00
Yu Watanabe 80cb2a69ec udev/cdrom: tighten variable scope used in loop 2021-01-08 14:08:38 +00:00
Yu Watanabe 67e5bc0be9 udev/cdrom: use unaligned_read_be32() or friends 2021-01-08 14:08:38 +00:00
Yu Watanabe 866725e8aa udev/cdrom: split cd_media_info() into small pieces 2021-01-08 14:08:38 +00:00
Yu Watanabe 530a715ea9 udev/cdrom: introduce enum for media state 2021-01-08 14:08:38 +00:00
Yu Watanabe 97b2248475 udev/cdrom: move media status to Context 2021-01-08 14:08:38 +00:00
Yu Watanabe 38f3e20883 udev/cdrom: introduce enum for media and drive feature 2021-01-08 14:08:38 +00:00
Yu Watanabe e5aac5cdf1 udev/cdrom: introduce Context 2021-01-08 14:08:38 +00:00
Yu Watanabe 0f0b079135 udev/cdrom: make cd_profiles() return positive value if drive has media 2021-01-08 14:08:38 +00:00
Yu Watanabe 138dd9545a udev/cdrom: make media_lock() return negative errno 2021-01-08 14:08:38 +00:00
Yu Watanabe 4fe9ab406e udev/cdrom: introduce scsi_cmd_run_and_log() 2021-01-08 14:08:38 +00:00
Yu Watanabe 511ff06e99 udev/cdrom: use random_u64() and usleep() 2021-01-08 14:08:38 +00:00
Yu Watanabe 56c1a2977b udev/cdrom: split out parse_argv() and help() 2021-01-08 14:08:38 +00:00
Yu Watanabe 2797d945d2 Merge pull request #18105 from yuwata/fuzz-fix-timeout
Fuzz fix timeout
2020-12-30 12:11:23 +09:00
Yu Watanabe ae45e1a383 resolve: slightly optimize dns_answer_add()
Previously, dns_answer_add() was O(n^2).
With this change dns_packet_extract() becomes ~15 times faster for some
extremal case.

Before:
```
$ time ./fuzz-dns-packet ~/downloads/clusterfuzz-testcase-minimized-fuzz-dns-packet-5631106733047808
/home/watanabe/downloads/clusterfuzz-testcase-minimized-fuzz-dns-packet-5631106733047808... ok

real    0m15.453s
user    0m15.430s
sys     0m0.007s
```

After:
```
$ time ./fuzz-dns-packet ~/downloads/clusterfuzz-testcase-minimized-fuzz-dns-packet-5631106733047808
/home/watanabe/downloads/clusterfuzz-testcase-minimized-fuzz-dns-packet-5631106733047808... ok

real    0m0.831s
user    0m0.824s
sys     0m0.006s
```

Hopefully fixes oss-fuzz#19227.
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19227
2020-12-30 04:14:22 +09:00
Yu Watanabe b652cccab9 resolve: field size in dns resource record may be zero 2020-12-30 04:14:22 +09:00
Yu Watanabe 0b71a7e01d siphash: introduce siphash24_compress_safe() 2020-12-30 04:14:18 +09:00
Yu Watanabe 49ff3f34d5 test-network: add tests for fib rules with Family=both vs networkctl reload or reconfigure 2020-12-30 03:32:07 +09:00
Yu Watanabe a75466ed19 network: drop fib rules configured with Family=both 2020-12-30 03:19:07 +09:00
Yu Watanabe 49de8d5ced network: set RoutingPolicyRule::family based on Family= setting 2020-12-30 03:19:07 +09:00
Yu Watanabe c1934a8f2f network: always re-configure rules even if already exist
routing_policy_rule_get() in link_set_routing_policy_rules() does not
work when [RoutingPolicyRule] section does not have From= or To=.
2020-12-30 03:19:03 +09:00
Yu Watanabe 57fe5a42f0 network: drop unnecessary checks
By the previous commit, the checks are not necessary any more.
2020-12-30 03:17:42 +09:00
Yu Watanabe fdce9324c7 network: fix possible memory leak
When set_put() returns 0, then already stored rule will be unref()ed
from Manager.
2020-12-30 02:11:36 +09:00
Yu Watanabe 3141c81736 network: constify several arguments 2020-12-30 02:03:48 +09:00
Yu Watanabe cd70fc373d resolve: do not compare key twice 2020-12-30 01:22:59 +09:00
Yu Watanabe 600864921b resolve: slightly shorten dns_resource_key_compare_func() 2020-12-30 01:22:59 +09:00
Yu Watanabe e9665ac2a2 resolve: fix typo 2020-12-30 01:22:56 +09:00
Yu Watanabe 57dda0de38 fuzzers: set maximum length for several fuzzers
Hopefully fixes oss-fuzz#19081, oss-fuzz#21731, oss-fuzz#21755.
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=19081
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21731
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=21755
2020-12-30 00:31:17 +09:00
Yu Watanabe 2be7c6ab3b Merge pull request #17477 from yuwata/network-drop-serialization-routing-policy-rule
network: do not serialize/deserialize routing policy rules
2020-12-30 00:18:24 +09:00
Yu Watanabe a9d240f4bf network: do not serialize/deserialize routing policy rules
We already handle foreign routing policy rules correctly by the previous
commit. So, the serialization/deserialization of rules are not necessary
anymore.
2020-12-29 16:13:54 +09:00
Yu Watanabe 0b81225e57 network: drop unnecessary routing policy rules
networkd already drop foreign address, routes, and nexthops on startup,
except those created by kernel. However, previously, routing policy
rules were not. The logic of serialization/deserialization of rules only
works for rules created by previous invocation of networkd, and does not
work for one created by other tools like `ip rule`.

This makes networkd drop foreign routing policy rules except created by
kernel on startup. Also, remove rules created by networkd when the
corresponding links are dropped or networkd is stopping.
2020-12-29 16:13:54 +09:00
Yu Watanabe e737dce544 network: treat rule which has l3mdev flag as created by kernel 2020-12-29 16:13:39 +09:00
Yu Watanabe 569eeb0c05 network: adjust protocol of rules sent from kernel when kernel does not support FRA_PROTOCOL
Otherwise, each configured rule is treated as foreign.
2020-12-29 16:03:26 +09:00
Yu Watanabe 1e5fd3216a network: set FRA_PROTOCOL to RTPROT_STATIC by default 2020-12-29 16:03:26 +09:00
Yu Watanabe b945573303 Merge pull request #18021 from ssahani/route-allow-list
networkd: add support for prefix allow-list and route allow-list
2020-12-24 22:31:37 +09:00
Yu Watanabe 635f2a6692 test-network: add tests for [IPv6AcceptRA] PrefixDenyList= or friends 2020-12-24 17:16:15 +09:00
Yu Watanabe 75d2641190 network: introduce RouterAllowList= and RouterDenyList= in [IPv6AcceptRA] 2020-12-24 17:16:15 +09:00
Yu Watanabe 3f0af4a5f9 network: rename DenyList= -> PrefixDenyList= 2020-12-24 17:15:44 +09:00
Yu Watanabe 19e334bd15 network: make RouteDenyList= filter route prefix rather than gateway address
DenyList= filters provided prefixes, not router address.
So, RouteDenyLisy= should so for consistency.

Fixes 16c89e649d.
2020-12-24 17:15:44 +09:00
Yu Watanabe 1cd5267e81 network: fix condition for checking the provided gateway is assigned to link
Fix bug introduced by 221019166f.
2020-12-24 17:15:44 +09:00
Yu Watanabe 0afa4d569d sd-ndisc: fix indentation 2020-12-24 17:15:44 +09:00
Yu Watanabe 8c86196b52 network: drop redundant TAKE_PTR()
Follow-up for 16c89e649d.
2020-12-24 17:15:14 +09:00
Yu Watanabe bc1a4d28bb Merge pull request #18069 from flokli/ipv6-privacy-extensions-kernel
network: fix IPv6PrivacyExtensions=kernel
2020-12-24 08:56:24 +09:00
Yu Watanabe 9df1e11e31 udev: fix memleak
Fixes #18039.
2020-12-21 16:55:56 +01:00
Yu Watanabe 8786d4bbe4 journal-importer: ignore invalid field at one more place
Fixes oss-fuzz#28817.
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=28817
2020-12-21 12:40:44 +00:00
Yu Watanabe 94d982bb6a Merge pull request #18040 from mrc0mmand/cryptenroll-unused-variable
cryptenroll: drop an unused variable
2020-12-21 09:21:22 +09:00
Yu Watanabe 87cc47ba1d Merge pull request #18029 from bluca/minor_fixes
Minor test script runner and labeller bot fixes
2020-12-20 10:01:59 +09:00
Yu Watanabe d1a61dfa69 tmpfiles: fix typo
Follow-up for 94566540e3.
2020-12-19 00:58:22 +09:00
Yu Watanabe 8a5a01d19c Merge pull request #18019 from yuwata/hostname-drop-libudev
hostname: fix build failure
2020-12-19 00:57:36 +09:00
Yu Watanabe a4c3c5b751 man: update org.freedesktop.hostname1.xml 2020-12-18 23:25:43 +09:00
Yu Watanabe 3693cbacf7 memory-id: fix never hit condition
As sizeof(int64_t) is always 8.
2020-12-18 23:13:21 +09:00
Yu Watanabe 0be6dee2c2 hostname: fix build failure
Follow-up for b9d8069832.

libudev.h was dropped from most of our binaries.
2020-12-18 23:11:02 +09:00
Yu Watanabe af42881bf9 Merge pull request #18015 from keszybz/dmi-test-mesonification2
Dmi test mesonification2
2020-12-18 21:44:00 +09:00
Yu Watanabe 9f62de5762 Merge pull request #18011 from yuwata/trivial-fixes
Trivial fixes for recently merged PRs
2020-12-18 20:12:02 +09:00
Yu Watanabe fd4835bdf8 Merge pull request #17693 from yuwata/tmpfiles-compress-nocow-on-btrfs
tmpfiles: try to set file attributes one by one
2020-12-18 16:52:29 +09:00
Yu Watanabe ee672fd30b Merge pull request #18009 from poettering/time-set-sync-target
tweaks for time-sync.target and time-set.target
2020-12-18 16:02:56 +09:00
Yu Watanabe eca248640b netlink: fix size of fib rule messages 2020-12-18 13:27:44 +09:00
Yu Watanabe 8940baac4d meson: sort files 2020-12-18 13:27:44 +09:00
Yu Watanabe 479667c497 nspawn: sort headers 2020-12-18 13:27:44 +09:00