SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
30,484 Commits 2 Branches 1 Tag
caa45f5b4e712ae85cf3703b554bf6a61636692d
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Yu Watanabe 3fcf65c352 test-parse-util: add more tests, mainly for empty string 2017-11-09 18:39:50 +09:00
Yu Watanabe ccd1fc2f69 libsystemd-network: coding style fix 2017-11-09 18:39:41 +09:00
Yu Watanabe 1950011227 tree-wide: do not work in assert() 
Follow-up for 85e55d14de.
 2017-11-09 18:38:02 +09:00
Yu Watanabe fdfcb94631 man: update documents for RuntimeDirectory= and friends 2017-11-08 15:52:08 +09:00
Yu Watanabe 8092a48cc1 core/execute: do not create RuntimeDirectory= under private/ sub-directory 
RuntimeDirectory= often used for sharing files or sockets with other
services. So, if creating them under private/ sub-directory, we cannot
set DynamicUser= to service units which want to share something through
RuntimeDirectory=.
This makes the directories given by RuntimeDirectory= are created under
/run/ even if DynamicUser= is set.

Fixes #7260.
 2017-11-08 15:50:58 +09:00
Yu Watanabe 2bf13bd51e core/load-fragment: fix alignment 2017-11-08 15:49:22 +09:00
Yu Watanabe 652bb2637a core/execute: RuntimeDirectory= or friends requires mount namespace 
Since #6940, RuntimeDirectory= or their friends imply BindPaths=.
So, if at least one of them are set, mount namespace is required.
 2017-11-08 15:48:51 +09:00
Yu Watanabe 23fd04e92d test: add test for ReadOnlyPaths= with RuntimeDirectory= 2017-11-08 15:48:32 +09:00
Yu Watanabe d18aff0422 core: ReadWritePaths= and friends assume '+' prefix when BindPaths= or freinds are set 
When at least one of BindPaths=, BindReadOnlyPaths=, RootImage=,
RuntimeDirectory= or their friends are set, systemd prepares
a namespace under /run/systemd/unit-root. Thus, ReadWritePaths=
or their friends without '+' prefix is completely meaningless.
So, let's assume '+' prefix when one of them are set.

Fixes #7070 and #7080.
 2017-11-08 15:48:01 +09:00
Yu Watanabe 7bcef4efe6 core: remove compile_read_write_paths() 
From 6c47cd7d3b, RuntimeDirectory= and
their friends also imply BindPaths=. Thus, implying ReadWritePaths=
is meaningless.
 2017-11-08 15:07:22 +09:00
Yu Watanabe a4465d0d4c timesync: make poll interval configurable 
This adds PollIntervalMinSec= and PollIntervalMaxSec= to timesyncd.conf

Closes #7262.
 2017-11-08 01:47:38 +09:00
Yu Watanabe 85e55d14de tree-wide: do not work in assert() (#7271) 
Fixes #7270.
 2017-11-07 16:04:20 +03:00
Yu Watanabe f907cc1620 timesync: add RootDistanceMaxSec= to timesyncd.conf (#7215) 
Closes #7211.
 2017-11-05 07:39:34 +01:00
Yu Watanabe 2e293b4a14 journal-remote: set description to timer_event (#7234) 
Follow-up for 5e38eb931f.
 2017-11-01 10:13:00 +01:00
Yu Watanabe 3bd469546b meson: do not create systemd-user-sessions.service if PAM is disabled 
Fixes #7227.
 2017-10-31 17:12:36 +09:00
Yu Watanabe 5b316b9ea6 meson: do not include man/meson.build if xsltproc not found 
Fixes #7232.
 2017-10-31 17:12:21 +09:00
Yu Watanabe 21df96c0b0 resolved: change newline position in stub-resolv.conf (#7216) 
Follow-up for e6b2d948f8.
 2017-10-30 10:34:41 +01:00
Yu Watanabe a8caf8b251 Merge pull request #7066 from poettering/specifier-update 
extend unit file specifier expansion a bit + add a test for it
 2017-10-27 12:09:26 +09:00
Yu Watanabe 3f856a2813 core: fix D-Bus API 
This fixes bugs introduced by cffaed83e8.

Closes #7129.
 2017-10-24 17:21:27 +09:00
Yu Watanabe c85f1346c0 man: add explanation about target's DefaultDependencies= (#7120) 
Closes #7113.
 2017-10-18 08:30:35 +02:00
Yu Watanabe 3bd493dc93 man: comment a requirement about the static user or group when DynamicUser=yes 2017-10-18 15:30:00 +09:00
Yu Watanabe e2b0cc3415 core: fix invalid error message 
The error message corresponds to EILSEQ is "Invalid or incomplete
multibyte or wide character", and is not suitable in this case.
So, let's show a custom error message when the function
dynamic_creds_realize() returns -EILSEQ.
 2017-10-18 08:57:59 +09:00
Yu Watanabe 709dbeac14 core: cleanup for enforce_groups() (#7064) 
SupplementaryGroups= is preprocessed in get_supplementary_groups().
So, it is not necessary to input ExecContext to enforce_groups().
 2017-10-12 08:10:25 +02:00
Yu Watanabe 038a373651 test-execute: always use /bin/sh 2017-10-12 13:26:39 +09:00
Yu Watanabe d053b72bdd test: add test for BindPaths= and BindReadOnlyPaths= 
Follow-up for a8cabc612b.
 2017-10-12 13:25:06 +09:00
Yu Watanabe 9ec655cbbd dynamic-user: permit the case static uid and gid are different 
This makes systemd supports the case that DynamicUser=yes and
static user and group exist such that uid and gid of them are different.
We only refuse the operation when user does not exist but the group
with the same name exists.

Fixes #7013.
 2017-10-11 14:41:19 +09:00
Yu Watanabe 9da440b1b3 dynamic-user: label functions not necessary to export as static 2017-10-11 12:46:27 +09:00
Yu Watanabe a8cabc612b core: fix segfault in compile_bind_mounts() when BindPaths= or BindReadOnlyPaths= is set 
This fixes a bug introduced by 6c47cd7d3b.

Fixes #7055.
 2017-10-11 12:28:22 +09:00
Yu Watanabe a7456af52c meson: fix feature list (#7011) 2017-10-06 09:33:21 +02:00
Yu Watanabe 4240cb02fd sysusers: do not create unneeded users 2017-10-06 16:06:47 +09:00
Yu Watanabe 941afc4b90 unit: enable DynamicUser= for journal-upload 2017-10-06 16:06:21 +09:00
Yu Watanabe 48d3e88c18 timesyncd: enable DynamicUser= 2017-10-06 16:05:20 +09:00
Yu Watanabe c31ad02403 mkdir: introduce follow_symlink flag to mkdir_safe{,_label}() 2017-10-06 16:03:33 +09:00
Yu Watanabe 689ca202e7 nss-systemd: if cannot open bus, then try to read user info directly (#6971) 
If sd_bus_open_system() fail, then try to read information about
dynamic users from /run/systemd/dynamic-uid.
This makes services can successfully call getpwuid() or their friends
even if dbus.service is not started yet.

Fixes #6967.
 2017-10-04 19:29:36 +02:00
Yu Watanabe 4c70109600 tree-wide: use IN_SET macro (#6977) 2017-10-04 16:01:32 +02:00
Yu Watanabe 6b5bb2f9d0 man: fix that the same option is listed twice (#6991) 2017-10-04 14:43:00 +02:00
Yu Watanabe 9f2d41a65f load-fragment: do not create empty array 
Originally added in 4589f5bb0a.
C.f. 8249bb728d and #6746.
 2017-10-04 11:23:42 +02:00
Yu Watanabe 07883f198d man: empty string resets the list of NTP servers (#6984) 2017-10-04 11:09:32 +02:00
Yu Watanabe 8502cadd4c Merge pull request #6940 from poettering/magic-dirs 
make sure StateDirectory= and friends play nicely with DynamicUser= and RootImage=/RootDirectory=
 2017-10-03 13:28:48 +09:00
Yu Watanabe 945c2931bb libsystemd: use IN_SET macro 2017-09-28 17:37:59 +09:00
Yu Watanabe 74dead3461 networkd: use assert_not_reached() 2017-09-28 15:38:50 +09:00
Yu Watanabe 25a1bffc8f networkd: use IN_SET macro 2017-09-28 15:37:38 +09:00
Yu Watanabe 615ded6233 network: change log level when sd_rtnl_message_get_family() returns invalid family (#6923) 
From bce67bbee3, systemd-networkd always shows
```
rtnl: received address with invalid family type 32, ignoring.
```
during boot-up. In the code, there are log_warning() and log_debug() for the
same situation, and the log_debug() is never called. So, let's lower the
log level and remove never called function.
 2017-09-27 17:55:13 +02:00
Yu Watanabe 0fe5062975 shared: allow to input empty string to config_parse_path() 
Fixes #6633.
 2017-09-05 15:13:05 +09:00
Yu Watanabe 499295fb46 socket: Symlinks= with empty string resets the list of paths. 2017-09-05 15:08:59 +09:00
Yu Watanabe 7dd0974620 test: update test-unit-file 
Follow-up for c792ec2e35.
 2017-09-04 16:25:28 +09:00
Yu Watanabe de7070b49a man: add examples for CapabilityBoundingSet= 
Follow-up for c792ec2e35.
 2017-09-04 16:20:55 +09:00
Yu Watanabe e2be442e79 systemd-mount: allow to specify an arbitrary string for arg_mount_what when vfs is used 
Fixes #6591.
 2017-09-04 10:55:51 +09:00
Yu Watanabe 4185da7c4d systemd-mount: fix that wrong argument is used for arg_mount_what 2017-09-01 17:11:23 +09:00
Yu Watanabe e8d85bc062 man: LockPersonality= takes a boolean argument (#6718) 
Follow-up for 78e864e5b3.
 2017-09-01 09:38:41 +02:00
Yu Watanabe 621a2c804c man: fix path for storing random seed 2017-08-31 18:37:27 +09:00
Yu Watanabe d7bdedae87 TODO: update 2017-08-31 18:37:22 +09:00
Yu Watanabe 181b4f56e7 unit: use StateDirectory= instead of RequiresMountsFor= 2017-08-31 18:37:11 +09:00
Yu Watanabe 96f9f6aca7 unit: drop redundant options 2017-08-31 18:29:41 +09:00
Yu Watanabe ada5e27657 core: StateDirectory= and friends imply RequiresMountsFor= 2017-08-31 18:19:35 +09:00
Yu Watanabe ae978b9f6c bus-util: remove unnecessary initializations 2017-08-31 17:08:30 +09:00
Yu Watanabe 52610b020c systemctl: show capabilities in human readable format 
Follow-up for 21771f338d.
 2017-08-31 17:07:28 +09:00
Yu Watanabe e64aae43dd man: journal-remote: add detailed condition when SplitMode=none must be used 2017-08-30 17:03:37 +09:00
Yu Watanabe cb30d3ba66 journal-remote: show error if SplitMode=host with 'active' source is specified 2017-08-30 16:56:41 +09:00
Yu Watanabe 5ed0dcf4d5 test: drop Exec* prefixes to obtain paths of executables 2017-08-30 16:00:07 +09:00
Yu Watanabe 53d133ea1b timesync: move stamp file to /var/lib/systemd/timesync/clock 2017-08-30 15:59:57 +09:00
Yu Watanabe 6b1b9f75c8 journal-remote: show error message if output file name does not end with .journal 
`journalctl -o export | systemd-journal-remote -o /tmp/dir -`
gives the following error messages.
```
Failed to open output journal /tmp/dir: Invalid argument
Failed to get writer for source stdin: Invalid argument
Failed to create source for fd:0 (stdin): Invalid argument
```
And these are hard to understand what is the problem.
This commit makes journal-remote check whether the output file name
ends with .journal suffix or not, and if not, output error message.
 2017-08-27 16:34:57 +09:00
Yu Watanabe c298b083c6 man: journal-remote: active mode without --url option requires output filename 
Closes #6675.
 2017-08-27 16:20:16 +09:00
Yu Watanabe 87a85e25a2 units: make use of !! ExecStart= prefix in systemd-timesyncd.service 
Let's make use of !! to run timesyncd with ambient capabilities on
systems supporting them.
 2017-08-27 01:41:12 +09:00
Yu Watanabe c61f302d3c units: make use of !! ExecStart= prefix in systemd-networkd.service 
Let's make use of !! to run networkd with ambient capabilities on
systems supporting them.
 2017-08-27 01:40:47 +09:00
Yu Watanabe 5ce96b141a Merge pull request #6582 from poettering/logind-tty 
various tty path parsing fixes
 2017-08-26 22:12:48 +09:00
Yu Watanabe 2c5ad0fd6d Merge pull request #6577 from poettering/more-exec-flags 
add ! and !! ExecStart= flags to make ambient caps useful
 2017-08-26 21:49:05 +09:00
Yu Watanabe d7ea7bb8a8 network,resolve: remove comments related to kdbus 2017-08-23 12:42:35 +09:00
Yu Watanabe fb72b1d99f networkd: do not fail manager_connect_bus() if dbus is not active yet 
Fixes #6618.
 2017-08-23 12:42:22 +09:00
Yu Watanabe 9b5c390fe3 man: mention configuration directories to sysusers.d 2017-08-23 12:40:07 +09:00
Yu Watanabe 521d3679c1 Merge pull request #6615 from ssahani/client-id 
networkd: fix spell DCHPClientIdentifier (DCHP => DHCP)
 2017-08-22 20:19:19 +09:00
Yu Watanabe 2d56bdabc2 man: fix wrong citation in systemd-sysctl.service.xml 2017-08-22 13:26:09 +09:00
Yu Watanabe 4429c69f8d units: do not perform m4 if not necessary (#6575) 2017-08-09 09:13:41 -04:00
Yu Watanabe debe5d2376 unit: remove redundant options 2017-08-08 12:17:12 +09:00
Yu Watanabe 29444df23b tmpfiles: drop systemd-remote.conf 
The directories are only used by the specific services, and
created before the services are started. So, it is not necessary
to create them by systemd-tmpfiles.
 2017-08-08 12:17:07 +09:00
Yu Watanabe d0e62ae0f6 units: use {State,Logs}Directory= if they are applicable 2017-08-08 12:17:01 +09:00
Yu Watanabe cffaed83e8 core: add missing properties in D-Bus API 
Closes #6466.
 2017-08-08 00:37:02 +09:00
Yu Watanabe b16bd5350f seccomp-util: add parse_syscall_archs() 2017-08-07 23:41:52 +09:00
Yu Watanabe 29ea9f0f42 process-util: add sched_{policy,priority}_is_valid() 2017-08-07 23:41:39 +09:00
Yu Watanabe 032cf8e4d2 cpu-set-util: add parse_cpu_set() 2017-08-07 23:40:40 +09:00
Yu Watanabe 07d46372fe securebits-util: add secure_bits_{from_string,to_string_alloc}() 2017-08-07 23:40:25 +09:00
Yu Watanabe dd1f5bd0aa cap-list: add capability_set_{from_string,to_string_alloc}() 2017-08-07 23:25:11 +09:00
Yu Watanabe 2d35b79cdc man: DynamicUser= does not imply PrivateDevices= (#6510) 
Follow-up for effbd6d2ea.
 2017-08-07 11:02:47 +02:00
Yu Watanabe e2e8683e6b microhttpd-util: add comment 2017-08-07 10:35:05 +09:00
Yu Watanabe 837df14040 core: do not ignore returned values 2017-08-06 23:34:55 +09:00
Yu Watanabe a77e00a5dc journal-remote: remove MHD_USE_PEDANTIC_CHECKS from the default flags 
Follow-up for 0105858734.
 2017-08-06 23:26:46 +09:00
Yu Watanabe 70d54d9072 core: replace strcmp() == 0 with streq() 2017-08-06 13:08:40 +09:00
Yu Watanabe e940c1ef1d core: fix typo 2017-08-06 13:08:37 +09:00
Yu Watanabe ecfbc84f1c core: define variables only when they are required 
Follow-up for 7f18ef0a55.
 2017-08-06 13:08:34 +09:00
Yu Watanabe 21771f338d bus-util: do not print (uint64_t) -1 as is (#6522) 
Closes #4295 and #6511.
 2017-08-05 20:37:25 -04:00
Yu Watanabe ad6fc5bbae meson: fix modprobedir (#6523) 
Follow-up for 582faeb461.
 2017-08-03 08:01:38 -04:00
Yu Watanabe 0105858734 journal-remote: use MHD_OPTION_STRICT_FOR_CLIENT if MHD_USE_PEDANTIC_CHECKS is deprecated 
The option MHD_OPTION_STRICT_FOR_CLIENT is provided since libmicrohttpd-0.9.54, and
MHD_USE_PEDANTIC_CHECKS will be deprecated in future.
This makes support both option.
 2017-07-28 16:22:14 +09:00
Yu Watanabe 315629a83f journal-gateway: use MHD_USE_POLL_INTERNAL_THREAD instead of MHD_USE_POLL 
The option MHD_USE_THREAD_PER_CONNECTION requires MHD_USE_POLL_INTERNAL_THREAD
since libmicrohttpd-0.9.53.
If MHD_USE_POLL is used instead of MHD_USE_POLL_INTERNAL_THREAD, then
the library outputs the following warning:
```
Warning: MHD_USE_THREAD_PER_CONNECTION must be used only with
MHD_USE_INTERNAL_POLLING_THREAD. Flag MHD_USE_INTERNAL_POLLING_THREAD was added.
Consider setting MHD_USE_INTERNAL_POLLING_THREAD explicitly.
```
The option MHD_USE_POLL_INTERNAL_THREAD is defined as
`MHD_USE_POLL_INTERNAL_THREAD = MHD_USE_POLL | MHD_USE_INTERNAL_POLLING_THREAD,`
So, let's use MHD_USE_POLL_INTERNAL_THREAD instead of MHD_USE_POLL.
 2017-07-28 13:37:10 +09:00
Yu Watanabe c831aa7554 journal-remote,gateway: use MHD_USE_TLS instead of MHD_USE_SSL 
The option is renamed in libmicrohttpd-0.9.52.
 2017-07-28 13:37:10 +09:00
Yu Watanabe b7f2d0ba24 units,sysusers: use DynamicUser= for journal-gatewayd and drop user systemd-journal-gateway from sysusers 2017-07-28 13:37:10 +09:00
Yu Watanabe 6bda23dd6a bash-completion: use the first argument instead of the global variable (#6457) 
Without this fix:

$ systemctl start <tab>
Display all 135 possibilities? (y or n)
$ __get_startable_units --system | wc -l
224

the number of the suggestions are quite different, as __get_startable_units --system does
not filter already started units. With this fix,

$ systemctl start <tab>
Display all 135 possibilities? (y or n)
$ __get_startable_units --system | wc -l
123
$ __get_template_names --system | wc -l
12

the number of the suggestions matches one the function returns.
For consistency with the other internal functions, it should use the first argument
instead of the global variable $mode.

[zj: add commit message to make it sound like we know what we're doing]
 2017-07-27 07:22:54 -04:00
Yu Watanabe 2d5dece8ec basic: cosmetic changes (#6440) 2017-07-24 19:32:34 -04:00
Yu Watanabe 8ae12e733c core: fix typo (#6417) 2017-07-21 10:36:39 +02:00
Yu Watanabe a04efff8a7 test-unit-name: setup fake runtime directory before starting manager (#6401) 
Since 3536f49e8f, manager_new() in
user mode requires XDG_RUNTIME_DIR is set. So, in this commit,
setup_fake_runtime_directory() is added in the beginning of test.

Fixes an issue comment in #6384.
 2017-07-18 20:26:09 +03:00
Yu Watanabe 35aba85a73 core/manager: fix memory leak (#6400) 
This fixes the memory leak introduced by 3536f49e8f,
which forgot to free the prefixes in the manager.

Fixes #6398.
 2017-07-18 17:30:52 +03:00