Yu Watanabe
cf697ec00e
udev-rules: replace udev_device by sd_device in udev_rules_apply_to_event()
2018-11-07 13:35:03 +09:00
Yu Watanabe
dbea7f24d2
udev-rules: replace two udev_list_entry_foreach() by corresponding FOREACH_DEVICE_*() macros
2018-11-07 13:35:03 +09:00
Yu Watanabe
1017d66bf5
udev-rules: use structured initializer
2018-11-07 13:35:03 +09:00
Yu Watanabe
92b80c6baa
udev-rules: drop unused member file_list in struct udev_rules
2018-11-07 13:35:03 +09:00
Yu Watanabe
1ce7fecb4f
udev-rules: make import_parent_into_properties() take sd_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
13c7b75f2f
udev-rules: make import_file_into_properties() take sd_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
29b5eb5adf
udev-rules: make import_property_from_string() take sd_device
...
Also, this makes the function return negative errno, though its
return value is always ignored.
2018-11-07 13:35:03 +09:00
Yu Watanabe
f3d241feb2
udev: use sd_device for udev_event.dev_parent
2018-11-07 13:35:03 +09:00
Yu Watanabe
5ba7e79885
udev-rules: make match_attr() take sd_device instead of udev_device
2018-11-07 13:35:03 +09:00
Yu Watanabe
480ecb7d28
udev: use sd_device for udev_event.dev_db
...
Also, this adds sd_device_unref for the object in udev_event_free()
for safety and readability of code.
2018-11-07 13:35:03 +09:00
Yu Watanabe
e0bb2ff94b
udev-event: make udev_event_new() take sd_netlink and take a reference of that
2018-11-07 13:35:03 +09:00
Yu Watanabe
0f86dc900e
udev-event: make udev_event_new() take exec_delay
2018-11-07 13:35:03 +09:00
Yu Watanabe
5176b272ea
Merge pull request #10640 from evverx/networkd-fuzzers
...
Add a couple of fuzzers for network_load_one and netdev_load_one
2018-11-07 08:50:25 +09:00
Yu Watanabe
49a060aca8
Merge pull request #10654 from poettering/srand-rdrand
...
random-util.c mini-fixes
2018-11-07 02:03:09 +09:00
Yu Watanabe
ed2e7967be
time-util: make parse_sec() not accept "12.34.56"
...
This also changes the rational number treatment.
So, the limitations introduced by 8079c90333
and f6a178e91d are relaxed.
Fixes #10619 .
2018-11-06 19:24:47 +03:00
Yu Watanabe
faae64fa3d
udevd: increase default number of workers
...
The uevent handling in udevd is not cpu hungry.
So, let's increase the default number of workers per cpu.
This decrease the number of queued uevents.
Without this commit (children_max is 16 on my laptop)
```
$ journalctl -b -u systemd-udevd.service | grep reached | wc -l
1544
```
With this commit (children_max is 30 on my laptop)
```
$ journalctl -b -u systemd-udevd.service | grep reached | wc -l
7
```
2018-11-07 00:25:20 +09:00
Yu Watanabe
eca195ec23
udevd: wait 3 seconds before killing worker processes
...
During boot process, many worker processes are forked and killed.
To decrease cycles of forking and killing worker, let's wait
3 seconds before killing workers. If new uevent or inotify event
comes within the delay, the killing porcess will be cancelled.
2018-11-07 00:25:13 +09:00
Yu Watanabe
da14313418
udevd: drop redundant logic of receiving uevent
...
If there exists pending uevents, then sd-event invokes uevent handler.
So, it is not necessary to receive the next uevent in inotify event.
2018-11-06 23:53:55 +09:00
Yu Watanabe
b6107f010a
udevd: decrease indentation
2018-11-06 23:53:50 +09:00
Yu Watanabe
05e6d9c64b
udevd: merge conditions to decrease indentation
2018-11-06 23:21:25 +09:00
Yu Watanabe
7cadbe09e9
sd-device: use write_string_file() helper to write sysattr
2018-11-06 21:24:03 +09:00
Yu Watanabe
835d18ba20
fileio: introduce WRITE_STRING_FILE_NOFOLLOW flag for write_string_file() and friends
2018-11-06 21:24:03 +09:00
Yu Watanabe
57512c893e
tree-wide: set WRITE_STRING_FILE_DISABLE_BUFFER flag when we write files under /proc or /sys
2018-11-06 21:24:03 +09:00
Yu Watanabe
76cdddfb9d
udevd: use set_oom_score_adjust() to set OOM score
2018-11-06 21:24:03 +09:00
Yu Watanabe
92c40e1dc8
udevadm: use write_string_file() helper function
2018-11-06 21:24:03 +09:00
Yu Watanabe
90208b8217
test: add tests for string tables for lldp and ndisc events
2018-11-06 20:15:09 +09:00
Yu Watanabe
a2dcda328a
ndisc: improve debug log message
2018-11-06 20:15:09 +09:00
Yu Watanabe
4f0e4d29b0
lldp: improve debug log message
2018-11-06 20:15:09 +09:00
Yu Watanabe
6bee206591
udev-node: add one more debug log when failed to create symlink
2018-11-06 15:45:22 +09:00
Yu Watanabe
a126a38a9f
udev-node: drop redundant log message
...
As node_symlink() logs almost same message.
2018-11-06 15:45:22 +09:00
Yu Watanabe
6174a243f9
udev: setting the same log level to SYSTEMD realm
...
Otherwise, many debug logs from libsystemd are dropped.
2018-11-06 15:45:22 +09:00
Yu Watanabe
a5db6debcd
test: check returned value of sd_device_get_usec_since_initialized()
2018-11-06 15:45:22 +09:00
Yu Watanabe
754d6c26b4
test: show is_initialized flag in log message of test-sd-device
...
And drop devpath, as it is redundant for most cases.
2018-11-06 15:45:22 +09:00
Yu Watanabe
ecbe9873a9
test: show name of testing functions in test-sd-device
2018-11-06 15:45:22 +09:00
Yu Watanabe
c7d54daef9
sd-device: normalize debug messages
2018-11-06 15:45:22 +09:00
Yu Watanabe
38d1555d7c
sd-device: drop subsystem from log_device_*()
...
The sd_device object always has syspath and sysname, but subsytem may not.
Also, it may take some costs to get subsystem.
So, let's drop subsystem from logs.
2018-11-06 15:45:22 +09:00
Yu Watanabe
cc0bf5e148
udev-watch: adjust level of log messages
2018-11-06 11:15:39 +09:00
Yu Watanabe
7fe3324c5e
udev-watch: make udev_watch_lookup() return 1 when device found
2018-11-06 11:15:39 +09:00
Yu Watanabe
b7759e0403
udev: drop redundant log message and fix returned error code
2018-11-06 11:15:39 +09:00
Yu Watanabe
3d8d1f13d5
test: add tests for config_parse_address()
2018-11-05 16:46:26 +09:00
Yu Watanabe
b7cb445235
network: use in_addr_default_prefix_from_string_auto() in config_parse_address()
2018-11-05 16:46:26 +09:00
Yu Watanabe
c1d58204b2
test: add tests for in_addr_default_prefix_from_string() or friend
2018-11-05 16:46:26 +09:00
Yu Watanabe
a4798d4e6d
util: introduce in_addr_default_prefix_from_string() and friends
...
It is similar to in_addr_prefix_from_string() but it determines
the prefix length from address if it is not specified.
2018-11-05 16:46:26 +09:00
Yu Watanabe
67944f5c26
util: use strndup() instead of strndupa()
...
As the input string may be comes from command line or config files.
2018-11-05 16:46:00 +09:00
Yu Watanabe
a7cc45caad
network: sort headers in wireguard.h
2018-11-05 13:19:02 +09:00
Yu Watanabe
fc72155321
network: use structured initializers in wireguard.c
2018-11-05 13:19:02 +09:00
Yu Watanabe
c195364da5
network: fix crash in wireguard_done()
...
Fixes another issue in #10629 .
2018-11-05 13:19:02 +09:00
Yu Watanabe
56ba90c2df
network: use destroy callback to unref netdev attached to event source
2018-11-05 13:19:02 +09:00
Yu Watanabe
8173d1d0ec
network: use destroy callback to clear resolved wireguard endpoints
2018-11-05 13:19:02 +09:00
Yu Watanabe
c4397d94c3
network: link_drop() and netdev_drop() remove reference from manager
2018-11-05 13:19:02 +09:00
Yu Watanabe
2382c9367b
sd-event: add sd_event_source_{get,set}_floating()
2018-11-05 13:19:02 +09:00
Yu Watanabe
b3ae7237c6
sd-resolve: introduce sd_resolve_query_{get,set}_floating()
2018-11-05 13:19:02 +09:00
Yu Watanabe
a8319dea1d
sd-resolve: introduce sd_resolve_query_{get,set}_destroy_callback()
2018-11-05 13:19:02 +09:00
Yu Watanabe
383bb2bc1a
vlan-util: add assertions to parse_vlanid()
2018-11-04 00:31:46 +09:00
Yu Watanabe
2e5da68b7d
network: add missing .sections element for vcan and vrf
...
Fixes #10629 .
2018-11-04 00:31:46 +09:00
Yu Watanabe
de4224aa22
network: fix memleak abot Address.label
...
Also fix possible memleak about Address.section.
Fixes #10628 .
2018-11-04 00:31:46 +09:00
Yu Watanabe
22f64c32fa
test: UseRoutes= and UseTimezone= need to be in [DHCP] section
2018-11-04 00:31:46 +09:00
Yu Watanabe
9a4720a9ef
test-network: wait after removing links
...
After ec6a47044a , networkd starts
soon after removing links used by previous test. That causes
some racy situation of removing links and detecting links by networkd.
2018-11-04 00:31:46 +09:00
Yu Watanabe
7946d57f18
network: drop error cause in log message
...
Fixes for 21486d9e99 .
2018-11-04 00:31:46 +09:00
Yu Watanabe
ecee0abe77
network: fix memleak in static prefix
...
The fix by 744faf5e4e is not perfect,
as the section leaks if `hashmap_put()` in `prefix_new_static()` fails.
2018-11-04 00:31:46 +09:00
Yu Watanabe
6f1a96ded4
netdev: also support GENEVE.UDP6ZeroChecksum{Tx,Rx}=
...
After 53c06862c1 , we prefer Checksum
instead of CheckSum. Let's do so for GENEVE netdev.
2018-11-04 00:31:46 +09:00
Yu Watanabe
a6306c3176
man: drop duplicated line in systemd.netdev(5)
2018-11-04 00:31:46 +09:00
Yu Watanabe
fd3005f9b8
network: fix worng offset for .network parser
2018-11-04 00:31:46 +09:00
Yu Watanabe
899f0d259d
network: fix memleak in config_parse_hwaddr()
...
Fixes #10615 .
2018-11-04 00:31:46 +09:00
Yu Watanabe
44386b449b
network: improve readability of config_parse_ifalias()
2018-11-04 00:31:46 +09:00
Yu Watanabe
25ed70f76f
network: fix possible memleak caused by multiple setting of Bridge=, Bond= or VRF=
2018-11-04 00:31:46 +09:00
Yu Watanabe
5f74e49e85
test: add test for radv_prefix_delegation_{from,to}_string()
2018-11-04 00:31:46 +09:00
Yu Watanabe
6b1dec6696
network: introduce radv_prefix_delegation_{from,to}_string()
2018-11-04 00:31:46 +09:00
Yu Watanabe
8a4871c7d1
network: fix indentation
2018-11-04 00:31:46 +09:00
Yu Watanabe
8627d1120a
network: invert the order in comparison
2018-11-04 00:31:46 +09:00
Yu Watanabe
1176b054e1
network: shorten code a bit
2018-11-04 00:31:06 +09:00
Yu Watanabe
ed94652a33
test: drop 'After=multi-user.target' from most of testsuite.service
2018-11-03 18:00:47 +09:00
Yu Watanabe
056ae88152
test: mask several unnecessary services
...
This may make CIs run faster.
2018-11-03 18:00:47 +09:00
Yu Watanabe
f775f613ad
test: increase timeout for TEST-17-UDEV-WANTS
...
As the test randomly fails with timeout.
This may fix #10274 .
2018-11-03 18:00:47 +09:00
Yu Watanabe
76281c6408
test: also run compile tests for libudev.h
2018-11-03 18:00:47 +09:00
Yu Watanabe
f48ef53fb6
Merge pull request #10625 from evverx/test_routing_policy_rule
...
tests: make NetworkdNetWorkTests.test_routing_policy_rule pass on CentOS
2018-11-03 17:02:21 +09:00
Yu Watanabe
cb700a11d9
network: drop white space in log message
2018-11-01 23:41:29 +09:00
Yu Watanabe
0d7febd002
network: fix hash function for routing policy rule
2018-11-01 23:40:56 +09:00
Yu Watanabe
e6b65ab760
network: fix return value of routing_policy_rule_get()
...
To distinguish source of rule.
2018-11-01 23:38:11 +09:00
Yu Watanabe
a6276f0f3f
network: fix memleak in routing policy
...
As set_put() may fail if input is duplicated.
2018-11-01 23:24:20 +09:00
Yu Watanabe
744faf5e4e
network: fix memleak in static prefix
...
Fixes #10608 .
2018-11-01 21:46:38 +09:00
Yu Watanabe
f19ee68140
network: fix segfault in manager_free()
...
Fixes #10605 .
2018-11-01 20:26:02 +09:00
Yu Watanabe
7707a5e574
po: drop my copyright
2018-10-31 13:44:58 +01:00
Yu Watanabe
21486d9e99
network: also monitor udev 'change' event for network interfaces
...
If networkd starts earlier than all network interfaces are initialized,
then uninitialized interfaces are staying in pending state and cannot
become up.
With this, such interfaces are started after receiving 'change' event.
2018-10-31 12:08:34 +01:00
Yu Watanabe
12d1d3dfd1
Merge pull request #10586 from keszybz/more-copyright-and-license-cleanup
...
More copyright and license cleanup
2018-10-31 19:04:41 +09:00
Yu Watanabe
fbd0aea17e
dissect: do not store unused devnum
2018-10-31 09:29:51 +09:00
Yu Watanabe
4375dab58d
udev-event: fix timeout log messages
...
Follow-up for e81c3a4c5f .
2018-10-31 09:29:51 +09:00
Yu Watanabe
7af1c7808b
udev-event: do not store unused devnum
2018-10-31 09:29:51 +09:00
Yu Watanabe
d4a95a952e
udev-event: check whether device has devnum before calling udev_node_remove()
...
This fixes a bug in 'remove' event handling, which was introduced by
eb1f9e30ec , as 'devnum' variable may
not be initialized.
2018-10-31 09:29:51 +09:00
Yu Watanabe
b9e7ea4841
Merge pull request #10564 from evverx/lldp-fuzzer
...
tests: add an lldp fuzzer
2018-10-30 07:54:20 +09:00
Yu Watanabe
5a937ea2f6
sd-device: make sd_device_get_is_initialized() returns is_initialized by return value
2018-10-29 17:33:33 +09:00
Yu Watanabe
78ffb476f2
sd-device: make several sd_device_get_*() accepts NULL pointer for buffer of returned value
...
When only the existence of the value are important, then we can set
NULL now.
2018-10-29 17:18:00 +09:00
Yu Watanabe
7b32820444
Merge pull request #10551 from keszybz/two-trivial-cleanups
...
Two trivial cleanups
2018-10-29 12:03:27 +09:00
Yu Watanabe
898ce5e8b8
util: do not assign return value if it is not used ( #10552 )
2018-10-28 18:41:35 -07:00
Yu Watanabe
72e3507a60
po: update Japanese translation
2018-10-27 12:03:57 +02:00
Yu Watanabe
9c3c438514
Merge pull request #10537 from poettering/sentinelimania
...
add some missing _sentinel_ decorators
2018-10-27 07:49:28 +09:00
Yu Watanabe
4cade7a15b
udev-event: replace udev_device in subst_format_var() by sd_device
2018-10-27 07:25:27 +09:00
Yu Watanabe
a315999de6
udev-event: drop prototype of nonexistent function
2018-10-27 07:25:27 +09:00
Yu Watanabe
9204d8023f
udev-event: move definition of struct subst_map
2018-10-27 07:25:27 +09:00
Yu Watanabe
eb1f9e30ec
udev-event: replace udev_device in udev_event_execute_rules() by sd_device
...
Also, this adds many logs.
2018-10-27 07:25:27 +09:00