Luca Boccassi
e34836aa59
Merge pull request #29529 from yuwata/core-namespace-check-priv
...
core/namespace: check if we have enough privilege
2023-10-26 14:27:56 +01:00
Lennart Poettering
34931384ac
varlink: make sure 'incomplete' bool is nullable
...
This field is optional, it only makes sense for user records that
actually have a privileged part to set.
2023-10-26 11:52:07 +01:00
Yu Watanabe
e9af462aba
test: add a simple test for PrivateNetwork=
2023-10-26 19:09:49 +09:00
Yu Watanabe
4793605db1
core/namespace: check if we have enough privilege to mount sysfs or procfs
...
If we do not have enough privilege to mount a new instance of sysfs or
procfs, units e.g. with PrivateNetwork=yes may fail.
Let's first try to mount sysfs or procfs anyway to check if we have enough
privilege.
Fixes #29526 .
2023-10-26 19:09:46 +09:00
Yu Watanabe
b18f4eedeb
core/namespace: unify logic of mounting /proc and /sys
...
No functional change, just refactoring.
2023-10-26 19:06:27 +09:00
Frantisek Sumsal
fa16ce6c44
Merge pull request #29718 from yuwata/networkd-update-state-file-after-dhcp6-information-request
...
network: update state file when DHCPv6 reply for INFORMATION-REQUEST is received
2023-10-26 08:16:57 +00:00
Topi Miettinen
b208275300
core/cgroup: ignore NFT sets for other sources
...
Partially fixes : #29678
2023-10-26 08:24:14 +01:00
Luca Boccassi
43efbc3959
core: do not reset tty if there's no tty configured
...
Otherwise a lock is taken, which can be taken by multiple units at the
same time, depending on each other, causing a deadlock.
Fixes https://github.com/systemd/systemd/issues/29682
2023-10-26 09:13:05 +02:00
Yu Watanabe
9e15e24bdb
inotify-util: drop to use pointer outside of the buffer
...
Hopefully fixes many Coverity issues.
2023-10-26 09:08:28 +02:00
Yu Watanabe
1bd0cefcab
tree-wide: fix typo
2023-10-26 12:42:49 +09:00
Yu Watanabe
dd59a609be
test-network: suppress too much outputs of state file
...
Follow-up for 0f9efffaeb .
2023-10-26 12:26:19 +09:00
Yu Watanabe
ef0a234a75
network: update state file when DHCPv6 reply for INFORMATION-REQUEST is received
...
Otherwise, received information, e.g. DNS servers, may not be saved in
the state file, and will not be propagated to clients like resolved.
Fixes the first issue of #29678 .
2023-10-26 12:23:42 +09:00
Yu Watanabe
b9541abdb9
dissect: insert missing space
2023-10-26 12:16:12 +09:00
Daan De Meyer
c173be0d4c
Merge pull request #29708 from DaanDeMeyer/bootctl-always
...
Always build bootctl
2023-10-25 22:59:59 +02:00
Luca Boccassi
9ceda23941
Merge pull request #29710 from mrc0mmand/test-pcrextend
...
test: TEST-70-TPM2 shenagians
2023-10-25 21:13:56 +01:00
Frantisek Sumsal
dd741b8893
random-seed: terminate the option array
...
So we don't crash on invalid options:
$ build/systemd-random-seed --foo
Segmentation fault (core dumped)
2023-10-25 20:41:46 +01:00
Mike Yuan
8c29f6a572
man/systemd.unit: add PropagatesStopTo= to reverse property table
2023-10-25 19:34:17 +01:00
Frantisek Sumsal
d08b67e55e
test: slightly extend systemd-tpm2-setup's coverage
2023-10-25 18:18:48 +02:00
Frantisek Sumsal
181a80e602
tpm2-setup: drop the COMMAND placeholder from the help
...
Since systemd-tpm2-setup doesn't expect any arguments.
2023-10-25 18:18:48 +02:00
Frantisek Sumsal
91893f772b
tpm2-setup: terminate the option array
...
Otherwise bad things happen:
$ build/systemd-tpm2-setup --foo
Segmentation fault (core dumped)
2023-10-25 18:18:48 +02:00
Frantisek Sumsal
af70e2021e
test: add a couple more tests for systemd-pcrextend
2023-10-25 18:18:47 +02:00
Frantisek Sumsal
45534eefe6
test: make the TPM event log checking a bit more robust
...
Don't hardcode the event number, so the test works correctly even if
someone wrote to the event log before us. Also, explicitly pick the
sha256 bank when checking digests, as the indexing may vary depending on
current TPM's capabilities.
2023-10-25 18:18:11 +02:00
Daan De Meyer
7e7ea1b1c8
meson: Always build systemd-measure
...
Same idea as with bootctl, we might be doing image builds from a
system that doesn't boot with UEFI but we still might want to measure
stuff for the image we're building so let's not gate this behind
ENABLE_BOOTLOADER.
2023-10-25 16:49:30 +02:00
Daan De Meyer
dedb925eaf
meson: Always build bootctl
...
bootctl is rather useful to have, even if on a system without UEFI,
as it has a number of verbs that are unrelated to UEFI (e.g kernel-identify),
and more importantly, it supports --root to operate on directory trees
(which could be intended to be deployed on UEFI) so let's make sure we
always build it.
2023-10-25 16:49:24 +02:00
Raul Cheleguini
813dbff4d5
nspawn: allow user-specified MAC address on container side
...
Introduce the environment variable SYSTEMD_NSPAWN_NETWORK_MAC to allow
user-specified MAC address on container side.
2023-10-25 13:59:46 +01:00
Frantisek Sumsal
29be59555f
test: split TEST-70-TPM2 into subtests
2023-10-25 14:48:30 +02:00
Luca Boccassi
2e53544c76
Merge pull request #29704 from mrc0mmand/cocci
...
Another round of Coccinelle tweaks
2023-10-25 13:42:21 +01:00
Luca Boccassi
9674c06510
Merge pull request #29695 from poettering/repart-reduce-global-vars
...
repart,cryptenroll: three smaller tweaks
2023-10-25 13:18:38 +01:00
Lennart Poettering
3c6439bf2c
cryptsetup: remove redundant check
...
The immediately preceeding check already covered that.
This removes and addition made back in aae6eb9611 .
cc @williamcroberts
2023-10-25 13:18:17 +01:00
Luca Boccassi
4c46ece4c8
Merge pull request #29698 from poettering/tpm2-no-best-pcr
...
tpm2: minor tweaks
2023-10-25 13:18:03 +01:00
Frantisek Sumsal
1a9a61f9cc
udev: strdupa() → strdupa_safe()
2023-10-25 11:29:20 +02:00
Frantisek Sumsal
73151fbe30
network: use timestamp_is_set() in one more place
2023-10-25 11:28:12 +02:00
Frantisek Sumsal
25f7271c42
network: ENOTSUP → EOPNOTSUPP
2023-10-25 11:26:19 +02:00
Frantisek Sumsal
c8ccd444a2
core,journal: drop unnecessary !! casts
2023-10-25 11:21:40 +02:00
Frantisek Sumsal
b3bfb95178
coccinelle: don't run iovec-make on iovec_done{,_erase}
...
As the result is a bit funky (but still valid), i.e.:
static inline void iovec_done_erase(struct iovec *iovec) {
assert(iovec);
- iovec->iov_base = erase_and_free(iovec->iov_base);
- iovec->iov_len = 0;
+ *iovec = IOVEC_MAKE(erase_and_free(iovec->iov_base), 0);
}
2023-10-25 11:16:37 +02:00
Luca Boccassi
7470e161cf
Merge pull request #29553 from keszybz/analyze-cat-config-tldr
...
analyze/cat-config: add switch to print only "interesting" parts of conffiles
2023-10-25 09:53:19 +01:00
Lennart Poettering
980a5aeffa
tpm2-util: add line breaks in compound struct init, like we usually do
2023-10-25 10:33:29 +02:00
Frantisek Sumsal
b9439855d2
Merge pull request #29687 from yuwata/network-state-file-sync
...
network: several fixlets for state file
2023-10-25 08:29:58 +00:00
Lennart Poettering
51abb74eab
cryptenroll: validate positional arguments before looking at detail parameters
...
Let's switch the order in which we process positional arguments and
analyze/tweak detail parameters. Let's look at the positional arguments
first (i.e. the "big picture") and then look at the switches (i.e.
"little details").
THis doesn't matter much, but makes for better error messages I think.
At least I was very confused that a completely borked cmdline I passed
to cryptenrolled complained about some detail and let the major fuckup
pass...
2023-10-25 09:29:34 +02:00
Lennart Poettering
996d22e50a
cryptenroll: add section headers to --help text
2023-10-25 09:29:34 +02:00
Lennart Poettering
d66ff6fe77
cryptenroll: add addition asserts
2023-10-25 09:29:34 +02:00
Lennart Poettering
c588cf9720
repart: reduce scope of two variables
...
This replicates what 475c473d32 did for
cryptenroll for repart, which has very similar code for this.
2023-10-25 09:29:34 +02:00
Lennart Poettering
4af7f27aeb
tpm2-util: add line breaks in compound struct init, like we usually do
2023-10-25 09:29:20 +02:00
Lennart Poettering
3ee5e9d5f3
tpm2-util: dont't find best PCR bank if no PCRs are selected whatsoever
...
This will otherwise just yield weird log message, complaining that PCRs
were not initialized. But which PCRs if we have none selected?
2023-10-25 09:29:20 +02:00
Lennart Poettering
adabcbabff
execute: log about failures when opening a terminal to reset
2023-10-25 09:28:17 +02:00
Lennart Poettering
83d5bbaf1b
mount-util: add one more const
2023-10-25 15:53:10 +09:00
Lennart Poettering
8f21b3b21b
update TODO
2023-10-24 23:18:51 +02:00
Luca Boccassi
b7180e43a6
Merge pull request #29689 from mrc0mmand/test-shutdown
...
test: shorten service stop/abort timeouts for TEST-69-SHUTDOWN
2023-10-24 20:39:34 +01:00
Luca Boccassi
648fbfe621
Merge pull request #29677 from keszybz/rewinddir-alternative-fix
...
Rewind dir fd before using it for cleanup
2023-10-24 19:41:02 +01:00
Mike Yuan
828ad30470
sleep-config: make hybrid sleep always use 'suspend' disk mode
...
If user requests hybrid sleep, we should always use 'suspend'
disk mode. If that's not supported, let's correctly report it
so they can choose plain hibernation instead. HybridSleepMode=
serves no purpose in this case and should be removed.
Addresses https://github.com/systemd/systemd/pull/29681#discussion_r1369812785
2023-10-24 19:07:03 +02:00