SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
33,412 Commits 2 Branches 1 Tag
e8bce4fad357bbf98a900381bbf50343229180bd
Commit Graph
33412 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Zbigniew Jędrzejewski-Szmek e8bce4fad3 sd-resolve: trivial indentation fixes 2018-05-15 12:27:02 +02:00
Zbigniew Jędrzejewski-Szmek f6ddae40ab sd-resolve: do not assert on packet size received over a socket 
This is external data, even if trusted. We should not assert on it, but verify
and return proper error instead, which assert_return does. In particular,
write(2) says that a partial write could occur when interupted by a signal.
When compiled with asserts disabled, we could access memory outside of the
allocated buffer.

CID #1237671.
Follow-up for 1a96c8e1cc.
 2018-05-15 12:25:44 +02:00
Zbigniew Jędrzejewski-Szmek 0b45ff5278 sd-resolve: add helper macro for setting of ret/_errno/_h_errno 
Just to make things a bit shorter. This fixes an error where errno==-EIO would be set
(negative value), introduced in 1a96c8e1cc.
 2018-05-14 17:22:22 +02:00
Zbigniew Jędrzejewski-Szmek 9421cab6db test-copy: remove unnecessary initialization 
Initializing just some of the values doesn't make sense. We should handle them
all in the same way. In those tests there are no jumps, all steps are covered
with assert_se(), so we know everything will be set if we get to the end of the
function. And _not_ initializing those variables has the advantage that it
allows valgrind to catch potential initalization errors in the function being
tested.
 2018-05-14 17:22:22 +02:00
Zbigniew Jędrzejewski-Szmek dcd6361ea1 tree-wide: do not wrap assert_se in extra parentheses 
We were inconsitently using them in some cases, but in majority not.
Using assignment in assert_se is very common, not an exception like in
'if', so let's drop the extra parens everywhere.
 2018-05-14 17:22:22 +02:00
Zbigniew Jędrzejewski-Szmek 6978efcffb core/mount-setup: remove part of check which is always true 
f1470e424b removed one check, but missed a similar
one a few lines down.

CID #1390949.
 2018-05-14 08:50:00 +02:00
Lucas Werkmeister 8d29bef6b5 man: fix reference in StandardOutput= 
Since StandardOutput=file:path is more similar to StandardInput= than
StandardInputText=, and only StandardInput= is actually documented above
StandardOutput= whereas StandardInputText= is documented below it, I
assume the intention was to refer to the former.
 2018-05-14 08:11:37 +02:00
Zbigniew Jędrzejewski-Szmek 68367b52dd Merge pull request #8986 from yuwata/sd-bus-free-and-strdup 
several cleanups
 2018-05-14 08:10:46 +02:00
Yu Watanabe 3ecdd18f87 test: use _cleanup_hashmap_free_ instread of _cleanup_(hashmap_freep) 2018-05-14 14:14:17 +09:00
Yu Watanabe af4fa99d6a core: use _cleanup_set_free_ instread of _cleanup_(set_freep) 2018-05-14 14:13:57 +09:00
Yu Watanabe 1ab436e314 sd-bus: use free_and_strdup() 2018-05-14 14:09:03 +09:00
Zbigniew Jędrzejewski-Szmek 9d728570e7 Merge pull request #8968 from yuwata/bus-macro-2 
bus-util: add several macros for defining functions of getting dbus properties
 2018-05-13 19:12:27 +02:00
Yu Watanabe b5340a296c man: drop a trailing space 2018-05-13 18:44:25 +02:00
Yu Watanabe b4152e9be1 test: add tests for unit_name_from_dbus_path() 2018-05-13 18:44:25 +02:00
Zbigniew Jędrzejewski-Szmek 88136bbc98 Merge pull request #8962 from floppym/issue8905 
basic: timezone_is_valid: check for magic bytes "TZif"
 2018-05-13 18:43:11 +02:00
Yu Watanabe 3ff52e8f52 dbus-manager: introduce property_get_{hashmap,set}_size() 2018-05-13 12:21:17 +09:00
Yu Watanabe d1d8547137 dbus-unit: check userdata before obtaining data 2018-05-13 12:21:15 +09:00
Yu Watanabe cb7f88fcf4 dbus-unit: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:13 +09:00
Yu Watanabe 6bfb45bea4 dbus-swap: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:11 +09:00
Yu Watanabe a54f28bc1e dbus-socket: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:09 +09:00
Yu Watanabe f724fd4c25 dbus-mount: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:08 +09:00
Yu Watanabe 23c9a63a98 dbus-manager: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:06 +09:00
Yu Watanabe 019b34cae6 dbus-execute: use BUS_DEFINE_PROPERTY_GET* macros 2018-05-13 12:21:04 +09:00
Yu Watanabe f744776ff8 bus-util: add several macros for defining functions of getting dbus properties 2018-05-13 12:20:51 +09:00
Mike Gilbert 089fb8653f basic: add log_level argument to timezone_is_valid 2018-05-12 15:20:13 -04:00
Zbigniew Jędrzejewski-Szmek c1110f6cd7 Merge pull request #8959 from yuwata/bash-completion-analyze 
bash-completion: update completion for systemd-analyze
 2018-05-12 18:58:05 +02:00
Zbigniew Jędrzejewski-Szmek fb58b1ad27 Merge pull request #8966 from yuwata/bus-resolve-fallback-dns 
resolve: add bus property for fallback DNS servers
 2018-05-12 18:48:58 +02:00
David Tardon 95f14a3e21 core: use automatic cleanup more 2018-05-12 18:29:41 +02:00
Mikhail Kasimov fee09fb7ac po: uk: fixed missed word 
updated uk-translation for 'network time synchronization' construction.
 2018-05-12 18:19:38 +02:00
Danylo Korostil 0782a26792 Updated uk translation 2018-05-12 14:13:01 +02:00
Mike Gilbert a2932d5116 basic: timezone_is_valid: check for magic bytes "TZif" 
Fixes: https://github.com/systemd/systemd/issues/8905
 2018-05-11 14:11:30 -04:00
David Tardon c0a1bfacfe systemd-analyze: make dump work for large # of units 
If there is a large number of units, the size of the generated dump
string can overstep DBus message size limit. So let's pass that string
via a fd.
 2018-05-11 08:11:02 -07:00
Philip Withnall 7456fa0267 man: Fix a minor typo in systemctl(1) 
Signed-off-by: Philip Withnall <withnall@endlessm.com>
 2018-05-11 07:24:05 -07:00
Zbigniew Jędrzejewski-Szmek 2407ed7b63 Merge pull request #8924 from yuwata/fix-3682 
resolve: allow whitespaces in the digest
 2018-05-11 11:48:05 +02:00
Zbigniew Jędrzejewski-Szmek cb73dfc626 Merge pull request #8961 from yuwata/fix-8960 
network: make route_update() accept NULL
 2018-05-11 10:40:18 +02:00
Yu Watanabe c369f207f0 resolvectl: show current DNS server only when it is set 2018-05-11 16:12:57 +09:00
Yu Watanabe 4b320ac589 resolvectl: show fallback DNS servers by status command 2018-05-11 16:12:17 +09:00
Yu Watanabe ad32ac5397 resolve: introduce FallbackDNS bus property 
This also makes DNS bus property not include the fallback DNS servers.
 2018-05-11 16:03:19 +09:00
Yu Watanabe 26db55f39e network: make route_update() accept NULL 
This also fixes a wrong argument for route_configure().

Fixes #8960.
 2018-05-11 15:43:04 +09:00
Yu Watanabe 27efb52bc6 network: fix indentation 2018-05-11 15:30:39 +09:00
Lennart Poettering 4b93699d65 tmpfiles: remove newline that shouldn't be there 
We should really keep "else" branches together with their "if", hence
drop the double newline here...
 2018-05-11 08:15:33 +02:00
Lennart Poettering cb91deaf77 terminal-util: add a function that shows a pretty separator line 
Follow-up for #8824
 2018-05-11 08:15:33 +02:00
Yu Watanabe 2d2c21afb2 test: do not call alloca() inside the list of arguments 2018-05-11 15:01:35 +09:00
Lennart Poettering e4915c2797 Merge pull request #8953 from yuwata/bus-macro 
core: simplify dbus properties
 2018-05-10 22:51:17 -07:00
Yu Watanabe 1c5873096e test-execute: remove state directories before running tests 
Fixes #8679.
 2018-05-10 22:50:51 -07:00
Yu Watanabe 46657f637c units: set RestrictNamespaces=yes to networkd and resolved 
Closes #8949.
 2018-05-10 22:50:31 -07:00
Yu Watanabe ce088d6fb4 sd-dhcp: drop deserialize_dhcp_option() as it is equivalent to unhexmem() 2018-05-11 14:44:03 +09:00
Yu Watanabe 509685f91a resolve: allow whitespaces in the DS digest or DNSKEY key data 
Fixes #3682.
 2018-05-11 14:36:41 +09:00
Yu Watanabe 9ec578a370 hexdecoct: drop an unnecessary check 2018-05-11 14:36:36 +09:00
Yu Watanabe aba135249e basic: fix comment style 2018-05-11 14:36:32 +09:00