Jelle van der Waa
f564da0d1f
clang-tidy: enable bugprone-argument-comment check
2025-06-04 15:50:00 +02:00
Jelle van der Waa
63b21f503d
resolved-manager: rename 's' -> 'source'
2025-06-04 15:49:26 +02:00
Jelle van der Waa
a2f7e2c49d
nsresourcework: correct argument comment for userns_registry_*
2025-06-04 15:46:11 +02:00
Jelle van der Waa
38868c0b0d
nsresourcework: correct argument comments for inode_same_at
2025-06-04 15:39:17 +02:00
Jelle van der Waa
b1f7712348
importctl: correct argument comment
2025-06-04 15:38:53 +02:00
Jelle van der Waa
09c8a45e61
homectl: correct argument comments
2025-06-04 15:25:31 +02:00
Jelle van der Waa
ac3a403486
treewide: correct argument comments for sd_event_add_time
2025-06-04 13:32:24 +02:00
Jelle van der Waa
095031683f
treewide: correct argument comments for sd_netlink_call
2025-06-04 13:32:24 +02:00
Jelle van der Waa
1cce9d930a
treewide: correct argument comment to 'ret' where applicable
...
For functions with one return argument prefer 'ret' as argument comment.
2025-06-04 13:32:24 +02:00
Jelle van der Waa
d7e986b7f0
ask-password-api: correct argument comment
2025-06-04 13:32:23 +02:00
Jelle van der Waa
2b58550bd4
repart: correct argument comment
2025-06-04 10:52:59 +02:00
Jelle van der Waa
7a4eb66ee5
nsresourced: correct argument comments
2025-06-04 10:52:59 +02:00
Jelle van der Waa
edffcc84f2
sd-varlink: correct argument comment
2025-06-04 10:52:59 +02:00
Jelle van der Waa
ca6cac2b2d
homectl: rename 'emphasize_current' -> 'emphasize_current_password'
...
Other functions in this file use the same parameter naming.
2025-06-04 10:45:54 +02:00
Jelle van der Waa
946aeac968
generator: rename 'password' -> 'key_file'
...
Makes the header declaration and implementation consistent.
2025-06-04 10:45:54 +02:00
Jelle van der Waa
93117b0fbd
cgroup-util: rename 'fsfd' -> 'cgroups_fd'
...
Makes the header and implementation consistent.
2025-06-04 10:45:54 +02:00
Yu Watanabe
b525942037
man/pcrlock: fix typo
...
Follow-up for ccd2bf48b2 .
2025-06-04 13:13:14 +09:00
Adrian Vovk
f2494757c3
userdbctl: Label dynamic greeter users
2025-06-04 12:16:27 +09:00
Emmanuel Ferdman
13a98f1f05
doc: fix integration tests guide reference
2025-06-04 07:29:16 +09:00
Mike Yuan
20ae3ec9b5
core/varlink: use forward.h at two more places ( #37716 )
2025-06-03 23:11:17 +02:00
Yu Watanabe
813fcf2a8a
core/varlink: use forward.h at two more places
2025-06-04 04:57:32 +09:00
Lennart Poettering
d483ac1d0d
compress: avoid a bunch of div-by-zeroes
...
Follow-up for #37706 . Implements the same logic for all compression
algorithms we have.
2025-06-03 18:27:02 +02:00
Lennart Poettering
a53b225c53
tpm2: various smaller fixes, mostly about better error messages and support checking ( #37690 )
...
Fixes : #35187
Fixes : #36743
Fixes : #37607
2025-06-03 18:26:36 +02:00
Lennart Poettering
9c335d2458
tpm2-util: guarantee that verb_has_tpm2_generic() returns usable exit status
2025-06-03 16:16:46 +02:00
Lennart Poettering
8756482804
tpm2-util: use BIT_FOREACH() more
2025-06-03 16:16:46 +02:00
Lennart Poettering
1e08f92250
tpm2: add a clear error message for all errors that suggest a PCR violation
...
Fixes : #35187
2025-06-03 16:16:46 +02:00
Lennart Poettering
8335765bb8
tpm2-util: add a brief summary of tpm2_unseal() return values in a comment
2025-06-03 16:15:34 +02:00
Lennart Poettering
f31a87331f
tpm2-util: also generate recognizable error if PolicyAuthorizeNV fails
2025-06-03 16:12:45 +02:00
Lennart Poettering
c7ce6fd30e
pcrlock: also refuse lacking SHA-256 support early when creating policy
...
This will fail eventually, but let's be explicit early here.
2025-06-03 16:12:45 +02:00
Lennart Poettering
3ab04fbc4c
pcrlock: make error messages more useful if PCR state doesn't match policy during PolicyOR
...
Fixes : #35187
2025-06-03 16:12:45 +02:00
Lennart Poettering
1144f07dc6
measure: generate a more useful error in case SHA1 support is disabled by distro
...
Fixes : #36743
2025-06-03 16:12:45 +02:00
Lennart Poettering
ccd2bf48b2
pcrlock: add "is-supported" verb that checks if the local TPM supports the commands we need for pcrlock
...
systemd-pcrlock requires support for the PolicyAuthorizeNV command,
which is not implemented in the first TPM2 releases. We also strictly
require SHA-256 support. Hence add a tool for checking for both of
these.
This is a tighter version of "systemd-analyze has-tpm2", that checks for
the precise feature that systemd-pcrlock needs, on top of basic TPM2
functionality.
Fixes : #37607
2025-06-03 16:12:45 +02:00
Lennart Poettering
d1c36f11d5
tpm2-util: correct copy/pasted error message
2025-06-03 16:05:25 +02:00
Yu Watanabe
add1bc28d3
bus-unit-util: warn and ignore assignment of deprecated properties
...
With 5da476ac77 , we refused to set the
properties, but this relaxes the behavior, and now commands warn and
ignore the assignment.
Also, assignment of CPUAccounting property is now warned and ignored,
which is deprecated by 29da53dde3 .
Prompted by https://github.com/systemd/systemd/pull/37665#discussion_r2115676993
2025-06-03 15:31:05 +02:00
Yu Watanabe
cb109e00c4
repart: if partition already exists, required size may not be multiple of grain size
...
See partition_min_size_with_padding().
Fixes #37178 .
2025-06-03 10:42:34 +02:00
Arian van Putten
96e481bfbd
vmspawn: do not preserve access permissions and xattrs of template OVMF vars
...
This makes vmspawn work when /usr/share/qemu/edk2-i386-vars.fd is on
disk with 0444 permissions as is the case on NixOS.
The nix package manager does not store any access permissions, ownership,
timestamps, or extended attributes in its package format to increase
reproducibility. The only meta-data that is stored is the executable bit.
Thus when unpacking a nix package, the executable bit is preserved, but no other
access permissions are preserved and all files in /nix/store end up as
read-only.
This causes the template OVMF vars file to have 0444 permissions. If we preserve
those permissions when copying the template file to /tmp that means QEMU can not
write to the file and fails.
So lets not preserve permissions and keep the 0600 permissions that are set by
default.
2025-06-03 11:26:52 +09:00
Daan De Meyer
3590802fe3
repart: Add ratelimitting for progress updates
...
Same logic as in systemd-import, this is especially important when
systemd-repart is not run from a tty as currently we'll get something
like this:
```
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 98%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 99%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 100%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 100%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 100%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 100%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 100%
/var/tmp/.#repartc256fb6b9dc517af → /work/var/tmp/mkosi-workspace-2ek2c3n1/repart-definitions/10-root.conf 1.7G/1.7G 100%
```
2025-06-03 11:16:09 +09:00
Daan De Meyer
66772511d6
repart: Improve logging in resolve_copy_blocks_auto()
2025-06-03 11:12:50 +09:00
Yu Watanabe
a491eca403
Bugprone argument comment 8 ( #37678 )
...
Follow up from https://github.com/systemd/systemd/pull/37556
2025-06-03 10:58:52 +09:00
Luca Boccassi
6cd1842e33
test: send monotonic timestamp rather than unix seconds for MONOTONIC_USEC= argument
...
Follow-up for 3998b30a04
2025-06-03 10:54:03 +09:00
Alex and jinyaoguo
2584f745e0
compress: prevent divide-by-zero when no data is read ( #37706 )
...
If the first call to `loop_read()` returns 0 (no input), `total_in`
remains 0, causing `total_out/total_in` to potential divide by zero.
We add a check before logging the compression ratio to skip the
percentage calculation when total_in is zero.
Co-authored-by: jinyaoguo <guo846@purdue.edu >
2025-06-03 10:51:00 +09:00
Alex and jinyaoguo
1a596054a0
network: fix a potential divide-by-zero ( #37705 )
...
In function `tc_init`, hz is parsed from the content of file
`"/proc/net/psched"` and can be 0.
In function `hierarchy_token_bucket_class_verify`, hz is directly used
as a divisor in
`htb->buffer = htb->rate / hz + htb->mtu;` without any check. This adds a check on hz before using it as a divisor.
Co-authored-by: jinyaoguo <guo846@purdue.edu >
2025-06-03 07:47:49 +09:00
Anton Ryzhov
bd02e15710
man/systemd-creds: fix documentation typo in systemd.exec.xml
2025-06-03 07:42:44 +09:00
Michał Moczulski
f185180951
hwdb: fix touchpad for ASUS X1504ZA ( #37696 )
...
Added udev rule generated by `libinput measure fuzz --fuzz=8`, which
fixes my touchpad.
2025-06-02 21:12:07 +01:00
Jelle van der Waa
4b7edce916
shared/install.h: rename 'flags' -> 'file_flags'
...
Make it consistent with the implementation.
2025-06-02 18:05:47 +02:00
Jelle van der Waa
fa6f4484e8
io-util: rename 'nfds' -> 'n_fds'
2025-06-02 18:05:45 +02:00
Jelle van der Waa
8821a312a8
uid-range: correct argument comment
2025-06-02 17:39:44 +02:00
Jelle van der Waa
e58cf27aaf
sd-varlink: fix argument naming
2025-06-02 17:39:44 +02:00
Jelle van der Waa
2bfa3185aa
sd-journal: rename sd_journal_get_monotonic_usec ret argument
...
Rename ret to ret_monotonic to distinguish from ret_boot_id and
according to existing argument comments.
2025-06-02 17:39:44 +02:00
Jelle van der Waa
2377cbcd19
mount-util: correct argument comment
2025-06-02 17:39:44 +02:00