SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
20,913 Commits 2 Branches 1 Tag
f582dbaa142986e4dcf94de74b47c0f4e37b4ec8
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Thomas Hindoe Paaboel Andersen edf5b3b869 cgroup-util: actually use the path callback 
We allow to specify a callback but then ignore the result. Looks like a trivial typo.
From 7b3fd6313c4b07b6f822a9f979d0c22350a401d9#diff-f010fa21ba7b659b519c122743e55604
 2015-06-18 17:39:34 +02:00
Thomas Hindoe Paaboel Andersen 0aee49d5fb NEWS: typo fixes 2015-06-18 17:10:59 +02:00
Thomas Hindoe Paaboel Andersen 118786182b udved: remove dead code 
Leftover from 6af5e6a4c9
 2015-06-17 20:33:25 +02:00
Thomas Hindoe Paaboel Andersen 144c348883 sd-dhcp-client: readd deleted error check 
Seems to have been removed by mistake in:
9021bb9f93
 2015-06-17 19:11:18 +02:00
Thomas Hindoe Paaboel Andersen 19fcba36e4 test-netlink-manual: typo fix 
No functional change, but looked weird.
 2015-06-14 13:57:35 +02:00
Thomas Hindoe Paaboel Andersen 60053efbba core: log oom during killing spree 
but don't do anything else. We still want to kill as much as
possible.

Coverity CID#996306
 2015-06-09 22:07:27 +02:00
Thomas Hindoe Paaboel Andersen 00c11bc53a build-sys: don't suppress irrelevant warnings 
We do not trigger these warnings so no need to suppress them.
 2015-06-08 23:43:56 +02:00
Thomas Hindoe Paaboel Andersen 920b52e490 tree-wide: remove spurious space 2015-06-08 23:11:26 +02:00
Thomas Hindoe Paaboel Andersen 602ee553e4 test-util: fix a memleak 2015-06-03 19:50:02 +02:00
Thomas Hindoe Paaboel Andersen 7e518afab9 fix double semicolon typo 2015-06-02 23:29:20 +02:00
Thomas Hindoe Paaboel Andersen ce1daea1d1 terminal: fix include ordering 2015-05-30 00:02:29 +02:00
Thomas Hindoe Paaboel Andersen 56f342f397 console: use signal-util.h and reorder includes 
Missed this one from the previous commit
 2015-05-29 21:12:26 +02:00
Thomas Hindoe Paaboel Andersen 9dd008df45 terminal: use signal-util.h and reorder includes 2015-05-29 20:52:23 +02:00
Thomas Hindoe Paaboel Andersen dd114e116b bootctl: fix an error check 2015-05-23 13:03:30 +02:00
Thomas Hindoe Paaboel Andersen 717442507b bootctl: ferror must be called before FILE is closed 
Otherwise it will not show any error stored
 2015-05-22 23:46:36 +02:00
Thomas Hindoe Paaboel Andersen fecb719ec1 json: fix a mem leak 2015-05-19 23:19:54 +02:00
Thomas Hindoe Paaboel Andersen 6d9bad91d7 pull-dkr: fix memleak 2015-05-19 19:24:47 +02:00
Thomas Hindoe Paaboel Andersen e861098bf2 core: fix OOM checks in dbus-unit 
CID#1299014
 2015-05-19 06:46:59 +02:00
Thomas Hindoe Paaboel Andersen b669934fae test-hashmap: fix an assert 
CID#1299016
 2015-05-19 06:35:44 +02:00
Thomas Hindoe Paaboel Andersen 7185d80558 networkd: remove dead initialization 2015-05-13 23:44:20 +02:00
Thomas Hindoe Paaboel Andersen 91077af69e fsck: add enum with fsck exit codes 2015-05-12 22:09:48 +02:00
Thomas Hindoe Paaboel Andersen eacd853425 systemctl: fix check for template units 
A typo from 7410616c. We want to ignore EINVAL but only catch errors.
 2015-05-12 00:26:14 +02:00
Thomas Hindoe Paaboel Andersen 86ff9f1173 test-libudev: fix leak in error case 
CID# 1297428
 2015-05-11 21:42:59 +02:00
Thomas Hindoe Paaboel Andersen 12322d4100 swap: avoid null pointer dereference 
CID#1297436
 2015-05-11 21:03:50 +02:00
Thomas Hindoe Paaboel Andersen 74bddd6f19 udevd: remove unused function 2015-05-07 07:27:38 +02:00
Thomas Hindoe Paaboel Andersen 7f629b74c4 device: avoid null pointer dereference 2015-05-06 19:58:03 +02:00
Thomas Hindoe Paaboel Andersen c0c6a4fc1c test-libudev: add error handling 
CID#1296244
 2015-05-06 18:40:30 +02:00
Thomas Hindoe Paaboel Andersen 90615ad791 machinectl: remove unused variable 2015-05-06 18:23:46 +02:00
Thomas Hindoe Paaboel Andersen 470d7e17f9 terminal: update for simpler sd-bus api's 2015-04-30 20:12:48 +02:00
Thomas Hindoe Paaboel Andersen 68a01fb658 scope: use correct enum type 2015-04-28 19:03:11 +02:00
Thomas Hindoe Paaboel Andersen 8431778882 path-util: fix fstat fallback in fd_is_mount_point 2015-04-26 16:02:21 +02:00
Thomas Hindoe Paaboel Andersen 5921fc3cc3 sysv-generator: avoid freeing uninitialized variable 
Would happen if lookup_paths_init returns an error.
 2015-04-26 14:45:49 +02:00
Thomas Hindoe Paaboel Andersen 8d04b9af96 automount: remove unused variable 2015-04-21 22:40:10 +02:00
Thomas Hindoe Paaboel Andersen 70c79983e1 test-dhcp6-client: don't unref the event twice 2015-04-14 18:33:31 +02:00
Thomas Hindoe Paaboel Andersen 8283c71b71 sd-dhcp6-client: unref lease when freeing the client 2015-04-14 18:32:58 +02:00
Thomas Hindoe Paaboel Andersen a64edefacb test-ipv4ll: clean up the event 
shuts up valgrind/sanitizers
 2015-04-13 23:38:02 +02:00
Thomas Hindoe Paaboel Andersen 7a03974a6f sysv-generator: fix mem leaks 2015-04-11 13:47:56 +02:00
Thomas Hindoe Paaboel Andersen 05a08cb60f dbus: typo fix in log 2015-04-10 23:39:40 +02:00
Thomas Hindoe Paaboel Andersen 75c2a9fd13 tmpfiles: fix build with clang 
Clang is not happy about using the cleanup attribute in switches
 2015-04-10 23:28:08 +02:00
Thomas Hindoe Paaboel Andersen 733dbdc534 efivars: fix build for non-efi 2015-04-10 23:00:07 +02:00
Thomas Hindoe Paaboel Andersen 96406c1a27 util: fix a typo in comment 2015-04-09 23:58:28 +02:00
Thomas Hindoe Paaboel Andersen 8489a3b769 networkd: do not assign the variable twice 2015-04-09 00:05:58 +02:00
Thomas Hindoe Paaboel Andersen 48b0d27aab configure: sign-compare is part of extra 
Remove sign-compare as we already get it from extra
 2015-04-07 21:27:37 +02:00
Thomas Hindoe Paaboel Andersen 2bb9e6203d device: remove unused null check 
We dereference the variable right before the null check. We never reach
this point with a null value anyway so let's just remove it.
 2015-04-07 21:11:38 +02:00
Thomas Hindoe Paaboel Andersen 5d84c44a97 test-util: don't mix declarations and code 2015-04-07 20:54:23 +02:00
Thomas Hindoe Paaboel Andersen 4835f5639a libudev-util: check length before accesing the array 2015-04-05 08:46:01 +02:00
Thomas Hindoe Paaboel Andersen afbbf1369b service: remove unnecessary forward declare 2015-04-05 08:45:56 +02:00
Thomas Hindoe Paaboel Andersen a4135d3234 tmpfiles: avoid out of bounds read 
Otherwise this will go wrong for 'v'.
 2015-03-24 23:53:09 +01:00
Thomas Hindoe Paaboel Andersen eef8df097d timedatectl: remove unused variables 2015-03-24 22:56:28 +01:00
Thomas Hindoe Paaboel Andersen 1bc48c0471 fsck: use %zu for size_t 
cur and max were changed to size_t in ac6e2f0dfc
update the format accordingly.
 2015-03-19 21:11:32 +01:00
Thomas Hindoe Paaboel Andersen 0c900704e7 Add type specifier for int 2015-03-10 05:37:01 +01:00
Thomas Hindoe Paaboel Andersen 6c767d1e1a logs-show: fix check of loop_read_exact 
just a typo fix
 2015-03-10 05:37:01 +01:00
Thomas Hindoe Paaboel Andersen 061a237dd2 machinectl: remove unused variables 2015-03-09 21:09:18 +01:00
Thomas Hindoe Paaboel Andersen c43b2132f3 core: fix return value on OOM 2015-02-28 23:42:03 +01:00
Thomas Hindoe Paaboel Andersen 3a4efbff2e bootctl: check that partition uuid is valid 
It probably is but check anyway to make coverity happy.

CID#1271354
 2015-02-25 23:32:50 +01:00
Thomas Hindoe Paaboel Andersen 7cb0f263ad bootctl: fix mem leaks 
CID#1271347/1271348
 2015-02-25 00:00:32 +01:00
Thomas Hindoe Paaboel Andersen 858a109f4a machined: fix check if host directory could be opened 
CID#1271351
 2015-02-24 20:51:28 +01:00
Thomas Hindoe Paaboel Andersen 76dcbc4992 acl-util: avoid freeing uninitialized pointer 
CID#1271344/1271345
 2015-02-24 20:42:40 +01:00
Thomas Hindoe Paaboel Andersen 2eec67acbb remove unused includes 
This patch removes includes that are not used. The removals were found with
include-what-you-use which checks if any of the symbols from a header is
in use.
 2015-02-23 23:53:42 +01:00
Thomas Hindoe Paaboel Andersen 04155c6713 systemd-boot: fix alignment of version in table 2015-02-18 22:19:17 +01:00
Thomas Hindoe Paaboel Andersen b89c454b37 import: remove unused variable 2015-02-17 20:06:13 +01:00
Thomas Hindoe Paaboel Andersen 7edecf218e NEWS: typo fixes 2015-02-16 21:21:16 +01:00
Thomas Hindoe Paaboel Andersen 0a6f50c0af include <poll.h> instead of <sys/poll.h> 
include-what-you-use automatically does this and it makes finding
unnecessary harder to spot. The only content of poll.h is a include
of sys/poll.h so should be harmless.
 2015-02-12 20:47:38 +01:00
Thomas Hindoe Paaboel Andersen c1ff5570f4 Add missing includes in header files 
This fixes various issues found by globally reordering the include
sections of all .c files.
 2015-02-12 20:44:32 +01:00
Thomas Hindoe Paaboel Andersen 76f282c636 test-util: remove superfluous const 2015-02-12 20:44:11 +01:00
Thomas Hindoe Paaboel Andersen 8744505aae remove unused variable 2015-02-12 20:44:06 +01:00
Thomas Hindoe Paaboel Andersen 4cd552bc50 partial revert of fed6df8 
This one was acutally used to free xattr
 2015-02-03 21:40:30 +01:00
Thomas Hindoe Paaboel Andersen fed6df828d remove unused variables 2015-02-02 22:58:06 +01:00
Thomas Hindoe Paaboel Andersen 9a14fb6285 machinectl: Check type instead of path before printing the type 
Looks like a typo when introduced in fefdc04b38
 2015-01-02 21:38:22 +01:00
Thomas Hindoe Paaboel Andersen 30c873fbfb test-json: use fabs 2014-12-16 20:38:03 +01:00
Thomas Hindoe Paaboel Andersen b7378b89d2 networkctl: remove unused variable 2014-12-12 21:57:44 +01:00
Thomas Hindoe Paaboel Andersen abc08d4d08 wrap a few *_FOREACH macros in curly braces 
cppcheck would give up with "syntax error" without them. This led
to reports of syntax errors in unrelated locations and potentially
hid other errors
 2014-12-12 21:57:44 +01:00
Thomas Hindoe Paaboel Andersen c4ef05484d use correct format types 2014-12-11 21:47:06 +01:00
Thomas Hindoe Paaboel Andersen 1372d5eff4 networkd: remove unused variable 
It is no longer used after 45af44d47d
 2014-12-09 20:51:58 +01:00
Thomas Hindoe Paaboel Andersen 8b5e2af108 remove duplicated includes 2014-12-06 09:51:12 +01:00
Thomas Hindoe Paaboel Andersen d2df88ffba sd-bus: avoid a null dereference 2014-12-04 00:24:44 +01:00
Thomas Hindoe Paaboel Andersen 652212b0c2 systemctl: fix a leak 2014-12-04 00:15:02 +01:00
Thomas Hindoe Paaboel Andersen f08c4c08c7 test-path-util: fix a leak 2014-12-04 00:13:10 +01:00
Thomas Hindoe Paaboel Andersen 6c03d27d9f networkctl: remove unused variable 2014-12-03 23:51:56 +01:00
Thomas Hindoe Paaboel Andersen e706d931e0 util: don't shadow variable 
environ is already defined in unistd.h
 2014-12-03 23:51:51 +01:00
Thomas Hindoe Paaboel Andersen c09157eeea systemctl: remove unused variable 2014-11-30 00:36:16 +01:00
Thomas Hindoe Paaboel Andersen b5a1e50495 fix build with --enable-terminal 
Broke with 086891e5c1
 2014-11-27 23:18:34 +01:00
Thomas Hindoe Paaboel Andersen 8e24a4f8b6 pam_systemd: remove unused null check 
username was already checked with isempty() and cannot be null at
this point.

CID#1237766
 2014-11-15 23:47:39 +01:00
Thomas Hindoe Paaboel Andersen 85e74b26c3 autogen: drop unnecessary -Wno-gnu for the clang shortcut 
It is no longer necessary after 65e3a2cf7c
where -Wno-gnu-variable-sized-type-not-at-end is added if we detect
that the compiler is clang.
 2014-11-15 21:32:59 +01:00
Thomas Hindoe Paaboel Andersen 6f53e671aa util: avoid double close of fd 
We could end with a double close if we close the fd loop and flush_fd
fails. That would make us goto fail and there we close the fd once
again. This patch sets the fd to the return value for safe_close: -1
A fd with negative value will be ignored by the next call to
safe_close.

CID#996223
 2014-10-09 00:19:57 +02:00
Thomas Hindoe Paaboel Andersen 13303f018d sd-bus: remove unused variable 
It is no longer used after d663f1b1a9
 2014-10-07 00:00:21 +02:00
Thomas Hindoe Paaboel Andersen 0077776275 terminal: remove an unused initialization 2014-10-05 22:43:07 +02:00
Thomas Hindoe Paaboel Andersen bdf7026e95 test: only use assert_se 
The asserts used in the tests should never be allowed to be
optimized away
 2014-10-04 23:55:35 +02:00
Thomas Hindoe Paaboel Andersen 1c92ff85b7 bootchart: use 'n/a' if PRETTY_NAME is not found 
Spotted with coverity. If parsing both /etc/os-release and
/usr/lib/os-release fails then null would be passed on. The calls
to parse the two files are allowed to fail. A empty /etc may not
have had the /etc/os-release symlink restored yet and we just
try again in the loop. If for whatever reason that does not happen
then we now pass on 'n/a' instead of null.
 2014-10-03 08:31:53 -04:00
Thomas Hindoe Paaboel Andersen 2ad8887a12 test-barrier: add checks after the barrier constructor 
Coverity seems to think that we can later end up with the "them"
fd having a negative value. Even after a succesful barrier_create.
Add some test to verify that the constructor went well. If coverity
still complains then it must mean that it thinks the the value is
overwritten later.
 2014-10-03 04:04:42 +02:00
Thomas Hindoe Paaboel Andersen 94956f8fba firstboot: silence coverity 
CID#1237537
 2014-10-02 21:37:33 +02:00
Thomas Hindoe Paaboel Andersen cf4acf84c6 Remove repeated includes 
In pty.c there was both an include of our pty.h and the system installed pty.h.
The latter contains only two functions openpty and forkpty. We use neither so
I assume it was a typo and removed it. We still compile and pass all tests.
 2014-10-01 23:25:50 +02:00
Thomas Hindoe Paaboel Andersen 56a7dd42d3 gitignore: add test-set 2014-10-01 23:24:10 +02:00
Thomas Hindoe Paaboel Andersen 2b01a801f6 test-fileio: Remove dead check 
t cannot be null here
 2014-09-30 23:40:40 +02:00
Thomas Hindoe Paaboel Andersen 14c35ce7c1 test-date: don't fail test if log_max_level is higher than LOG_INFO 2014-09-30 23:40:40 +02:00
Thomas Hindoe Paaboel Andersen 59ae3a9573 test-path-util: fix a mem leak and avoid confusing coverity 
Found with coverity. Fixes CID#1237754 and #1237790
 2014-09-30 22:28:46 +02:00
Thomas Hindoe Paaboel Andersen 791a4fd837 vconsole: silence coverity 
Let's silence coverity here too. There is not much to do if the
ioctls to copy the fonts and character maps should fail.
 2014-09-30 21:27:54 +02:00
Thomas Hindoe Paaboel Andersen 5e90b6a978 test-bus-policy: silence coverity 
Check if strjoin worked and also use _cleanup_free_ since we are
here.

Found with Coverity. Fixes CID#1241962
 2014-09-28 18:48:33 +02:00
Thomas Hindoe Paaboel Andersen e931d3f424 bootchart: check return of strftime 
Found by coverity. Fixes: CID#996314 and #996312
 2014-09-28 14:46:38 +02:00
Thomas Hindoe Paaboel Andersen 9bcf7507fa bootchart: parse userinput with safe_atoi 
Found by coverity. Fixes: CID#996409
 2014-09-28 14:46:38 +02:00