SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
35,566 Commits 2 Branches 1 Tag
fbda85b07826c8edc8fc3f2ecfa8e4ce3ef10f7b
Commit Graph
35566 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lennart Poettering fbda85b078 tree-wide: use sockaddr_un_unlink() at two more places where appropriate 2018-10-15 19:44:34 +02:00
Lennart Poettering a4209121d7 udev: use safe_close() where we can 2018-10-15 19:40:51 +02:00
Lennart Poettering 6d5e65f645 tree-wide: add a single version of "static const int one = 1" 
All over the place we define local variables for the various sockopts
that take a bool-like "int" value. Sometimes they are const, sometimes
static, sometimes both, sometimes neither.

Let's clean this up, introduce a common const variable "const_int_one"
(as well as one matching "const_int_zero") and use it everywhere, all
acorss the codebase.
 2018-10-15 19:40:51 +02:00
Lennart Poettering 8e8132c6b8 socket-util: tighten socket_address_verify() checks a bit 2018-10-15 19:40:51 +02:00
Lennart Poettering 48e6a2dc84 socket-util: tweak commenting in socket_address_get_path() 
Let's make clear explicitly that there's always a NUL byte following the
path, and how.
 2018-10-15 19:40:51 +02:00
Lennart Poettering 69995bffb7 socket-util: include trailing NUL byte in SOCKADDR_UN_LEN() count for fs sockets 
This is what unix(7) recommends, hence do so.
 2018-10-15 19:40:51 +02:00
Lennart Poettering 95cb14b068 sd-bus: rework how we initialize struct sockaddr_un 
Let's use structured initialization, but more importantly, let's
increase salen by 1, if we reference AF_UNIX sockets in the file system,
so that they also contain the trailing NUL byte. This is what unix(7)
suggests to do, hence follow it.
 2018-10-15 19:40:51 +02:00
Lennart Poettering 1d261418e2 sd-bus: make parsing of AF_UNIX socket addresses more strict 
Insist on NUL termination, just to be safe rather than sorry. The kernel
doesn't require it, but it's really annoying if people rely on this,
hence refuse this early.
 2018-10-15 19:40:51 +02:00
Lennart Poettering 15a3e96f92 tree-wide: port various users over to sockaddr_un_set_path() 
CID 1396140
CID 1396141
 2018-10-15 19:40:51 +02:00
Lennart Poettering 5cf91ea9c8 socket-util: add sockaddr_un_set_path() helper 
Properly initializing sun_path from foreign data is not easy, given the
size constraints, and NUL confusion. Let's add a helper function for
this.
 2018-10-15 19:35:00 +02:00
Lennart Poettering 44ed5214ad tree-wide: use structured initialization for sockaddr_un 2018-10-15 19:35:00 +02:00
Lennart Poettering ececf6c082 core: be more specific in error message 2018-10-15 19:35:00 +02:00
Lennart Poettering 686192048a strxcpyx: minor coding style updates 2018-10-15 19:35:00 +02:00
Lennart Poettering 057e85805c socket-address: document socket address parsing size restrictions in a comment 2018-10-15 19:35:00 +02:00
Lennart Poettering 9ec30b2769 socket-util: use structured initialization 2018-10-15 19:35:00 +02:00
Lennart Poettering 0b7e8b322d tree-wide: make use of TAKE_FD() at two more places 2018-10-15 19:35:00 +02:00
Lennart Poettering 155b687669 tree-wide: use sockaddr_un_unlink() whereever appropriate 
Let's port everything over.
 2018-10-15 19:35:00 +02:00
Lennart Poettering 9f20fc28f0 socket-util: add new sockaddr_un_unlink() helper 
The helper is supposed to properly handle cases where .sun_path does not
contain a NUL byte, and thus copies out the path suffix a NUL as
necessary.

This also reworks the more specific socket_address_unlink() to be a
wrapper around the more generic sockaddr_un_unlink()
 2018-10-15 19:35:00 +02:00
Lennart Poettering 242c41b850 alloc-util: add alloca() counterparts for memdup() and memdup_suffix0() 2018-10-15 19:35:00 +02:00
Zbigniew Jędrzejewski-Szmek 4348c847cc Merge pull request #10373 from poettering/systemd-io 
adopt systemd.io urls
 2018-10-15 15:39:05 +02:00
Yu Watanabe 6cc4d59b35 Merge pull request #10392 from poettering/manager-no-inotify-fail 
make sure /etc/localtime issues don't cause systemd to fail boot
 2018-10-15 07:15:12 +09:00
Ben Boeckel bbe27ae448 man/systemd.nspawn: fix reference to --timezone argument (#10403) 2018-10-15 06:16:43 +09:00
Lennart Poettering ca193035e9 Merge pull request #10394 from yuwata/fixes-found-by-clang 
Fix warnings reported by clang
 2018-10-14 20:11:19 +02:00
Yu Watanabe e7aa9512e4 udev: use readlink_malloc() or its friend 
Follow-up for a2554acec6 and
7006860271.
 2018-10-14 19:59:49 +02:00
Yu Watanabe 18094bdcf4 Merge pull request #10381 from poettering/coverity-fixes 
fixes for various recent coverity issues
 2018-10-14 18:58:36 +09:00
Yu Watanabe 40990eac27 test: use fabsl instead of fabs as json_variant_real() returns 'long double' 2018-10-14 03:29:43 +09:00
Yu Watanabe 172e4806dd busctl: drop unused variable 2018-10-14 03:29:43 +09:00
Yu Watanabe cb16b085c0 core: set _unused_ attribute to 'reloading' 
Follow-up for 4df7d537c8.
 2018-10-13 23:50:04 +09:00
Lennart Poettering ea5c5f680d core: ensure it's not fatal if we cannot watch /etc/localtime 
See: #9602
 2018-10-13 15:13:07 +02:00
Lennart Poettering 0cb21d8c60 core: add debug logging if we cant watch /etc/localtime itself 2018-10-13 15:12:58 +02:00
Lennart Poettering ee7b9f1dfc format-table: don't use unsigned when there's no point in it 
CID 1394372
 2018-10-13 12:37:13 +02:00
Lennart Poettering c504106c35 journal-upload: check for overflow 
CID 1394386
 2018-10-13 12:37:13 +02:00
Lennart Poettering 0b2c35b812 wait-online: more voidifyin of sd_event_add_signal() 
CID 1394444
 2018-10-13 12:37:13 +02:00
Lennart Poettering db2d75dfbb machinectl: voidify calls to sd_event_add_signal() 
CID 1394445
 2018-10-13 12:37:13 +02:00
Lennart Poettering babdf0d315 udevadm: assert_se() around sigprocmask() 
CID #1395708
 2018-10-13 12:37:13 +02:00
Lennart Poettering 9db296fddd efivars: add missing OOM check 
CID #1395833
 2018-10-13 12:37:13 +02:00
Lennart Poettering 165ad41b7f sd-ndisc: change return value of ndisc_reset() to void 
We never generate anything other than 0 anyway, and we never check it,
hence let's just simplify things.
 2018-10-13 12:37:13 +02:00
Lennart Poettering 76f713dfa4 sd-ndisc: voidify sd_ndisc_stop() call 
CID 1395839
 2018-10-13 12:37:13 +02:00
Lennart Poettering fcadf032c0 json: fix memleak on OOM 
CID 1396083
 2018-10-13 12:37:13 +02:00
Lennart Poettering 913c898ca0 cgroup: voidify a few things 2018-10-13 12:37:13 +02:00
Lennart Poettering b9839ac9d9 cgroup: make sure whitelist_device() always returns a valid return value 
CID 1396094
 2018-10-13 12:37:13 +02:00
Lennart Poettering 48440643f7 journal: voidify fd_nonblock() 
CID #1396098
CID #1396096
CID #1396091
CID #1396086
 2018-10-13 12:37:13 +02:00
Yu Watanabe fd8879498d Revert "alloc-util: return NULL if 0-sized allocation is requested" 
This reverts commit c05107767b.
 2018-10-13 12:34:32 +02:00
Lucas Werkmeister d5bf4f9b8f man: systemctl: clarify that --lines=0 is allowed (#10375) 
The term “positive” is often read to exclude 0 (though “strictly
positive” is sometimes used to clarify this), so let’s explicitly state
that --lines=0 is legal and completely disables journal output.

Motivated by an answer on StackExchange [1].

[1]: https://unix.stackexchange.com/a/475068/44049
 2018-10-13 17:31:40 +09:00
Yu Watanabe 8837715ef2 Merge pull request #10371 from poettering/sd-event-man-fix 
trivial sd-event man page fixes
 2018-10-13 17:30:44 +09:00
Jason A. Donenfeld 7d0b26a027 networkd: fix attribute length for wireguard (#10380) 
This is actually a u16, not a u32, so the kernel complains:

kernel: netlink: 'systemd-network': attribute type 5 has an invalid length

This is due to:

if (nla_attr_len[pt->type] && attrlen != nla_attr_len[pt->type]) {
        pr_warn_ratelimited("netlink: '%s': attribute type %d has an invalid length.\n",
                            current->comm, type);
}

Presumably this has been working fine in functionality on little-endian
systems, but nobody bothered to try on big-endian systems.

Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
 2018-10-13 17:28:49 +09:00
Davide Cavalca b75f0c69b3 shared: add %g, %G specifiers for group / gid (#10368) 2018-10-13 17:26:48 +09:00
Yu Watanabe b4b3649a94 Merge pull request #10366 from poettering/in-set-fixes 
IN_SET() compile time check fixes
 2018-10-13 17:25:36 +09:00
Lennart Poettering a6ee956610 Merge pull request #10356 from dtardon/covscan 
assorted coverity/clang fixes
 2018-10-12 18:43:04 +02:00
Lennart Poettering 1f6f77a5fb Merge pull request #10379 from jwrdegoede/hwdb-updates 
Hwdb updates
 2018-10-12 18:21:15 +02:00