Jan Janssen
2b0af8e76a
boot: Mark memcmp/memcpy/memset aliases as used
...
The compiler may emit calls to these but also optimize the function away
somehow, breaking at link stage. Marking them as used prevents this.
2022-06-10 15:54:02 +02:00
Jan Janssen
f23b2a04e6
efi-string: Remove one more |= for bool
...
This one was missed in #23589 .
2022-06-10 14:14:57 +02:00
James Hilliard
76abad4d47
meson: add experimental bpf-gcc compiler support
...
Not fully working but should make it easier to clean up remaining
issues.
2022-06-10 14:01:19 +02:00
Jan Janssen
153381952b
boot: Use parse_number16 for boot counter parsing
2022-06-10 11:50:13 +02:00
Jan Janssen
1621ab4600
boot: Drop use of Atoi
2022-06-10 11:50:13 +02:00
Jan Janssen
72bd3458e5
boot: Add parse_number8/16
2022-06-10 11:50:13 +02:00
Yu Watanabe
3284dd9159
test: exclude network interfaces
...
After https://github.com/systemd/systemd-centos-ci/pull/492 is merged,
the networkd test may be running when test-sd-device is invoked.
Let's exclude net subsystem.
2022-06-10 18:44:21 +09:00
Yu Watanabe
f9e090b16d
test: always exclude devices named loop*
...
Not only block subsystem, but also misc has device named "loop*", and
the test always said that the following device is newly found:
---
/* test_sd_device_enumerator_filter_subsystem */
New device found: subsystem:misc syspath:/sys/devices/virtual/misc/loop-control
1 new devices are found in re-scan
---
2022-06-10 15:36:21 +09:00
Yu Watanabe
da5fb1877d
boot/efi-string: check the end of haystack before testing remaining pattern
...
Fixes buffer-overflow reported at https://github.com/systemd/systemd/pull/23589#issuecomment-1151820341 .
2022-06-10 12:05:38 +09:00
Yu Watanabe
c07eb49aff
devnode-acl: use set_put_strdup_full() and set_ensure_consume()
2022-06-10 10:47:25 +09:00
Yu Watanabe
47484dd955
dns-domain: simplify code a bit
2022-06-10 09:49:07 +09:00
Yu Watanabe
8d896617b4
dns-domain: use dns_name_concat()
...
`dns_name_normalize()` is an alias of `dns_name_concat()`.
For consistency with `dns_name_is_valid_ldh()`, let's use
`dns_name_concat()`.
2022-06-10 09:42:33 +09:00
Yu Watanabe
8bf796eeac
Merge pull request #23589 from medhefgo/efi-clang
...
boot: Drop use of several gnu-efi functions
2022-06-10 08:54:48 +09:00
i-do-cpp
67225a96e5
fix: sd_id128_get_invocation now works for user services
2022-06-10 08:28:37 +09:00
Yu Watanabe
74223cbe14
tree-wide: fix typo
2022-06-10 08:26:08 +09:00
Frantisek Sumsal
894dad2975
test: account for ADDR_NO_RANDOMIZE if it's set
...
On ppc64le sanitizers disable ASLR (i.e. by setting ADDR_NO_RANDOMIZE),
which opinionated_personality() doesn't return. Let's tweak the current
personality ourselves in such cases.
See: https://github.com/llvm/llvm-project/commit/78f7a6eaa601bfdd6ae70ffd3da2254c21ff77f9
Resolves : #23666
2022-06-10 05:34:01 +09:00
Yu Watanabe
677ec2d609
Merge pull request #23348 from medhefgo/log-shutdown-blockers
...
shutdown: Log processes that block umount
2022-06-10 05:33:37 +09:00
Luca Boccassi
9c3e2a2a97
Merge pull request #23658 from keszybz/gcc-warnings-2
...
Fixes for NULL-pointer arguments based on gcc warnings
2022-06-09 17:48:09 +01:00
James Hilliard
9b948bc062
bpf: use __always_inline macro in restrict-ifaces.bpf.c
...
This appears to be more reliable at inlining with some compilers.
2022-06-09 17:45:11 +01:00
Jan Janssen
df48b430a4
shutdown: Lazy unmount /oldroot/{dev,proc,sys}
...
These should not prevent us from cleaning up the remainders of /oldroot
if something in the kernel is blocking these from being unmounted.
2022-06-09 17:02:50 +02:00
Jan Janssen
20596876e3
shutdown: Log processes that block umount
2022-06-09 17:00:46 +02:00
Jan Janssen
5125b67742
shutdown: Rename umount_log_level and make it a bool
...
This was already effectively a bool because only ever two states were
valid. To make the meaning of it more clear, also rename it to last_try.
2022-06-09 16:50:54 +02:00
Zbigniew Jędrzejewski-Szmek
c4da8e90fa
systemctl: simplify code a bit
...
gcc insists that bus may be used unitialized here, but I don't see any
possibility of that.
2022-06-09 13:25:17 +02:00
Zbigniew Jędrzejewski-Szmek
c90821aa49
shared/bus-util: rename variables to follow newer style
2022-06-09 13:25:17 +02:00
Zbigniew Jędrzejewski-Szmek
73e910926e
shared/bus-util: simplification
2022-06-09 13:25:17 +02:00
Zbigniew Jędrzejewski-Szmek
482dac9431
test-udev-util: do not pass NULL to printf, style fixes
2022-06-09 13:25:17 +02:00
Zbigniew Jędrzejewski-Szmek
fa1aa468b9
test-process-util: do not pass NULL to printf, simplify tests
...
We don't need to fork to test that the function returns -EINVAL
on null input. So let's simplify things a bit.
2022-06-09 13:25:17 +02:00
Zbigniew Jędrzejewski-Szmek
e9edf285db
test-dns-domain: a few more "NULL in printf %s"s
2022-06-09 13:25:17 +02:00
Zbigniew Jędrzejewski-Szmek
d10cee5e90
test-fstab-util: one more "NULL in printf %s"
2022-06-09 13:25:17 +02:00
Zbigniew Jędrzejewski-Szmek
8b98cfb7dd
various: indentation
2022-06-09 13:25:17 +02:00
Zbigniew Jędrzejewski-Szmek
a78af10ae7
Merge pull request #23654 from keszybz/gcc-warnings
...
Fixes for NULL-pointer arguments based on gcc warnings
2022-06-09 12:55:47 +02:00
Jan Janssen
55233913c8
boot: Drop use of DuplicateDevicePath
2022-06-09 12:50:13 +02:00
Jan Janssen
e17fd5538f
boot: Don't copy device path
...
BS->LocateDevicePath only advances the passed device path pointer.
It does not actually modify it, so there is no need to make a copy.
2022-06-09 12:50:13 +02:00
Jan Janssen
b05d69ed72
boot: Drop use of LibLocateHandle
2022-06-09 12:50:13 +02:00
Jan Janssen
b04f818417
boot: Drop use of UnpackDevicePath
...
Device paths are a packed data structure and the UEFI spec is clear that
members may be misaligned.
In this case all accesses are aligned except for the signature. We can
simply memcpy it instead of making a whole (aligned) copy of the device
path.
2022-06-09 12:50:13 +02:00
Jan Janssen
79a2b916a0
boot: Drop use of FileDevicePath
2022-06-09 12:50:13 +02:00
Jan Janssen
0af26643d0
boot: Use xmalloc
...
This drops the unused xnew0 and xallocate_zero_pool as there is only two
users of it. _cleanup_freepool_ will be phased out once the types in the
declarations are changed/renamed.
2022-06-09 12:50:13 +02:00
Jan Janssen
9148312fab
boot: Add xmalloc
2022-06-09 12:50:13 +02:00
Jan Janssen
5594ebee99
boot: Drop use of DevicePathFromHandle
2022-06-09 12:50:13 +02:00
Jan Janssen
6a261332bc
boot: Drop use of LibLocateProtocol
2022-06-09 12:50:13 +02:00
Jan Janssen
f747ca3ec3
boot: Drop use of LibOpenRoot
2022-06-09 12:50:13 +02:00
Jan Janssen
7ebce8145e
boot: Drop use of LibGetSystemConfigurationTable
2022-06-09 12:50:13 +02:00
Jan Janssen
23742af522
boot: Drop use of MetaiMatch
...
A future commit will add support for unicode collation protocol that
allows case folding and comparing strings with locale awareness. But it
only operates on whole strings, so fnmatch cannot use those without a
heavy cost. Instead we just case fold the patterns instead (the IDs we
try to match are already lower case).
2022-06-09 12:50:13 +02:00
Jan Janssen
0e8ecba96e
boot: Add efi_fnmatch
...
Unlike MetaiMatch from the UEFI spec/EDK2 this implementation is
intended to be compatible with POSIX fnmatch.
2022-06-09 12:50:08 +02:00
Zbigniew Jędrzejewski-Szmek
2299b1cae3
Resolve conflicts between #23616 and the recent NFT additions
2022-06-09 10:06:30 +02:00
Yu Watanabe
377157e6bd
Merge pull request #23616 from keszybz/in-addr-to-string-formatting
...
Add macros that allocate a fixed buffer for in_addr_to_string(), in_addr_prefix+to_string()
2022-06-09 15:21:57 +09:00
Zbigniew Jędrzejewski-Szmek
e0d537950b
test-load-fragment: don't print NULLs
2022-06-09 07:53:06 +02:00
Zbigniew Jędrzejewski-Szmek
817d19402f
test-bus-address: silence gcc warning about NULL arg to strcmp()
...
The code was overly complicated… We know what value we expect, we can test it
directly.
2022-06-09 07:53:06 +02:00
Zbigniew Jędrzejewski-Szmek
1b3502b072
test-mountpoint-util: fix NULL arg to %s
2022-06-09 07:53:06 +02:00
Zbigniew Jędrzejewski-Szmek
abcdc02cd0
sd-journal: inline variable declarations
2022-06-09 07:53:06 +02:00