Ted X. Toth
29dbc62d74
Use target process context to set socket context when using SELinuxContextFromNet not systemd's context. Currently when using the SELinuxContextFromNet option for a socket activated services, systemd calls getcon_raw which returns init_t and uses the resulting context to compute the context to be passed to the setsockcreatecon call. A socket of type init_t is created and listened on and this means that SELinux policy cannot be written to control which processes (SELinux types) can connect to the socket since the ref policy allows all 'types' to connect to sockets of the type init_t. When security accessors see that any process can connect to a socket this raises serious concerns. I have spoken with SELinux contributors in person and on the mailing list and the consensus is that the best solution is to use the target executables context when computing the sockets context in all cases. [zjs review/comment: This removes the branch that was added in16115b0a7b.16115b0a7bdid two things: it had the branch here in 'socket_determine_selinux_label()' and a code in 'exec_child()' to call 'label_get_child_mls_label(socket_fd, command->path, &label)'. Before this patch, the flow was: ''' mac_selinux_get_child_mls_label: peercon = getpeercon_raw(socket_fd); if (!exec_label) exec_label = getfilecon_raw(exe); socket_open_fds: if (params->selinux_context_net) # label = mac_selinux_get_our_label(); # this part is removed else # label = mac_selinux_get_create_label_from_exe(path); socket_address_listen_in_cgroup(s, &p->address, label); exec_child(): exec_context = mac_selinux_get_child_mls_label(fd, executable, context->selinux_context); setexeccon(exec_context); ''' ]
System and Service Manager
Details
Most documentation is available on systemd's web site.
Assorted, older, general information about systemd can be found in the systemd Wiki.
Information about build requirements is provided in the README file.
Consult our NEWS file for information about what's new in the most recent systemd versions.
Please see the Code Map for information about this repository's layout and content.
Please see the Hacking guide for information on how to hack on systemd and test your modifications.
Please see our Contribution Guidelines for more information about filing GitHub Issues and posting GitHub Pull Requests.
When preparing patches for systemd, please follow our Coding Style Guidelines.
If you are looking for support, please contact our mailing list or join our IRC channel.
Stable branches with backported patches are available in the stable repo.