Zbigniew Jędrzejewski-Szmek
64eb78135c
The immediate impulse for this change is the fedora scriptlet which called: /usr/lib/systemd/systemd-update-helper install-system-units cryptsetup-pre.target cryptsetup.target getty@.service ... system-systemd\x2dcryptsetup.slice system-systemd\x2dveritysetup.slice ... which called systemctl preset cryptsetup-pre.target cryptsetup.target getty@.service ... system-systemd\x2dcryptsetup.slice system-systemd\x2dveritysetup.slice ... which threw an error that system-systemdx2dcryptsetup.slice does not exist and did nothing at all. (The backslash is consumed by the shell.) The obvious fix here is to figure out more levels of escaping… But we should do something more robust in such cases. If we fail in processing of a single unit, let preset all continue processing units, report the failure through 'changes'. At the end, return failure. In general, for operations which operate on a list of units specified by the user, fail the whole operation if any of the individual operations failed. The only operation where we don't do this is 'preset-all'. $ SYSTEMD_LOG_LEVEL=debug build/systemctl --root=/ preset asdf1.servie asdf2.path; echo $? Cannot find unit asdf1.servie.service. Cannot find unit asdf2.path. Failed to preset unit: Unit asdf1.servie.service does not exist Failed to preset unit: Unit asdf2.path does not exist 1 While at it, fix double logging in the manager: dump_unit_changes() already logs about errors, so the manager should only log on success.
System and Service Manager
Details
Most documentation is available on systemd's web site.
Assorted, older, general information about systemd can be found in the systemd Wiki.
Information about build requirements is provided in the README file.
Consult our NEWS file for information about what's new in the most recent systemd versions.
Please see the Code Map for information about this repository's layout and content.
Please see the Hacking guide for information on how to hack on systemd and test your modifications.
Please see our Contribution Guidelines for more information about filing GitHub Issues and posting GitHub Pull Requests.
When preparing patches for systemd, please follow our Coding Style Guidelines.
If you are looking for support, please contact our mailing list, join our IRC channel #systemd on libera.chat or Matrix channel
Stable branches with backported patches are available in the stable repo.
We have a security bug bounty program sponsored by the Sovereign Tech Fund hosted on YesWeHack
Repositories with distribution packages built from git main are available on OBS