Stefan Hansson
b1236ce38b
On musl, O_ACCMODE is defined as (03|O_SEARCH), unlike glibc which defines it as (O_RDONLY|O_WRONLY|O_RDWR). Additionally, O_SEARCH is simply defined as O_PATH. This causes problems for systemd on musl, as it changes the behaviour of open_mkdir_at_full() to return -EINVAL if O_PATH is included in flags due to the fact that O_ACCMODE includes O_SEARCH (i.e. O_PATH). Consequently, this makes the test-fs-util test fail. Upstream musl seems content with this behaviour and doesn't seem interested in matching glibc's behaviour due to that defining it this way allows for O_SEARCH to match POSIX better by allowing it to open directories where read permission is missing. Apparently musl does some emulation in other places to make this work more consistently as well. Initially I took the approach of working around this by redefining O_SEARCH as O_RDONLY if O_SEARCH == O_PATH. This fixes the test and is the approach taken by both XZ[1] and Gzip[2][3], but was not taken as redefining system headers potentially could be problematic. Instead, introduce O_ACCMODE_STRICT which just is a copy of glibc's O_ACCMODE and use it everywhere. This way we don't have to deal with unusual definitions of O_ACCMODE from C standard libraries other than glibc. [1]: https://git.tukaani.org/?p=xz.git;a=blob;f=src/xz/file_io.c;h=8c83269b13fa31284f7ea5f3627a1dfbce7d6e14;hb=HEAD#l72 [2]: https://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/fcntl.in.h (lines 380 and 396, commit d7f551b30f3f2a0fa57c1b10c12f4eea41a9b89e) [3]: https://lists.gnu.org/archive/html/bug-gzip/2025-01/msg00000.html
System and Service Manager
Details
Most documentation is available on systemd's web site.
Assorted, older, general information about systemd can be found in the systemd Wiki.
Information about build requirements is provided in the README file.
Consult our NEWS file for information about what's new in the most recent systemd versions.
Please see the Code Map for information about this repository's layout and content.
Please see the Hacking guide for information on how to hack on systemd and test your modifications.
Please see our Contribution Guidelines for more information about filing GitHub Issues and posting GitHub Pull Requests.
When preparing patches for systemd, please follow our Coding Style Guidelines.
If you are looking for support, please contact our mailing list, join our IRC channel #systemd on libera.chat or Matrix channel
Stable branches with backported patches are available in the stable repo.
We have a security bug bounty program sponsored by the Sovereign Tech Fund hosted on YesWeHack
Repositories with distribution packages built from git main are available on OBS