Daan De Meyer
e530ef6761
Without CAP_SYS_ADMIN, btrfs_ioctl_snap_destroy() runs an inode_permission(MAY_WRITE) check against the target subvolume root, which btrfs_permission() rejects with EROFS for a read-only subvolume. As a result, unprivileged removal of a read-only subvolume fails — both via btrfs_subvol_remove_at() directly and via the recursive cleanup path used by rm_rf_subvolume_and_freep(), which propagates the EROFS up. Detect EROFS after the destroy ioctl, clear the RDONLY flag (only inode ownership is required for BTRFS_IOC_SUBVOL_SETFLAGS), and retry once. While at it, fix the surrounding comments: BTRFS_IOC_SNAP_DESTROY drops the entire subvolume tree, so regular files inside are irrelevant; ENOTEMPTY from the ioctl indicates nested subvolumes (BTRFS_ROOT_REF_KEY entries) via may_destroy_subvol(), not non-empty contents.
System and Service Manager
Details
Most documentation is available on systemd's web site.
Assorted, older, general information about systemd can be found in the systemd Wiki.
Information about build requirements is provided in the README file.
Consult our NEWS file for information about what's new in the most recent systemd versions.
Please see the Code Map for information about this repository's layout and content.
Please see the Hacking guide for information on how to hack on systemd and test your modifications.
Please see our Contribution Guidelines for more information about filing GitHub Issues and posting GitHub Pull Requests.
When preparing patches for systemd, please follow our Coding Style Guidelines.
If you are looking for support, please contact our mailing list, join our IRC channel #systemd on libera.chat or Matrix channel
Stable branches with backported patches are available in the stable repo.
We have a security bug bounty program sponsored by the Sovereign Tech Fund hosted on YesWeHack
Repositories with distribution packages built from git main are available on OBS, and also repositories with packages built from the latest stable release