Joe Richey
f8e54bf319
This PR reverts #4302 and part of #7568, as the call to GetEventLog isn't necessary to get the logs from the OS runtime. This has already been reverted in shim, see: https://github.com/rhboot/shim/commit/fd7c3bd920ba39082cb7c619afb7203d150a4cd3 The reasoning for the change that added this is wrong, explained below: > According to TCG EFI Protocol Specification for TPM 2.0 family, > all events generated after the invocation of EFI_TCG2_GET_EVENT_LOG > shall be stored in an instance of an EFI_CONFIGURATION_TABLE aka > EFI TCG 2.0 final events table. This is correct and a valid reading of the TCG spec. > Hence, it is necessary to trigger the internal switch through calling > get_event_log() in order to allow to retrieve the logs from OS runtime. However, this reasoning is incorrect. The "EFI TCG 2.0 final events table" exists to allow the OS Runtime to get TCG events created during or after the call to ExitBootServices. If systemd-boot didn't call trigger_tcg2_final_events_table(), the call to HashLogExtendEvent will write the event to the normal events table (i.e. the same place the PCR 0 - 7 related events are written). Then the OS can obtain these systemd-boot events in the same way it obtains normal events, via a call to GetEventLog(). Tested on amd64 w/ TPM2 using the newest Linux kernel patches that get the TPM2 formatted log: https://www.lkml.org/lkml/2019/5/20/1590 I confirmed that this change still lets the OS runtime obtain the log entries created by systemd-boot. Signed-off-by: Joe Richey <joerichey@google.com>
systemd - System and Service Manager
Details
General information about systemd can be found in the systemd Wiki.
Information about build requirements is provided in the README file.
Consult our NEWS file for information about what's new in the most recent systemd versions.
Please see the Hacking guide for information on how to hack on systemd and test your modifications.
Please see our Contribution Guidelines for more information about filing GitHub Issues and posting GitHub Pull Requests.
When preparing patches for systemd, please follow our Coding Style Guidelines.
If you are looking for support, please contact our mailing list or join our IRC channel.
Stable branches with backported patches are available in the stable repo.