SymbX/ModemManager
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

broadband-bearer: no need for explicit flow control cleanup on disconnect

Browse Source 
We're already configuring the flow control we expect when running
mm_port_serial_reopen(), which will keep the udev-selected flow
control or will otherwise reset to no flow control when the TTY is in
command mode.
This commit is contained in:
Aleksander Morgado
2018-09-12 17:15:46 +00:00
committed by Dan Williams
parent a19be8952f
commit 727567cf58
1 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mm-broadband-bearer.c
-20
View File
@@ -1418,16 +1418,6 @@ data_flash_cdma_ready (MMPortSerial *data,
mm_port_serial_flash_finish (data, res, &error);
/* Cleanup flow control */
if (self->priv->flow_control != MM_FLOW_CONTROL_NONE) {
GError *flow_control_error = NULL;
if (!mm_port_serial_set_flow_control (MM_PORT_SERIAL (data), MM_FLOW_CONTROL_NONE, &flow_control_error)) {
mm_dbg ("Couldn't reset flow control settings: %s", flow_control_error->message);
g_clear_error (&flow_control_error);
}
}
/* We kept the serial port open during connection, now we close that open
* count */
mm_port_serial_close (data);
@@ -1560,16 +1550,6 @@ data_flash_3gpp_ready (MMPortSerial *data,
mm_port_serial_flash_finish (data, res, &error);
/* Cleanup flow control */
if (self->priv->flow_control != MM_FLOW_CONTROL_NONE) {
GError *flow_control_error = NULL;
if (!mm_port_serial_set_flow_control (MM_PORT_SERIAL (data), MM_FLOW_CONTROL_NONE, &flow_control_error)) {
mm_dbg ("Couldn't reset flow control settings: %s", flow_control_error->message);
g_clear_error (&flow_control_error);
}
}
/* We kept the serial port open during connection, now we close that open
* count */
mm_port_serial_close (data);