SymbX/systemd
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
57,095 Commits 2 Branches 1 Tag
58270534bf5da170ad75b5b41244cd7e761cf660
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Daniel Mack e50e60b474 .gitignore: ignore precompiled GCC headers (#4516) 
Not sure since when this is the default behavior, but my local tree is full
of such files. Let's ignore them for clarity.
 2016-10-28 13:03:01 -04:00
Daniel Mack 94fce754b1 Merge pull request #4455 from endocode/dongsu/l10n-catalog-korean 
catalog: add more Korean translations
 2016-10-22 20:01:02 +02:00
Daniel Mack 5138a901b1 Merge pull request #4447 from poettering/oneshotassertfix 
core: if the start command vanishes during runtime don't hit an assert
 2016-10-21 16:22:15 +02:00
Daniel Mack d02b5af3f3 Merge pull request #4363 from stefan-it/replace-while-loops 
basic,coredump: use for loop instead of while
 2016-10-13 15:56:23 +02:00
Daniel Mack c5a6157b4a Merge pull request #4364 from phomes/man-fixes 
man: typo fixes
 2016-10-13 15:55:40 +02:00
Daniel Mack 29272d9e03 Merge pull request #4084 from ssahani/netfix 
fix #4080
 2016-09-02 22:08:18 +02:00
Daniel Mack d909beef0a Merge pull request #3746 from keszybz/trivial-fixes 
Trivial fixes
 2016-07-18 09:54:06 +02:00
Daniel Mack a34349e733 network-ndisc: avoid VLAs (#3725) 
Do not allocate objects of dynamic and potentially large size on the stack
to avoid both clang compilation errors and unpredictable runtime behavior
on exotic platforms. Use the heap for that instead.

While at it, refactor the code a bit. Access 's->domain' via
NDISC_DNSSL_DOMAIN(), and refrain from allocating 'x' independently, but
rather reuse 's' if we're dealing with a new entry to the set.

Fixes #3717
 2016-07-14 22:56:11 -04:00
Daniel Mack 78a4ee591a cgroup: fix memory cgroup limit regression on kernel 3.10 (#3673) 
Commit da4d897e ("core: add cgroup memory controller support on the unified
hierarchy (#3315)") changed the code in src/core/cgroup.c to always write
the real numeric value from the cgroup parameters to the
"memory.limit_in_bytes" attribute file.

For parameters set to CGROUP_LIMIT_MAX, this results in the string
"18446744073709551615" being written into that file, which is UINT64_MAX.
Before that commit, CGROUP_LIMIT_MAX was special-cased to the string "-1".

This causes a regression on CentOS 7, which is based on kernel 3.10, as the
value is interpreted as *signed* 64 bit, and clamped to 0:

[root@n54 ~]# echo 18446744073709551615 >/sys/fs/cgroup/memory/user.slice/memory.limit_in_bytes
[root@n54 ~]# cat /sys/fs/cgroup/memory/user.slice/memory.limit_in_bytes
0

[root@n54 ~]# echo -1 >/sys/fs/cgroup/memory/user.slice/memory.limit_in_bytes
[root@n54 ~]# cat /sys/fs/cgroup/memory/user.slice/memory.limit_in_bytes
9223372036854775807

Hence, all units that are subject to the limits enforced by the memory
controller will crash immediately, even though they have no actual limit
set. This happens to for the user.slice, for instance:

[  453.577153] Hardware name: SeaMicro SM15000-64-CC-AA-1Ox1/AMD Server CRB, BIOS Estoc.3.72.19.0018 08/19/2014
[  453.587024]  ffff880810c56780 00000000aae9501f ffff880813d7fcd0 ffffffff816360fc
[  453.594544]  ffff880813d7fd60 ffffffff8163109c ffff88080ffc5000 ffff880813d7fd28
[  453.602120]  ffffffff00000202 fffeefff00000000 0000000000000001 ffff880810c56c03
[  453.609680] Call Trace:
[  453.612156]  [<ffffffff816360fc>] dump_stack+0x19/0x1b
[  453.617324]  [<ffffffff8163109c>] dump_header+0x8e/0x214
[  453.622671]  [<ffffffff8116d20e>] oom_kill_process+0x24e/0x3b0
[  453.628559]  [<ffffffff81088dae>] ? has_capability_noaudit+0x1e/0x30
[  453.634969]  [<ffffffff811d4155>] mem_cgroup_oom_synchronize+0x575/0x5a0
[  453.641721]  [<ffffffff811d3520>] ? mem_cgroup_charge_common+0xc0/0xc0
[  453.648299]  [<ffffffff8116da84>] pagefault_out_of_memory+0x14/0x90
[  453.654621]  [<ffffffff8162f4cc>] mm_fault_error+0x68/0x12b
[  453.660233]  [<ffffffff81642012>] __do_page_fault+0x3e2/0x450
[  453.666017]  [<ffffffff816420a3>] do_page_fault+0x23/0x80
[  453.671467]  [<ffffffff8163e308>] page_fault+0x28/0x30
[  453.676656] Task in /user.slice/user-0.slice/user@0.service killed as a result of limit of /user.slice/user-0.slice/user@0.service
[  453.688477] memory: usage 0kB, limit 0kB, failcnt 7
[  453.693391] memory+swap: usage 0kB, limit 9007199254740991kB, failcnt 0
[  453.700039] kmem: usage 0kB, limit 9007199254740991kB, failcnt 0
[  453.706076] Memory cgroup stats for /user.slice/user-0.slice/user@0.service: cache:0KB rss:0KB rss_huge:0KB mapped_file:0KB swap:0KB inactive_anon:0KB active_anon:0KB inactive_file:0KB active_file:0KB unevictable:0KB
[  453.725702] [ pid ]   uid  tgid total_vm      rss nr_ptes swapents oom_score_adj name
[  453.733614] [ 2837]     0  2837    11950      899      23        0             0 (systemd)
[  453.741919] Memory cgroup out of memory: Kill process 2837 ((systemd)) score 1 or sacrifice child
[  453.750831] Killed process 2837 ((systemd)) total-vm:47800kB, anon-rss:3188kB, file-rss:408kB

Fix this issue by special-casing the UINT64_MAX case again.
 2016-07-07 19:29:35 -07:00
Daniel Mack 79c954405f basic: log: Increase static buffer for source file location (#3674) 
Commit d054f0a4 ("tree-wide: use xsprintf() where applicable") used a
semantic patch approach to change a number of locations from

  snprintf(buf, sizeof(buf), FMT, ...)

to

  xsprintf(buf, FMT, ...)

The problem is that xsprintf() wraps the snprintf() in an
assert_message_se(), so if snprintf() reports an overflow of the
destination buffer, the binary will now terminate.

This hit a user running a version of systemd that was built from a
deeply nested system path.

Fix this by

a) Switching back to snprintf() for this particular case. We should really
rather truncate the location string than crash in such situations.

b) Increasing the size of that static string buffer, to make the event more
unlikely.
 2016-07-07 07:30:34 +03:00
Daniel Mack 91bb59b4b1 Merge pull request #3527 from poettering/systemctl-fixes 
Systemctl fixes
 2016-06-14 14:25:43 +02:00
Daniel Mack d57a7ed5ea Merge pull request #3036 from evverx/add-ldl 
build-sys: add missing -ldl
 2016-04-14 18:13:34 +02:00
Daniel Mack d29030e593 Merge pull request #3029 from ipuustin/supplementary-gids 
sd-bus: query pid also when requesting supplementary gids information
 2016-04-14 10:41:27 +02:00
Daniel Mack 97607e1ef9 Merge pull request #2919 from ColdPie1/udev_get_parent_docs 
man: Fix documented parameters for udev_device_get_ functions
 2016-03-30 18:58:12 +02:00
Daniel Mack a9447e0e48 Merge pull request #2911 from evverx/shutdown-watchdog-infinity 
core: ShutdownWatchdogSec=infinity disables the watchdog logic too
 2016-03-29 16:06:30 +02:00
Daniel Mack 9081e5abab Merge pull request #2907 from evverx/runtime-watchdog-infinity 
core: RuntimeWatchdogSec=infinity disables the watchdog logic
 2016-03-29 10:35:52 +02:00
Daniel Mack 86a4231553 Merge pull request #2905 from keszybz/gcrypt-compilation 
build-sys: fix build with libgrcypt disabled
 2016-03-29 10:35:07 +02:00
Daniel Mack d8fd85e94f Merge pull request #2892 from yuwata/localectl 
localectl: remove an unnecessary line break from and align the output of status command
 2016-03-24 10:37:19 +01:00
Daniel Mack 1eb963a32d Merge pull request #2885 from gbrikis/master 
core: Fix path for opening ffs endpoint ep0
 2016-03-23 19:48:26 +01:00
Daniel Mack 3288dcd390 Merge pull request #2888 from kinvolk/iaguis/remove-dots 
run: remove period when printing started units
 2016-03-23 18:06:07 +01:00
Daniel Mack 15cb891e15 Merge pull request #2886 from fbuihuu/systemctl-list-units-inactive-state 
systemctl: no need to pass --all if inactive is explicitly requested …
 2016-03-23 13:08:04 +01:00
Daniel Mack 51359d02d1 Merge pull request #2883 from keszybz/allow-boms 
Ignore BOM in config files
 2016-03-23 13:00:33 +01:00
Daniel Mack 99d91109a6 Merge pull request #2880 from keszybz/more-tests 
Add some simple tests for env_value_is_valid and env_assignment_is_valid
 2016-03-22 10:23:12 +01:00
Daniel Mack e31512b1c9 Merge pull request #2878 from martinpitt/master 
test-copy: use correct data type for max_bytes
 2016-03-21 16:47:31 +01:00
Daniel Mack 68de79d6a4 Merge pull request #2760 from ronnychevalier/rc/core_no_new_privileges_seccompv3 
core: set NoNewPrivileges for seccomp if we don't have CAP_SYS_ADMIN
 2016-03-21 12:57:43 +01:00
Daniel Mack 19180aadb5 Merge pull request #2826 from thom311/master 
lldp: fix starting ttl timer for lldp neighbor
 2016-03-21 12:44:38 +01:00
Daniel Mack 2d4122d4df Merge pull request #2875 from evverx/nspawn-template-bash-completion 
bash completion: add --template to nspawn
 2016-03-21 11:45:23 +01:00
Daniel Mack 9d74d73a4d Merge pull request #2865 from utezduyar/journald-upload 
journal-upload: remove microhttpd dependency
 2016-03-18 13:48:00 +01:00
Daniel Mack af6cd87d98 Merge pull request #2862 from evverx/nspawn-expose-ports-error 
nspawn: don't run nspawn --port=... without libiptc support
 2016-03-18 12:00:29 +01:00
Daniel Mack 5fec580c84 Merge pull request #2839 from keszybz/use-sendfile-smarter 
Use sendfile smarter
 2016-03-17 20:33:41 +01:00
Daniel Mack da9a4daa08 Merge pull request #2854 from keszybz/log-colors 
systemd: obey systemd.log_color config
 2016-03-17 20:30:16 +01:00
Daniel Mack 90e644608e Merge pull request #2856 from msekletar/merge-instance 
core: look for instance when processing template name
 2016-03-17 20:24:39 +01:00
Daniel Mack c31be17f6b Merge pull request #2848 from keszybz/clang-warnings 
Clang warnings
 2016-03-17 16:41:20 +01:00
Daniel Mack ca9bc74bd0 Merge pull request #2827 from keszybz/public-headers 
ANSI C compatibility for public headers
 2016-03-14 16:55:04 +01:00
Daniel Mack 5d331c192f Merge pull request #2821 from keszybz/mac_selinux_bind-do-not-rely-on-errno 
socket_address_listen: do not rely on errno (2)
 2016-03-10 17:37:40 +01:00
Daniel Mack bffac070d0 Merge pull request #2794 from jhol/dont-unmount-initramfs-mounts 
core/mount: Don't unmount initramfs mounts
 2016-03-10 15:24:21 +01:00
Daniel Mack 79c96fd204 Merge pull request #2820 from lnykryn/test-ipcrm 
test-ipcrm: fix log message
 2016-03-10 13:43:48 +01:00
Daniel Mack b5adc91a67 Merge pull request #2819 from bachradsusi/mac_selinux_bind-do-not-rely-on-errno 
socket_address_listen - do not rely on errno
 2016-03-10 13:31:59 +01:00
Daniel Mack 280d397ab3 Merge pull request #2768 from benjarobin/fix-2718 
systemctl: Replace check_one_unit() by get_state_one_unit()
 2016-03-07 14:50:08 +01:00
Daniel Mack 77f911c56b Merge pull request #2779 from 0xAX/openat-opath-excess-flags 
tree-wide: no need to pass excess flags to open()/openat() if O_PATH …
 2016-03-02 09:16:08 +01:00
Daniel Mack 2a0b102fd4 Merge pull request #2782 from AOSC-Dev/master 
po/zh_CN: attempt to refresh zh_CN translation
 2016-03-02 09:14:59 +01:00
Daniel Mack 114761866a Merge pull request #2773 from eliasp/type-warnings 
Use `PRIu64` to print `uint64_t` in log msgs
 2016-03-01 10:06:51 +01:00
Daniel Mack 96b08d65a1 Merge pull request #2722 from torstehu/fix-typo2 
treewide: fix typos and then/that use
 2016-02-24 15:51:34 +01:00
Daniel Mack 357726c8be Merge pull request #2687 from poettering/resolved-fix-2683 
networkd: make sure we allocate the NTA set before we add items to it
 2016-02-22 09:59:07 +01:00
Daniel Mack 2c0608a33d Merge pull request #2686 from poettering/github-templates 
add github issue template
 2016-02-22 09:58:23 +01:00
Daniel Mack 714c62b463 Merge pull request #2675 from samueltardieu/llmnr-typo 
Fix typo on systemd-resolved log message
 2016-02-20 12:27:48 +01:00
Daniel Mack 6f5ea43f9b Merge pull request #2668 from samueltardieu/systemd-resolve-manual-typo 
Fix typo in systemd-resolve man page
 2016-02-19 15:52:43 +01:00
Daniel Mack a972e1e0b3 Merge pull request #2661 from nwmcsween/nwmcsween 
Include and internal struct member fixes.
 2016-02-19 12:29:23 +01:00
Daniel Mack dfec18925e Merge pull request #2660 from keszybz/memleaks-and-ubsan 
Memleaks and ubsan
 2016-02-19 12:23:43 +01:00
Daniel Mack 22b73e9cd7 Merge pull request #2662 from keszybz/activate-setenv 
activate: fix -E option parsing
 2016-02-19 12:19:18 +01:00
Daniel Mack 251b4cb6a2 Merge pull request #2620 from bengal/assert-sd-event-now 
dhcp: assert the success of sd_event_now()
 2016-02-15 16:50:55 +01:00
Daniel Mack 3aa3d5d412 Merge pull request #2617 from rabinv/master 
missing.h: define IFLA_EXT_MASK
 2016-02-15 11:11:19 +01:00
Daniel Mack 71ab0faceb Merge pull request #2579 from evverx/TEST-1981 
tests: add test for https://github.com/systemd/systemd/issues/1981
 2016-02-11 10:22:25 +01:00
Daniel Mack 53359675fc Merge pull request #2578 from keszybz/man-pages 
man: follow up fixes for #2575
 2016-02-11 10:22:05 +01:00
Daniel Mack 3256faea2d Merge pull request #2571 from martinpitt/master 
NEWS: Various clarification and grammar fixes
 2016-02-10 13:57:37 +01:00
Daniel Mack 978d665086 Merge pull request #2564 from poettering/fix-2467 
Fix for #2467
 2016-02-10 13:39:48 +01:00
Daniel Mack 42caedb2aa Merge pull request #2568 from poettering/prepare-229 
edit config updates, and a new NEWS file
 2016-02-10 13:23:23 +01:00
Daniel Mack 14ddf4207f Merge pull request #2506 from poettering/resolved-and-more 
pid 1 fixes, resolved fixes, and more
 2016-02-02 17:32:31 +01:00
Daniel Mack 0e3a930a60 Merge pull request #2465 from poettering/systemctl-chroot 
Fix for #2015
 2016-01-29 16:04:03 +01:00
Daniel Mack e0d2df39b1 Merge pull request #2472 from poettering/mini-fixes 
Two mini fixes
 2016-01-29 15:51:16 +01:00
Daniel Mack 9e83569d8f Merge pull request #2463 from poettering/machined-tty-fix 
Fixes for the service TTY reset logic and other stuff
 2016-01-28 17:37:06 +01:00
Daniel Mack a110e31bda Merge pull request #2455 from keszybz/man-pages 
man: fix reference to an external man page
 2016-01-28 10:06:57 +01:00
Daniel Mack fdb4ee00f0 Merge pull request #2445 from poettering/various-fixes 
A number of fixes
 2016-01-27 13:35:18 +01:00
Daniel Mack d8fc78b40f Merge pull request #2436 from grawity/fix/tasks-max 
logind: update documentation for cf7d1a30e4
 2016-01-26 13:36:30 +01:00
Daniel Mack afb3e6335a Merge pull request #2434 from keszybz/man-pages 
Man pages
 2016-01-26 09:39:56 +01:00
Daniel Mack 709a7eb803 Merge pull request #2435 from evverx/tests-setup-selinux 
tests: add setup_selinux
 2016-01-26 09:12:38 +01:00
Daniel Mack 3a79e301e8 Merge pull request #2423 from keszybz/udevd-crash-in-cleanup 
udevd: do not clean up fds in main
 2016-01-24 15:09:33 +01:00
Daniel Mack 620b63ec02 Merge pull request #2405 from zonque/sysusers 
sysusers: use GID_FMT and UID_FMT instead of %d
 2016-01-22 09:59:23 +01:00
Daniel Mack efda7e594e Merge pull request #2331 from yuwata/journal-remote-unit-v2 
journal-remote: add SupplementaryGroups to systemd-journal-upload.service
 2016-01-22 09:56:54 +01:00
Daniel Mack e813475097 Merge pull request #2332 from yuwata/journal-remote-tmpfiles-v2 
journal-remote: tmpfiles.d/journal-remote.conf (v2)
 2016-01-22 09:51:43 +01:00
Daniel Mack 371859d6b5 Merge pull request #2080 from chaloulo/split-mode-host-remove-port-from-journal-filename 
journal-remote: split-mode=host, remove port from journal filename
 2016-01-22 09:47:59 +01:00
Daniel Mack 07313a1826 Merge pull request #2409 from snakeroot/dropin-doc-2 
man: describe precedence of drop-in .conf files over unit files
 2016-01-22 09:10:13 +01:00
Daniel Mack 808abf0969 Merge pull request #2411 from ssahani/activate4 
systemd-activate: Add support for datagram socket
 2016-01-22 09:06:20 +01:00
Daniel Mack e77435f2b0 Merge pull request #1359 from jengelh/ue 
sysusers: help useless error message
 2016-01-21 16:28:19 +01:00
Daniel Mack 390be1c86a Merge pull request #2071 from chaloulo/journal-upload-miss-logs 
journal-upload : Ignore journal event when already in uploading state.
 2016-01-21 16:23:46 +01:00
Daniel Mack 9f3fda90a3 Merge pull request #2393 from evverx/ignore-test-dnssec-complex 
.gitignore: add test-dnssec-complex
 2016-01-21 11:52:01 +01:00
Daniel Mack 127a45c36f Merge pull request #2371 from evverx/add-valgrind-helper-for-daemon-reexec 
core: add valgrind helper for daemon-reexec
 2016-01-21 11:51:37 +01:00
Daniel Mack 9ecbcdffdf Merge pull request #2391 from keszybz/coverity 
Coverity inspired fixes
 2016-01-21 11:50:08 +01:00
Daniel Mack 599601a4b9 Merge pull request #2222 from snakeroot/eventsplat 
hwdb: remove references to udevadm info /dev/input/event*
 2016-01-20 17:06:56 +01:00
Daniel Mack 8347ebc23a Merge pull request #2387 from keszybz/mhd-offset 
journal-gatewayd: fix offset
 2016-01-20 16:27:23 +01:00
Daniel Mack d619a0c4a5 Merge pull request #2373 from keszybz/man-api-build-3 
Man page grammar and build tweaks v3
 2016-01-19 20:44:58 +01:00
Daniel Mack 7a92163974 Merge pull request #2352 from martinpitt/master 
keymap: Add HP ProBook 440 G3
 2016-01-18 11:49:32 +01:00
Daniel Mack c64327b764 Merge pull request #2347 from aroig/gh/fix-udev-user-wants 
Fix broken SYSTEMD_USER_WANTS in udev rules.
 2016-01-18 10:53:49 +01:00
Daniel Mack 0cdf4f210c Merge pull request #2350 from evverx/fix-memory-leak-on-failed-preset-all 
core: fix memory leak on failed preset-all
 2016-01-18 10:52:15 +01:00
Daniel Mack e1333db540 Merge pull request #2349 from evverx/test-functions-cleanup 
tests: various fixes
 2016-01-18 10:51:19 +01:00
Daniel Mack 3855df576f Merge pull request #2340 from evverx/fix-memory-leak-on-enable-disable-etc 
core: fix memory leak on set-default, enable, disable etc
 2016-01-17 13:47:18 +01:00
Daniel Mack 05c72f0f18 Merge pull request #2334 from jwilk/spelling 
man: fix typos
 2016-01-15 13:11:16 +01:00
Daniel Mack bf8febb96a Merge pull request #2328 from evverx/fix-transient-units-memeory-leak 
Fix transient units memory leak
 2016-01-15 09:03:34 +01:00
Daniel Mack ca9ec350f3 Merge pull request #2320 from evverx/fix-memory-leak-on-reload 
Fix memory leak on daemon-reload
 2016-01-14 10:35:45 +01:00
Daniel Mack 8ec46f55e5 Merge pull request #2317 from evverx/rm-mtab 
README, tests: remove /etc/mtab
 2016-01-14 01:40:27 +01:00
Daniel Mack 0aaa263f16 Merge pull request #2312 from jsynacek/master 
man/tmpfiles.d: add note about permissions and ownership of symlinks
 2016-01-13 13:29:33 +01:00
Daniel Mack 4a6a24be18 Merge pull request #2303 from aadamowski/fix-miscalculated-buffer 
Fix miscalculated buffer size and uses of size-unlimited sprintf()
 2016-01-12 15:06:41 +01:00
Daniel Mack 8565742559 Merge pull request #2302 from arthur-c/master 
doc typo, src: systemd/src/journal-remote/journal-gatewayd.c
 2016-01-11 16:56:22 +01:00
Daniel Mack 5d354397ef Merge pull request #2296 from dankor/master 
Updated Ukrainian translation
 2016-01-11 13:13:25 +01:00
Daniel Mack cf6c8c46fc Merge pull request #2287 from dandedrick/journal-gatewayd-timeout-fix 
journal-gatewayd: timeout journal wait to allow thread cleanup
 2016-01-08 09:25:21 +01:00
Daniel Mack e056af1807 Merge pull request #2285 from evverx/fix-test-resolve 
tests: test-resolve: wait until all queries are completed
 2016-01-07 17:40:42 +01:00
Daniel Mack a2e9fd6233 Merge pull request #2283 from evverx/update-valgrind-tests 
build-sys: valgrind-tests: exclude python scripts too
 2016-01-07 12:02:38 +01:00
Daniel Mack e7c1446ee1 Merge pull request #2137 from fbuihuu/fstab-gen-fix-device-timeout 
Fstab gen fix device timeout
 2016-01-06 13:53:29 +01:00
Daniel Mack e433ebd2ff Merge pull request #2261 from evverx/fix-test-rlimit-util 
tests: don't change hard limit in test-rlimit-util
 2016-01-06 13:36:15 +01:00
Daniel Mack 0b460d9681 Merge pull request #2243 from evverx/add-regression-test-for-journald-restart 
tests: add regression test for `systemctl restart systemd-journald`
 2016-01-06 12:56:56 +01:00